Do not update RL entry title on distillation [chromium/src : main]
0 views
Skip to first unread message
Olivier Robin (Gerrit)
7:22 AM (1 hour ago) 7:22 AM
to Elmehdi Rahmaoui, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Elmehdi Rahmaoui
Olivier Robin voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Elmehdi Rahmaoui
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elmehdi Rahmaoui (Gerrit)
7:32 AM (1 hour ago) 7:32 AM
to Olivier Robin, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Olivier Robin
Elmehdi Rahmaoui voted and added 1 comment![]( "Open in Gerrit")
Votes added by Elmehdi Rahmaoui
| Code-Review | +1 |
1 comment
Commit Message
Line 11, Patchset 1 (Latest):
This data should not be synced without a user action (i.e. openin the RLElmehdi Rahmaoui . unresolved
Please fix this WARNING reported by Spellchecker: "openin" is a possible misspelling of "opening".
To bypass Spellchecker, add a ...
"openin" is a possible misspelling of "opening".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
Related details
Attention is currently required from:
- Olivier Robin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Robin (Gerrit)
8:34 AM (8 minutes ago) 8:34 AM
to Elmehdi Rahmaoui, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Olivier Robin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Olivier Robin
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
Commit Message
Line 11, Patchset 1:
This data should not be synced without a user action (i.e. openin the RLElmehdi Rahmaoui . resolved
Please fix this WARNING reported by Spellchecker: "openin" is a possible misspelling of "opening".
To bypass Spellchecker, add a ...
"openin" is a possible misspelling of "opening".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
8:38 AM (4 minutes ago) 8:38 AM
to Olivier Robin, Elmehdi Rahmaoui, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Do not update RL entry title on distillation
Title could convey information about private data that is only
accessible using cookies on this device. This data should not be synced
without a user action (i.e. opening the RL entry). To avoid this, just
do not update the title on distillation.
Fixed: 508290370
Change-Id: Ib7d0739fe2bedf3c1e0748fb9db43c86ec19a482
Commit-Queue: Olivier Robin <olivie...@chromium.org>
Reviewed-by: Elmehdi Rahmaoui <erah...@google.com>
Auto-Submit: Olivier Robin <olivie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1625339}
Files:
- M ios/chrome/browser/reading_list/model/reading_list_download_service.mm
Change size: XS
Delta: 1 file changed, 0 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Elmehdi Rahmaoui
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages