geolocation: Guarantee approximate location for approximate clients [chromium/src : main]

[Alvin Ji (Gerrit)]

Attention needed from Matt Reynolds

Alvin Ji added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Alvin Ji . resolved

Hi Matt,
As we discussed this is to prioritize the approximate location request when there are both precise and approximate request clients.
PTAL and thanks!
Alvin

Open in Gerrit

Related details

Attention is currently required from:

• Matt Reynolds

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I741c49895c08b01ba1f6ef90df2eb98459d05561

Gerrit-Change-Number: 7058734

Gerrit-PatchSet: 3

Gerrit-Owner: Alvin Ji <alv...@chromium.org>

Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>

Gerrit-Comment-Date: Mon, 20 Oct 2025 19:52:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Alvin Ji (Gerrit)]

Attention needed from Chromium IPC Reviews and Matt Reynolds

Alvin Ji added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Alvin Ji . resolved

Hi Chromium IPC Rreviwers,
PTAL at this change for services/device/public/mojom/geoposition.mojom
Thanks!
Alvin

Open in Gerrit

Related details

Attention is currently required from:

• Chromium IPC Reviews
• Matt Reynolds

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I741c49895c08b01ba1f6ef90df2eb98459d05561

Gerrit-Change-Number: 7058734

Gerrit-PatchSet: 3

Gerrit-Owner: Alvin Ji <alv...@chromium.org>

Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>

Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>

Gerrit-Comment-Date: Mon, 20 Oct 2025 20:14:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[gwsq (Gerrit)]

Attention needed from Fred Shih, Matt Reynolds and Mustafa Emre Acer

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
Shadow: ff...@chromium.org; IPC: mea...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

Shadow IPC reviewer(s): ff...@chromium.org. Please conduct an IPC review and CR+1 when satisfied. Remember to add the main reviewers to the attention set if needed.

Main IPC reviewer(s): mea...@chromium.org. Please wait for the shadowed IPC reviewer to CR+1 before reviewing.

Shadowed: ff...@chromium.org

Reviewer source(s):
ff...@chromium.org, mea...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Fred Shih
• Matt Reynolds
• Mustafa Emre Acer

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I741c49895c08b01ba1f6ef90df2eb98459d05561

Gerrit-Change-Number: 7058734

Gerrit-PatchSet: 3

Gerrit-Owner: Alvin Ji <alv...@chromium.org>

Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>

Gerrit-Reviewer: Fred Shih <ff...@chromium.org>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>

Gerrit-Attention: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-Attention: Fred Shih <ff...@chromium.org>

Gerrit-Comment-Date: Mon, 20 Oct 2025 20:18:43 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Fred Shih (Gerrit)]

Attention needed from Alvin Ji, Matt Reynolds and Mustafa Emre Acer

Fred Shih added 1 comment

File services/device/public/mojom/geoposition.mojom

Line 50, Patchset 3 (Latest): // Indicates whether the location is precise or approximate.
bool is_precise = true;

Fred Shih . unresolved

just to confirm, if fine grained location is not supported, this is the appropriate default right?

Open in Gerrit

Related details

Attention is currently required from:

• Alvin Ji

• Matt Reynolds
• Mustafa Emre Acer

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I741c49895c08b01ba1f6ef90df2eb98459d05561

Gerrit-Change-Number: 7058734

Gerrit-PatchSet: 3

Gerrit-Owner: Alvin Ji <alv...@chromium.org>

Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>

Gerrit-Reviewer: Fred Shih <ff...@chromium.org>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>

Gerrit-Attention: Alvin Ji <alv...@chromium.org>

Gerrit-Attention: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-Comment-Date: Mon, 20 Oct 2025 21:22:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Alvin Ji (Gerrit)]

Attention needed from Fred Shih, Matt Reynolds and Mustafa Emre Acer

Alvin Ji added 1 comment

File services/device/public/mojom/geoposition.mojom

Line 50, Patchset 3 (Latest): // Indicates whether the location is precise or approximate.
bool is_precise = true;

Fred Shih . unresolved

just to confirm, if fine grained location is not supported, this is the appropriate default right?

Alvin Ji

Yes, before approximate location feature, all location is considered precise.

Open in Gerrit

Related details

Attention is currently required from:

• Fred Shih

Gerrit-Attention: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-Attention: Fred Shih <ff...@chromium.org>

Gerrit-Comment-Date: Mon, 20 Oct 2025 21:25:59 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Fred Shih <ff...@chromium.org>

[Fred Shih (Gerrit)]

Attention needed from Alvin Ji, Matt Reynolds and Mustafa Emre Acer

Fred Shih voted and added 2 comments

Votes added by Fred Shih

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Fred Shih . resolved

lgtm!

File services/device/public/mojom/geoposition.mojom

Line 50, Patchset 3 (Latest): // Indicates whether the location is precise or approximate.
bool is_precise = true;

Fred Shih . resolved

just to confirm, if fine grained location is not supported, this is the appropriate default right?

Alvin Ji

Yes, before approximate location feature, all location is considered precise.

Fred Shih

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

• Alvin Ji

• Matt Reynolds
• Mustafa Emre Acer

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I741c49895c08b01ba1f6ef90df2eb98459d05561

Gerrit-Change-Number: 7058734

Gerrit-PatchSet: 3

Gerrit-Owner: Alvin Ji <alv...@chromium.org>

Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>

Gerrit-Reviewer: Fred Shih <ff...@chromium.org>

Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>

Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>

Gerrit-Attention: Alvin Ji <alv...@chromium.org>

Gerrit-Attention: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-Comment-Date: Mon, 20 Oct 2025 21:27:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Alvin Ji <alv...@chromium.org>

Comment-In-Reply-To: Fred Shih <ff...@chromium.org>