Reviewers: nodir
CL:
https://codereview.chromium.org/2407103002/https://codereview.chromium.org/2407103002/diff/1/tokenserver/appengine/services/admin/certauthorities/service.goFile tokenserver/appengine/services/admin/certauthorities/service.go
(right):
https://codereview.chromium.org/2407103002/diff/1/tokenserver/appengine/services/admin/certauthorities/service.go#newcode19tokenserver/appengine/services/admin/certauthorities/service.go:19: type
serverImpl struct {
basically this is the main point of this CL (and the whole refactoring).
RPC methods are implemented and tested separately, not in a single giant
*.go file.
Description:
token-server: Finish refactoring RPC server implementation.
This CL splits the rest of RPC servers into per-method implementations, as
started in previous two CLs.
No logic changes, just code moves.
R=no...@chromium.orgBUG=
Affected files (+1845, -1922 lines):
M tokenserver/api/admin/v1/admin.proto
M tokenserver/api/admin/v1/admin.pb.go
M tokenserver/api/admin/v1/adminserver_dec.go
M tokenserver/api/admin/v1/pb.discovery.go
A tokenserver/appengine/certchecker/rpc_check_certificate.go
A tokenserver/appengine/certchecker/rpc_is_revoked_cert.go
A + tokenserver/appengine/certconfig/rpc_fetch_crl.go
A tokenserver/appengine/certconfig/rpc_fetch_crl_test.go
A tokenserver/appengine/certconfig/rpc_get_ca_status_rpc.go
A tokenserver/appengine/certconfig/rpc_import_ca_configs.go
A tokenserver/appengine/certconfig/rpc_import_ca_configs_test.go
A tokenserver/appengine/certconfig/rpc_list_cas.go
M tokenserver/appengine/frontend/main.go
M tokenserver/appengine/services/admin/adminsrv/service.go
D tokenserver/appengine/services/admin/certauthorities/crl.go
M tokenserver/appengine/services/admin/certauthorities/service.go
D tokenserver/appengine/services/admin/certauthorities/service_test.go
M tokenserver/appengine/services/minter/tokenminter/service.go