Add BFCache lifecycle in DeclarativePerformanceObserver [chromium/src : main]

0 views

Skip to first unread message

Shunya Shishido (Gerrit)

unread,

May 29, 2026, 4:51:27 AM (3 days ago) May 29

to Takashi Toyoshima, Yoshisato Yanagisawa, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Takashi Toyoshima and Yoshisato Yanagisawa

Shunya Shishido voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Takashi Toyoshima
Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Takashi Toyoshima (Gerrit)

unread,

May 31, 2026, 10:48:22 PM (2 hours ago) May 31

to Shunya Shishido, Yoshisato Yanagisawa, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Shunya Shishido and Yoshisato Yanagisawa

Takashi Toyoshima voted and added 1 comment

Votes added by Takashi Toyoshima

Code-Review

1 comment

File content/browser/network/declarative_performance_observer.cc

Line 130, Patchset 4 (Latest): render_frame_host == active_rfh_) {

Takashi Toyoshima . unresolved

from the viewpoint of semantics, can we check this first?
check order of '&&' is ensured. so, starting with an important attribute would be a bit nicer. (also straight-forward as the order is the same with the argument order)