Move WebstoreInstallHelper to //extensions [chromium/src : main]

0 views
Skip to first unread message

Miyoung Shin (Gerrit)

unread,
Apr 3, 2026, 6:32:01 AM (11 days ago) Apr 3
to Devlin Cronin, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, nicolas...@chromium.org, crmulli...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Devlin Cronin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4b5ded57389d6b0112565e4d5e123de8365765fb
Gerrit-Change-Number: 7725426
Gerrit-PatchSet: 3
Gerrit-Owner: Miyoung Shin <myid...@igalia.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Miyoung Shin <myid...@igalia.com>
Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Apr 2026 10:31:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Sergii Bykov (Gerrit)

unread,
Apr 3, 2026, 7:00:09 AM (11 days ago) Apr 3
to Miyoung Shin, Devlin Cronin, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, nicolas...@chromium.org, crmulli...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin and Miyoung Shin

Sergii Bykov voted and added 1 comment

Votes added by Sergii Bykov

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Sergii Bykov . resolved

app_mode lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Devlin Cronin
  • Miyoung Shin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4b5ded57389d6b0112565e4d5e123de8365765fb
    Gerrit-Change-Number: 7725426
    Gerrit-PatchSet: 3
    Gerrit-Owner: Miyoung Shin <myid...@igalia.com>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Miyoung Shin <myid...@igalia.com>
    Gerrit-Reviewer: Sergii Bykov <sby...@google.com>
    Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Attention: Miyoung Shin <myid...@igalia.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 10:59:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Devlin Cronin (Gerrit)

    unread,
    Apr 11, 2026, 10:43:43 AM (3 days ago) Apr 11
    to Miyoung Shin, Devlin Cronin, Sergii Bykov, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, nicolas...@chromium.org, crmulli...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, extension...@chromium.org
    Attention needed from Miyoung Shin

    Devlin Cronin voted and added 1 comment

    Votes added by Devlin Cronin

    Code-Review+1

    1 comment

    Patchset-level comments
    Devlin Cronin . resolved

    Thanks, Miyoung! LGTM, though there are a couple comments on the upstream CL.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Miyoung Shin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4b5ded57389d6b0112565e4d5e123de8365765fb
    Gerrit-Change-Number: 7725426
    Gerrit-PatchSet: 3
    Gerrit-Owner: Miyoung Shin <myid...@igalia.com>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Miyoung Shin <myid...@igalia.com>
    Gerrit-Reviewer: Sergii Bykov <sby...@google.com>
    Gerrit-Attention: Miyoung Shin <myid...@igalia.com>
    Gerrit-Comment-Date: Sat, 11 Apr 2026 14:43:33 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Miyoung Shin (Gerrit)

    unread,
    3:36 AM (8 hours ago) 3:36 AM
    to Mike West, Devlin Cronin, Sergii Bykov, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, nicolas...@chromium.org, crmulli...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, extension...@chromium.org
    Attention needed from Mike West

    Miyoung Shin added 1 comment

    Patchset-level comments
    Miyoung Shin . resolved

    mkwst@ for //tools

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mike West
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4b5ded57389d6b0112565e4d5e123de8365765fb
    Gerrit-Change-Number: 7725426
    Gerrit-PatchSet: 3
    Gerrit-Owner: Miyoung Shin <myid...@igalia.com>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Miyoung Shin <myid...@igalia.com>
    Gerrit-Reviewer: Sergii Bykov <sby...@google.com>
    Gerrit-Attention: Mike West <mk...@chromium.org>
    Gerrit-Comment-Date: Tue, 14 Apr 2026 07:36:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mike West (Gerrit)

    unread,
    4:48 AM (7 hours ago) 4:48 AM
    to Miyoung Shin, Devlin Cronin, Sergii Bykov, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, nicolas...@chromium.org, crmulli...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, extension...@chromium.org
    Attention needed from Miyoung Shin

    Mike West voted and added 1 comment

    Votes added by Mike West

    Code-Review+1

    1 comment

    Patchset-level comments
    Mike West . resolved

    lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Miyoung Shin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4b5ded57389d6b0112565e4d5e123de8365765fb
    Gerrit-Change-Number: 7725426
    Gerrit-PatchSet: 3
    Gerrit-Owner: Miyoung Shin <myid...@igalia.com>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Miyoung Shin <myid...@igalia.com>
    Gerrit-Reviewer: Sergii Bykov <sby...@google.com>
    Gerrit-Attention: Miyoung Shin <myid...@igalia.com>
    Gerrit-Comment-Date: Tue, 14 Apr 2026 08:48:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages