Fix Is{Source,Target}LanguageSupported hist type [chromium/src : main]

0 views
Skip to first unread message

Trevor Perrier (Gerrit)

unread,
2:47 AM (10 hours ago) 2:47 AM
to Danilo Françoso Tedeschi, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Danilo Françoso Tedeschi

Trevor Perrier voted and added 1 comment

Votes added by Trevor Perrier

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Trevor Perrier . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Danilo Françoso Tedeschi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iee363616fd656c4787baf6be6301b716d5f5b582
Gerrit-Change-Number: 7694533
Gerrit-PatchSet: 1
Gerrit-Owner: Danilo Françoso Tedeschi <da...@google.com>
Gerrit-Reviewer: Danilo Françoso Tedeschi <da...@google.com>
Gerrit-Reviewer: Trevor Perrier <per...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Danilo Françoso Tedeschi <da...@google.com>
Gerrit-Comment-Date: Tue, 24 Mar 2026 06:46:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Danilo Françoso Tedeschi (Gerrit)

unread,
11:28 AM (1 hour ago) 11:28 AM
to Trevor Perrier, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

Danilo Françoso Tedeschi voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iee363616fd656c4787baf6be6301b716d5f5b582
Gerrit-Change-Number: 7694533
Gerrit-PatchSet: 1
Gerrit-Owner: Danilo Françoso Tedeschi <da...@google.com>
Gerrit-Reviewer: Danilo Françoso Tedeschi <da...@google.com>
Gerrit-Reviewer: Trevor Perrier <per...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Comment-Date: Tue, 24 Mar 2026 15:28:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
11:32 AM (1 hour ago) 11:32 AM
to Danilo Françoso Tedeschi, Trevor Perrier, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Fix Is{Source,Target}LanguageSupported hist type
Change-Id: Iee363616fd656c4787baf6be6301b716d5f5b582
Commit-Queue: Danilo Françoso Tedeschi <da...@google.com>
Reviewed-by: Trevor Perrier <per...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1604151}
Files:
  • M tools/metrics/histograms/metadata/translate/histograms.xml
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Trevor Perrier
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iee363616fd656c4787baf6be6301b716d5f5b582
Gerrit-Change-Number: 7694533
Gerrit-PatchSet: 2
Gerrit-Owner: Danilo Françoso Tedeschi <da...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Danilo Françoso Tedeschi <da...@google.com>
Gerrit-Reviewer: Trevor Perrier <per...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages