[Toast] Fix bug with toast showing on actuating tabs [chromium/src : main]
0 views
Skip to first unread message
Aashna Sheth (Gerrit)
Jan 9, 2026, 1:39:45 PM (3 days ago) Jan 9
to Rodney Ding, Bryant Chandler, Steven Luong, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Aashna Sheth, Bryant Chandler and Rodney Ding
Aashna Sheth added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Aashna Sheth . resolved
+ Rodney for /actor review
+ Steven for /toasts review
+ Bryant for visibility! Thanks for your tip!
Related details
Attention is currently required from:
- Aashna Sheth
- Bryant Chandler
- Rodney Ding
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steven Luong (Gerrit)
Jan 9, 2026, 1:39:47 PM (3 days ago) Jan 9
to Aashna Sheth, Bryant Chandler, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Aashna Sheth and Bryant Chandler
Steven Luong voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Aashna Sheth
- Bryant Chandler
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bryant Chandler (Gerrit)
Jan 9, 2026, 3:18:26 PM (3 days ago) Jan 9
to Aashna Sheth, Rodney Ding, Steven Luong, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Aashna Sheth and Rodney Ding
Bryant Chandler voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Aashna Sheth
- Rodney Ding
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rodney Ding (Gerrit)
11:03 AM (8 hours ago) 11:03 AM
to Aashna Sheth, Bryant Chandler, Steven Luong, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Aashna Sheth
Rodney Ding voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Aashna Sheth
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aashna Sheth (Gerrit)
11:10 AM (7 hours ago) 11:10 AM
to Rodney Ding, Bryant Chandler, Steven Luong, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Aashna Sheth voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:21 PM (6 hours ago) 12:21 PM
to Aashna Sheth, Rodney Ding, Bryant Chandler, Steven Luong, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Toast] Fix bug with toast showing on actuating tabs
Before:
https://screencast.googleplex.com/cast/NjIxODk5MTMzNTg5OTEzNnwxNWRlYjUwMC02YQ
After: http://screencast/cast/NjQ1NDQwMzI3NDg5OTQ1Nnw2Y2Q1ZWUzMy1iNQ
Note~ there is a case when the toast shows on an actuating tab (when the
side panel is closed on the tab that is actuating). The cases displayed
in this screencast are expected.
Bug: 474093341
Change-Id: I3c011d8fa0b17d9b9627917f4176d71ccba0667b
Reviewed-by: Bryant Chandler <bryantc...@chromium.org>
Reviewed-by: Rodney Ding <rodne...@google.com>
Reviewed-by: Steven Luong <stl...@chromium.org>
Commit-Queue: Aashna Sheth <aas...@google.com>
Cr-Commit-Position: refs/heads/main@{#1567847}
Files:
- M chrome/browser/glic/actor/glic_actor_task_manager.cc
- M chrome/browser/ui/toasts/toast_service.cc
Change size: XS
Delta: 2 files changed, 7 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Bryant Chandler, +1 by Steven Luong, +1 by Rodney Ding
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages