Implement GetV5GetHashProtocolManager for SafeBrowsingClientImpl [chromium/src : main]

[thefrog (Gerrit)]

Attention needed from Tim

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Tim

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iffdb05cfd3a5fa607aebe2e51d257f16956b8e95

Gerrit-Change-Number: 8131502

Gerrit-PatchSet: 16

Gerrit-Owner: thefrog <the...@chromium.org>

Gerrit-Reviewer: Tim <tjud...@chromium.org>

Gerrit-Reviewer: thefrog <the...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Tim <tjud...@chromium.org>

Gerrit-Comment-Date: Fri, 24 Jul 2026 14:12:11 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Tim (Gerrit)]

Attention needed from thefrog

Tim voted and added 2 comments

Votes added by Tim

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 16 (Latest):

Tim . resolved

Thanks, LGTM!

File extensions/browser/blocklist.cc

Line 103, Patchset 16 (Latest): base::WeakPtr<safe_browsing::V5GetHashProtocolManager>

Tim . unresolved

nit: We should `#include "base/memory/weak_ptr.h"` per IWYU.

Open in Gerrit

Related details

Attention is currently required from:

• thefrog

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iffdb05cfd3a5fa607aebe2e51d257f16956b8e95

Gerrit-Change-Number: 8131502

Gerrit-PatchSet: 16

Gerrit-Owner: thefrog <the...@chromium.org>

Gerrit-Reviewer: Tim <tjud...@chromium.org>

Gerrit-Reviewer: thefrog <the...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: thefrog <the...@chromium.org>

Gerrit-Comment-Date: Fri, 24 Jul 2026 21:53:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[thefrog (Gerrit)]

thefrog added 1 comment

File extensions/browser/blocklist.cc

Line 103, Patchset 16: base::WeakPtr<safe_browsing::V5GetHashProtocolManager>

Tim . resolved

nit: We should `#include "base/memory/weak_ptr.h"` per IWYU.

thefrog

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iffdb05cfd3a5fa607aebe2e51d257f16956b8e95

Gerrit-Change-Number: 8131502

Gerrit-PatchSet: 18

Gerrit-Owner: thefrog <the...@chromium.org>

Gerrit-Reviewer: Tim <tjud...@chromium.org>

Gerrit-Reviewer: thefrog <the...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Sat, 25 Jul 2026 01:51:14 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Tim <tjud...@chromium.org>

[thefrog (Gerrit)]

thefrog voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iffdb05cfd3a5fa607aebe2e51d257f16956b8e95

Gerrit-Change-Number: 8131502

Gerrit-PatchSet: 19

Gerrit-Owner: thefrog <the...@chromium.org>

Gerrit-Reviewer: Tim <tjud...@chromium.org>

Gerrit-Reviewer: thefrog <the...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Sat, 25 Jul 2026 03:17:50 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes