[chromecast] Fix Browser-process heap OOB write in AudioDecoderForMixer::WritePcm [chromium/src : main]

0 views
Skip to first unread message

Simeon Anfinrud (Gerrit)

unread,
Apr 27, 2026, 9:08:02 PM (13 days ago) Apr 27
to chromium...@chromium.org, Yuchen Liu, android-bu...@system.gserviceaccount.com, halliwe...@chromium.org, feature-me...@chromium.org
Attention needed from Yuchen Liu

Simeon Anfinrud added 5 comments

Message

Gemini says: Addressed Gerrit review comments.

5 comments

File chromecast/media/cma/backend/audio_decoder_for_mixer.cc
File-level comment, Patchset 6 (Latest):
Simeon Anfinrud . resolved

Gemini says: Done. Removed redundant calculation.

File-level comment, Patchset 6 (Latest):
Simeon Anfinrud . resolved

Gemini says: Done. `frame_count` is now `size_t` and redundancy is removed.

File chromecast/media/cma/backend/audio_decoder_for_mixer_unittest.cc
File-level comment, Patchset 6 (Latest):
Simeon Anfinrud . resolved

Gemini says: Done. Added missing includes.

File-level comment, Patchset 6 (Latest):
Simeon Anfinrud . resolved

Gemini says: Done. Used size_t for the calculation.

File-level comment, Patchset 6 (Latest):
Simeon Anfinrud . resolved

Gemini says: Done. Added `base::RunLoop().RunUntilIdle()`.

Open in Gerrit

Related details

Attention is currently required from:
  • Yuchen Liu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iadb13be1e1e4d6ea214dcdc72cc5c6805fe0cf80
Gerrit-Change-Number: 7765494
Gerrit-PatchSet: 6
Gerrit-Owner: Simeon Anfinrud <san...@chromium.org>
Gerrit-Reviewer: Yuchen Liu <yuc...@chromium.org>
Gerrit-Attention: Yuchen Liu <yuc...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 01:07:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Simeon Anfinrud (Gerrit)

unread,
Apr 29, 2026, 1:46:59 PM (11 days ago) Apr 29
to chromium...@chromium.org, Yuchen Liu, android-bu...@system.gserviceaccount.com, halliwe...@chromium.org, feature-me...@chromium.org
Attention needed from Yuchen Liu

Simeon Anfinrud voted and added 1 comment

Votes added by Simeon Anfinrud

Commit-Queue+1

1 comment

File chromecast/media/cma/backend/audio_decoder_for_mixer_unittest.cc
Line 18, Patchset 6 (Latest):namespace chromecast {
Simeon Anfinrud . unresolved

nit: new code can format this as `namespace chromecast::media {`

Open in Gerrit

Related details

Attention is currently required from:
  • Yuchen Liu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iadb13be1e1e4d6ea214dcdc72cc5c6805fe0cf80
    Gerrit-Change-Number: 7765494
    Gerrit-PatchSet: 6
    Gerrit-Owner: Simeon Anfinrud <san...@chromium.org>
    Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
    Gerrit-Comment-Date: Wed, 29 Apr 2026 17:46:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Simeon Anfinrud (Gerrit)

    unread,
    May 1, 2026, 9:57:47 PM (9 days ago) May 1
    to Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Yuchen Liu, android-bu...@system.gserviceaccount.com, halliwe...@chromium.org, feature-me...@chromium.org
    Attention needed from Yuchen Liu

    Simeon Anfinrud added 1 comment

    Message

    Gemini says: Addressed Gerrit review comments.

    1 comment

    File chromecast/media/cma/backend/audio_decoder_for_mixer_unittest.cc
    File-level comment, Patchset 7 (Latest):
    Simeon Anfinrud . resolved

    Gemini says: Done. Used C++17 namespace syntax.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Yuchen Liu
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iadb13be1e1e4d6ea214dcdc72cc5c6805fe0cf80
      Gerrit-Change-Number: 7765494
      Gerrit-PatchSet: 7
      Gerrit-Owner: Simeon Anfinrud <san...@chromium.org>
      Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
      Gerrit-Reviewer: Yuchen Liu <yuc...@chromium.org>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-Comment-Date: Sat, 02 May 2026 01:57:38 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Simeon Anfinrud (Gerrit)

      unread,
      May 3, 2026, 2:42:09 PM (7 days ago) May 3
      to Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Yuchen Liu, android-bu...@system.gserviceaccount.com, halliwe...@chromium.org, feature-me...@chromium.org
      Attention needed from Yuchen Liu

      Simeon Anfinrud voted Auto-Submit+1

      Auto-Submit+1
      Gerrit-Comment-Date: Sun, 03 May 2026 18:41:57 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Simeon Anfinrud (Gerrit)

      unread,
      May 9, 2026, 9:02:51 PM (16 hours ago) May 9
      to Yuchen Liu, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, halliwe...@chromium.org, feature-me...@chromium.org

      Simeon Anfinrud removed Yuchen Liu from this change

      Deleted Reviewers:
      • Yuchen Liu
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: deleteReviewer
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iadb13be1e1e4d6ea214dcdc72cc5c6805fe0cf80
      Gerrit-Change-Number: 7765494
      Gerrit-PatchSet: 8
      Gerrit-Owner: Simeon Anfinrud <san...@chromium.org>
      Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages