Cleanup AutofillEnableFillingPhoneCountryCodesByAddressCountryCodes [chromium/src : main]

0 views

Skip to first unread message

Jihad Hanna (Gerrit)

unread,

5:20 AM (3 hours ago) 5:20 AM

to Dominic Battre, chromium...@chromium.org, browser-comp...@chromium.org

Attention needed from Dominic Battre

Jihad Hanna voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Dominic Battre

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Battre (Gerrit)

unread,

5:24 AM (3 hours ago) 5:24 AM

to Jihad Hanna, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org

Attention needed from Jihad Hanna

Dominic Battre voted and added 1 comment

Votes added by Dominic Battre

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Dominic Battre . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Jihad Hanna

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

6:18 AM (2 hours ago) 6:18 AM

to Jihad Hanna, Dominic Battre, chromium...@chromium.org, browser-comp...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Cleanup AutofillEnableFillingPhoneCountryCodesByAddressCountryCodes

Fixed: 40249065

Change-Id: I00d4aee6ad8d86d2538dfbc9fcd5bfe277c502d1

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7748636

Commit-Queue: Jihad Hanna <jihad...@google.com>

Reviewed-by: Dominic Battre <bat...@chromium.org>

Commit-Queue: Dominic Battre <bat...@chromium.org>

Auto-Submit: Jihad Hanna <jihad...@google.com>

Cr-Commit-Position: refs/heads/main@{#1613603}

Files:

M components/autofill/core/browser/filling/addresses/field_filling_address_util.cc
M components/autofill/core/browser/filling/addresses/field_filling_address_util_unittest.cc
M components/autofill/core/common/autofill_features.cc
M components/autofill/core/common/autofill_features.h

Change size: L

Delta: 4 files changed, 224 insertions(+), 324 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Dominic Battre

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages