luci-ui: migrate test history to new RPC [infra/luci/luci-go : main]

0 views
Skip to first unread message

Heidi Chan (Gerrit)

unread,
Feb 26, 2026, 2:19:55 AM (4 days ago) Feb 26
to Patrick Meiring, android-buil...@google.com, chromium...@chromium.org, infra-revi...@chromium.org
Attention needed from Patrick Meiring

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Meiring
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/luci/luci-go
Gerrit-Branch: main
Gerrit-Change-Id: I312a73aa37d20d9b348150474528d9733e159799
Gerrit-Change-Number: 7605881
Gerrit-PatchSet: 5
Gerrit-Owner: Heidi Chan <heid...@google.com>
Gerrit-Reviewer: Patrick Meiring <mei...@google.com>
Gerrit-Attention: Patrick Meiring <mei...@google.com>
Gerrit-Comment-Date: Thu, 26 Feb 2026 07:19:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Heidi Chan (Gerrit)

unread,
Feb 26, 2026, 2:21:54 AM (4 days ago) Feb 26
to Patrick Meiring, android-buil...@google.com, chromium...@chromium.org, infra-revi...@chromium.org
Attention needed from Patrick Meiring

Heidi Chan added 1 comment

File milo/ui/src/test_investigation/components/test_info/test_history/source_verdicts_expanded.tsx
Line 318, Patchset 6 (Latest): const { data: response, isLoading: isLoadingVerdicts } = useQuery({
Heidi Chan . resolved

I think with the new RPC, it makes sense to just query once between start/end pos as it should give enough info, but please correct me if i'm wrong.

Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Meiring
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/luci/luci-go
Gerrit-Branch: main
Gerrit-Change-Id: I312a73aa37d20d9b348150474528d9733e159799
Gerrit-Change-Number: 7605881
Gerrit-PatchSet: 6
Gerrit-Owner: Heidi Chan <heid...@google.com>
Gerrit-Reviewer: Patrick Meiring <mei...@google.com>
Gerrit-Attention: Patrick Meiring <mei...@google.com>
Gerrit-Comment-Date: Thu, 26 Feb 2026 07:21:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Patrick Meiring (Gerrit)

unread,
Feb 26, 2026, 10:40:53 PM (3 days ago) Feb 26
to Heidi Chan, Mostafa Draz, android-buil...@google.com, chromium...@chromium.org, infra-revi...@chromium.org
Attention needed from Heidi Chan and Mostafa Draz

Patrick Meiring added 1 comment

File milo/ui/src/test_investigation/components/test_info/test_history/source_verdicts_expanded.tsx
Line 318, Patchset 6 (Latest): const { data: response, isLoading: isLoadingVerdicts } = useQuery({
Heidi Chan . unresolved

I think with the new RPC, it makes sense to just query once between start/end pos as it should give enough info, but please correct me if i'm wrong.

Patrick Meiring

I don't have enough context to understand how this is integrated / how the UI looks. However:

  • I notice you haven't specified a sort order.
  • If there are more than 1000 source verdicts, you will get the 1000 nearest source verdicts towards one of the two ends (depending on the selected sort order or the default order - this will be the most recent or the oldest results). Is this what you want?
Open in Gerrit

Related details

Attention is currently required from:
  • Heidi Chan
  • Mostafa Draz
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: infra/luci/luci-go
    Gerrit-Branch: main
    Gerrit-Change-Id: I312a73aa37d20d9b348150474528d9733e159799
    Gerrit-Change-Number: 7605881
    Gerrit-PatchSet: 6
    Gerrit-Owner: Heidi Chan <heid...@google.com>
    Gerrit-Reviewer: Mostafa Draz <md...@google.com>
    Gerrit-Reviewer: Patrick Meiring <mei...@google.com>
    Gerrit-Attention: Heidi Chan <heid...@google.com>
    Gerrit-Attention: Mostafa Draz <md...@google.com>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 03:40:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Heidi Chan <heid...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Heidi Chan (Gerrit)

    unread,
    Feb 27, 2026, 3:10:40 AM (3 days ago) Feb 27
    to Mostafa Draz, Patrick Meiring, android-buil...@google.com, chromium...@chromium.org, infra-revi...@chromium.org
    Attention needed from Mostafa Draz and Patrick Meiring

    Heidi Chan added 1 comment

    File milo/ui/src/test_investigation/components/test_info/test_history/source_verdicts_expanded.tsx
    Line 318, Patchset 6: const { data: response, isLoading: isLoadingVerdicts } = useQuery({
    Heidi Chan . resolved

    I think with the new RPC, it makes sense to just query once between start/end pos as it should give enough info, but please correct me if i'm wrong.

    Patrick Meiring

    I don't have enough context to understand how this is integrated / how the UI looks. However:

    • I notice you haven't specified a sort order.
    • If there are more than 1000 source verdicts, you will get the 1000 nearest source verdicts towards one of the two ends (depending on the selected sort order or the default order - this will be the most recent or the oldest results). Is this what you want?
    Heidi Chan

    on second thoughts i've just updated to
    1) fetch up to 1000 from the end position (most recent 1000)
    2) if there is more in the segment, fetches from the start position (oldest) -> only if there are >1000 segments and is recent enough.
    3) combines the two arrays then splits it in half to display from each end for the UI.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mostafa Draz
    • Patrick Meiring
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: infra/luci/luci-go
      Gerrit-Branch: main
      Gerrit-Change-Id: I312a73aa37d20d9b348150474528d9733e159799
      Gerrit-Change-Number: 7605881
      Gerrit-PatchSet: 7
      Gerrit-Owner: Heidi Chan <heid...@google.com>
      Gerrit-Reviewer: Mostafa Draz <md...@google.com>
      Gerrit-Reviewer: Patrick Meiring <mei...@google.com>
      Gerrit-Attention: Patrick Meiring <mei...@google.com>
      Gerrit-Attention: Mostafa Draz <md...@google.com>
      Gerrit-Comment-Date: Fri, 27 Feb 2026 08:10:35 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Patrick Meiring <mei...@google.com>
      Comment-In-Reply-To: Heidi Chan <heid...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Mostafa Draz (Gerrit)

      unread,
      12:16 AM (4 hours ago) 12:16 AM
      to Heidi Chan, Patrick Meiring, android-buil...@google.com, chromium...@chromium.org, infra-revi...@chromium.org
      Attention needed from Heidi Chan and Patrick Meiring

      Mostafa Draz voted and added 1 comment

      Votes added by Mostafa Draz

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 8 (Latest):
      Mostafa Draz . unresolved

      there were no tests for this?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Heidi Chan
      • Patrick Meiring
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: infra/luci/luci-go
      Gerrit-Branch: main
      Gerrit-Change-Id: I312a73aa37d20d9b348150474528d9733e159799
      Gerrit-Change-Number: 7605881
      Gerrit-PatchSet: 8
      Gerrit-Owner: Heidi Chan <heid...@google.com>
      Gerrit-Reviewer: Mostafa Draz <md...@google.com>
      Gerrit-Reviewer: Patrick Meiring <mei...@google.com>
      Gerrit-Attention: Patrick Meiring <mei...@google.com>
      Gerrit-Attention: Heidi Chan <heid...@google.com>
      Gerrit-Comment-Date: Mon, 02 Mar 2026 05:16:54 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages