Migrate deprecated PerformRequest() calls in gif_tenor_api_fetcher.cc [chromium/src : main]
0 views
Skip to first unread message
Daniel Cheng (Gerrit)
Aug 28, 2025, 11:35:52 PM (9 days ago) Aug 28
to Daniel Cheng, Essential Inputs Reviews, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org
Attention needed from Essential Inputs Reviews
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Essential Inputs Reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Aug 28, 2025, 11:36:30 PM (9 days ago) Aug 28
to Daniel Cheng, Mehrab N, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org
Attention needed from Mehrab N
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
meh...@chromium.org is from context(chrome/inputs/essential-inputs.gwsq)
Related details
Attention is currently required from:
- Mehrab N
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Sep 2, 2025, 4:34:03 PM (5 days ago) Sep 2
to Daniel Cheng, Mehrab N, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org
Attention needed from Mehrab N
Daniel Cheng added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Mehrab N
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darren Shen (Gerrit)
Sep 4, 2025, 9:11:05 PM (2 days ago) Sep 4
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, ananyasee...@google.com, ayman...@chromium.org, christia...@chromium.org, chrome-tab-group-en...@google.com, jdonnel...@chromium.org, mdjone...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, yuezhang...@chromium.org, ipc-securi...@chromium.org, oshima...@chromium.org
Attention needed from Daniel Cheng
Darren Shen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Sep 5, 2025, 12:07:11 AM (2 days ago) Sep 5
to Daniel Cheng, Darren Shen, Chromium LUCI CQ, chromium...@chromium.org, ananyasee...@google.com, ayman...@chromium.org, christia...@chromium.org, chrome-tab-group-en...@google.com, jdonnel...@chromium.org, mdjone...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, yuezhang...@chromium.org, ipc-securi...@chromium.org, oshima...@chromium.org
Daniel Cheng voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 5, 2025, 12:37:30 AM (2 days ago) Sep 5
to Daniel Cheng, Darren Shen, chromium...@chromium.org, ananyasee...@google.com, ayman...@chromium.org, christia...@chromium.org, chrome-tab-group-en...@google.com, jdonnel...@chromium.org, mdjone...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, yuezhang...@chromium.org, ipc-securi...@chromium.org, oshima...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Migrate deprecated PerformRequest() calls in gif_tenor_api_fetcher.cc
`PerformRequest()` is deprecated. Since the fetcher itself is
constructed with an auth type of `NO_AUTH` (this is the builder
default), and the fetcher is called with a null key, this is a
straightforward migration to just call `Fetch()` instead.
Bug: 284531303
Change-Id: Ia13e6c5cd1e520d5127379e1ccded5072a9f697a
Reviewed-by: Darren Shen <sh...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1511309}
Files:
- M chromeos/ash/components/emoji/gif_tenor_api_fetcher.cc
Change size: S
Delta: 1 file changed, 15 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darren Shen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages