Remove blink::WebString::FromUTF8() [chromium/src : main]
0 views
Skip to first unread message
Kent Tamura (Gerrit)
3:43 AM (8 hours ago) 3:43 AM
to Kent Tamura, Fredrik Söderquist, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, blink-re...@chromium.org, pdf-r...@chromium.org
Attention needed from Fredrik Söderquist
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Auto-Submit | +1 |
| Owners-Override | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
4:30 AM (7 hours ago) 4:30 AM
to Kent Tamura, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, blink-re...@chromium.org, pdf-r...@chromium.org
Attention needed from Kent Tamura
Fredrik Söderquist voted![]( "Open in Gerrit")
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
4:46 AM (7 hours ago) 4:46 AM
to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, blink-re...@chromium.org, pdf-r...@chromium.org
chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove blink::WebString::FromUTF8()
We prefer FromUtf8().
This CL has no behavior changes.
Bug: 492927412
Change-Id: I3976e85012e2189dd4377a7cd49148771970d158
Commit-Queue: Fredrik Söderquist <f...@opera.com>
Owners-Override: Kent Tamura <tk...@chromium.org>
Auto-Submit: Kent Tamura <tk...@chromium.org>
Reviewed-by: Fredrik Söderquist <f...@opera.com>
Cr-Commit-Position: refs/heads/main@{#1614316}
Files:
- M pdf/loader/url_loader.cc
- M pdf/pdf_view_web_plugin.cc
- M pdf/pdf_view_web_plugin_unittest.cc
- M pdf/pdfium/pdfium_font_helpers.cc
- M third_party/blink/public/platform/web_string.h
- M tools/code_cache_generator/code_cache_generator.cc
Change size: S
Delta: 6 files changed, 18 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Fredrik Söderquist
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
4:58 AM (7 hours ago) 4:58 AM
to chromiu...@luci-project-accounts.iam.gserviceaccount.com, Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, blink-re...@chromium.org, pdf-r...@chromium.org
luci-bi...@appspot.gserviceaccount.com has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages