Fix RFHImpl::CancelPrerendering crash during WebContents teardown. [chromium/src : main]

0 views

Skip to first unread message

Gabriel Charette (Gerrit)

unread,

Jul 7, 2026, 1:30:25 PM (22 hours ago) Jul 7

to Gabriel Charette, Hiroki Nakagawa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, gavin...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org

Attention needed from Hiroki Nakagawa

Gabriel Charette voted and added 1 comment

Votes added by Gabriel Charette

Auto-Submit	+1
Commit-Queue	+1

1 comment

File content/browser/renderer_host/render_frame_host_impl.cc

Line 14690, Patchset 6:

  WebContents* web_contents = WebContents::FromRenderFrameHost(this);
  if (web_contents && web_contents->IsBeingDestroyed()) {
    return false;
  }

Hiroki Nakagawa . unresolved

WebContents cannot be directly accessed in content/browser/renderer_host/. See the README here:
https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/README.md;l=85-89;drc=dd260a2e28e777cbfdf925ddef38db34c4d6b9d0
I ran out of time to find a workaround today, but I wanted to share this early so you're aware.

Gabriel Charette

How about this? Looks like we can get away with diamond inheritance to get the existing property through the delegate.

Open in Gerrit

Related details

Attention is currently required from:

Hiroki Nakagawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hiroki Nakagawa (Gerrit)

unread,

9:43 AM (1 hour ago) 9:43 AM

to Gabriel Charette, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, gavin...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org

Attention needed from Gabriel Charette

Hiroki Nakagawa voted and added 2 comments

Votes added by Hiroki Nakagawa

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Hiroki Nakagawa . resolved

LGTM, thank you!