[iOS][Cobrowse] Don't skip responder delegate call in cobrowse [chromium/src : main]
0 views
Skip to first unread message
Radu Nitescu (Gerrit)
9:08 AM (9 hours ago) 9:08 AM
to Christian Xu, chromium...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Christian Xu
Radu Nitescu voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Christian Xu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Xu (Gerrit)
9:18 AM (9 hours ago) 9:18 AM
to Radu Nitescu, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Radu Nitescu
Christian Xu voted![]( "Open in Gerrit")
Attention is currently required from:
- Radu Nitescu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:08 AM (8 hours ago) 10:08 AM
to Radu Nitescu, Christian Xu, chromium...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS][Cobrowse] Don't skip responder delegate call in cobrowse
The omniboxDidBecomeFirstResponder callback was failing to trigger
because the controller incorrectly gated it behind a suggestion-based
check. Since Cobrowse doesn't utilize standard suggestions, this check
consistently failed.
Also remove the unnecessary endEditing now that delegate calls are
balanced.
Change-Id: Ib59038c22ec0a4378b87b1b181d4d6c8f87572b9
Commit-Queue: Christian Xu <chris...@chromium.org>
Reviewed-by: Christian Xu <chris...@chromium.org>
Auto-Submit: Radu Nitescu <radun...@google.com>
Commit-Queue: Radu Nitescu <radun...@google.com>
Cr-Commit-Position: refs/heads/main@{#1603442}
Files:
- M ios/chrome/browser/cobrowse/coordinator/assistant_aim_coordinator.mm
- M ios/chrome/browser/omnibox/model/omnibox_text_controller.mm
Change size: XS
Delta: 2 files changed, 2 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Christian Xu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages