Revert "Remove the expired blink memory cache UMAs" [chromium/src : main]

0 views
Skip to first unread message

Francois Pierre Doray (Gerrit)

unread,
Sep 3, 2025, 8:53:39 AM (4 days ago) Sep 3
to Jiacheng Guo, Chromium LUCI CQ, Takashi Toyoshima, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin
Attention needed from Jiacheng Guo and Takashi Toyoshima

Francois Pierre Doray has uploaded the change for review

Francois Pierre Doray would like Jiacheng Guo, Chromium LUCI CQ and Takashi Toyoshima to review this change.

Commit message

Revert "Remove the expired blink memory cache UMAs"

This reverts commit e69b5f14cabdba23eb64d347878805c04fb538d6.

Reason for revert: The histograms will be used to understand the
impact of new Memory Cache policy tweaks (see 
MemoryCacheStrongRefPruningTuneUp in testing config).

Bug: 420780825
Original change's description:
> Remove the expired blink memory cache UMAs
>
> The UMAs are added for investigating adding strong references in the
> blink memory cache. Since the feature has been launched, the UMAs can be
> removed.
>
> OBSOLETE_HISTOGRAMS=Removed after feature launch
>
> Bug: 420780825
> Change-Id: Ife20ed4e4f515366f5bba784aec71df255c0cc59
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6596089
> Commit-Queue: Jiacheng Guo <g...@google.com>
> Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1466867}
Bug: 420780825
Change-Id: I34a956950340e397c1e76d9ee09f495f0ff9a988

Change diff


Change information

Files:
  • A chrome/browser/page_load_metrics/integration_tests/cross_document_resource_reuse_test.cc
  • A chrome/browser/page_load_metrics/integration_tests/data/cross_document_resource.html
  • A chrome/browser/page_load_metrics/integration_tests/data/cross_document_resource_reuse.html
  • M chrome/browser/page_load_metrics/integration_tests/sources.gni
  • M third_party/blink/renderer/core/loader/resource/font_resource_test.cc
  • M third_party/blink/renderer/core/loader/resource/image_resource_test.cc
  • M third_party/blink/renderer/platform/loader/fetch/memory_cache.cc
  • M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
  • M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
  • M third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
  • M tools/metrics/histograms/metadata/blink/histograms.xml
Change size: L
Delta: 11 files changed, 466 insertions(+), 2 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Jiacheng Guo
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I34a956950340e397c1e76d9ee09f495f0ff9a988
Gerrit-Change-Number: 6908293
Gerrit-PatchSet: 1
Gerrit-Owner: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Jiacheng Guo <g...@google.com>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Sep 3, 2025, 8:54:20 AM (4 days ago) Sep 3
to Francois Pierre Doray, AyeAye, Jiacheng Guo, Chromium LUCI CQ, Takashi Toyoshima, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, kinuko...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org
Attention needed from Jiacheng Guo and Takashi Toyoshima

Message from Rubber Stamper

The change is not in the configured time window. Rubber Stamper is only allowed to review reverts within 14 day(s). Learn more: go/rubber-stamper-user-guide.

Open in Gerrit

Related details

Attention is currently required from:
  • Jiacheng Guo
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I34a956950340e397c1e76d9ee09f495f0ff9a988
Gerrit-Change-Number: 6908293
Gerrit-PatchSet: 2
Gerrit-Owner: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Jiacheng Guo <g...@google.com>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Sep 2025 12:54:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Francois Pierre Doray (Gerrit)

unread,
Sep 3, 2025, 8:54:49 AM (4 days ago) Sep 3
to AyeAye, Chromium LUCI CQ, Takashi Toyoshima, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, kinuko...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org
Attention needed from Takashi Toyoshima

Francois Pierre Doray voted and added 1 comment

Votes added by Francois Pierre Doray

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Francois Pierre Doray . resolved

toyoshim@: Please take a look. Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I34a956950340e397c1e76d9ee09f495f0ff9a988
Gerrit-Change-Number: 6908293
Gerrit-PatchSet: 2
Gerrit-Owner: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Sep 2025 12:54:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Francois Pierre Doray (Gerrit)

unread,
Sep 3, 2025, 8:55:45 AM (4 days ago) Sep 3
to AyeAye, Chromium LUCI CQ, Takashi Toyoshima, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, kinuko...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org
Attention needed from Takashi Toyoshima

Francois Pierre Doray voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I34a956950340e397c1e76d9ee09f495f0ff9a988
Gerrit-Change-Number: 6908293
Gerrit-PatchSet: 3
Gerrit-Owner: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Sep 2025 12:55:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Francois Pierre Doray (Gerrit)

unread,
Sep 3, 2025, 9:50:46 AM (4 days ago) Sep 3
to AyeAye, Chromium LUCI CQ, Takashi Toyoshima, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, kinuko...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org
Attention needed from Takashi Toyoshima

Francois Pierre Doray voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I34a956950340e397c1e76d9ee09f495f0ff9a988
Gerrit-Change-Number: 6908293
Gerrit-PatchSet: 7
Gerrit-Owner: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Sep 2025 13:50:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Takashi Toyoshima (Gerrit)

unread,
Sep 4, 2025, 2:27:12 AM (3 days ago) Sep 4
to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, kinuko...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org
Attention needed from Francois Pierre Doray

Takashi Toyoshima voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I34a956950340e397c1e76d9ee09f495f0ff9a988
Gerrit-Change-Number: 6908293
Gerrit-PatchSet: 8
Gerrit-Owner: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Sep 2025 06:26:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Takashi Toyoshima (Gerrit)

unread,
Sep 4, 2025, 2:29:20 AM (3 days ago) Sep 4
to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, kinuko...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org
Attention needed from Francois Pierre Doray

Takashi Toyoshima voted Commit-Queue+1

Commit-Queue+1
Gerrit-Comment-Date: Thu, 04 Sep 2025 06:28:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Takashi Toyoshima (Gerrit)

unread,
Sep 4, 2025, 2:31:05 AM (3 days ago) Sep 4
to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, kinuko...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org
Attention needed from Francois Pierre Doray

Takashi Toyoshima added 1 comment

File tools/metrics/histograms/metadata/blink/histograms.xml
Line 4057, Patchset 8 (Latest): the same url in a document will be counted only once.
Takashi Toyoshima . unresolved

Can you add a missing period comment here and others below?

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I34a956950340e397c1e76d9ee09f495f0ff9a988
    Gerrit-Change-Number: 6908293
    Gerrit-PatchSet: 8
    Gerrit-Owner: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Comment-Date: Thu, 04 Sep 2025 06:30:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Francois Pierre Doray (Gerrit)

    unread,
    Sep 4, 2025, 8:20:52 PM (2 days ago) Sep 4
    to Takashi Toyoshima, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, kinuko...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org

    Francois Pierre Doray voted and added 1 comment

    Votes added by Francois Pierre Doray

    Auto-Submit+1
    Commit-Queue+2

    1 comment

    File tools/metrics/histograms/metadata/blink/histograms.xml
    Line 4057, Patchset 8 (Latest): the same url in a document will be counted only once.
    Takashi Toyoshima . resolved

    Can you add a missing period comment here and others below?

    Francois Pierre Doray

    Since there is a new histogram name, I believe that the comment is not necessary? We don't have to think about missing data in some periods, given that this is like a new histogram.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I34a956950340e397c1e76d9ee09f495f0ff9a988
    Gerrit-Change-Number: 6908293
    Gerrit-PatchSet: 8
    Gerrit-Owner: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Sep 2025 00:20:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Takashi Toyoshima <toyo...@chromium.org>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 4, 2025, 9:15:01 PM (2 days ago) Sep 4
    to Francois Pierre Doray, Takashi Toyoshima, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, kinuko...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "Remove the expired blink memory cache UMAs"

    This reverts commit e69b5f14cabdba23eb64d347878805c04fb538d6.

    Reason for revert: The histograms will be used to understand the
    impact of new Memory Cache policy tweaks (see
    MemoryCacheStrongRefPruningTuneUp in testing config).

    Original change's description:
    > Remove the expired blink memory cache UMAs
    >
    > The UMAs are added for investigating adding strong references in the
    > blink memory cache. Since the feature has been launched, the UMAs can be
    > removed.
    >
    > OBSOLETE_HISTOGRAMS=Removed after feature launch
    >
    > Bug: 420780825
    > Change-Id: Ife20ed4e4f515366f5bba784aec71df255c0cc59
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6596089
    > Commit-Queue: Jiacheng Guo <g...@google.com>
    > Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1466867}
    Bug: 420780825, 432275223
    Bypass-Check-License: Bringing back files created in the past
    Change-Id: I34a956950340e397c1e76d9ee09f495f0ff9a988
    Commit-Queue: Francois Pierre Doray <fdo...@chromium.org>
    Auto-Submit: Francois Pierre Doray <fdo...@chromium.org>
    Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1511261}
    Files:
    • A chrome/browser/page_load_metrics/integration_tests/cross_document_resource_reuse_test.cc
    • A chrome/browser/page_load_metrics/integration_tests/data/cross_document_resource.html
    • A chrome/browser/page_load_metrics/integration_tests/data/cross_document_resource_reuse.html
    • M chrome/browser/page_load_metrics/integration_tests/sources.gni
    • M third_party/blink/renderer/core/loader/resource/font_resource_test.cc
    • M third_party/blink/renderer/core/loader/resource/image_resource_test.cc
    • M third_party/blink/renderer/platform/loader/fetch/memory_cache.cc
    • M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
    • M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
    • M third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
    • M tools/metrics/histograms/metadata/blink/histograms.xml
    Change size: L
    Delta: 11 files changed, 448 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Takashi Toyoshima
     Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: merged 
    

     Gerrit-Project: chromium/src 
    

     Gerrit-Branch: main 
    

     Gerrit-Change-Id: I34a956950340e397c1e76d9ee09f495f0ff9a988 
    

     Gerrit-Change-Number: 6908293 
    

     Gerrit-PatchSet: 9 
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages