LPP: Integrate Reauth and Recovery Reorder fixes [chromium/src : main]
Fahad Mansoor (Gerrit)
Fahad Mansoor added 3 comments![]( "Open in Gerrit")
PTAL!
I was doing some manual tests and found some issues that needed fixing.
wizard_context_->show_recovery_password_selection_screen = true;I needed to introduce a flag here, as during testing I found out that more things go through ( gaia manual password change etc) recovery, and without this flag we will always go into the password selection screen during recovery which isn't the correct behavior.
auto mount_state = context->GetMountState();This helps us in determining whether we are before the cryptohome mount or after. as I found out that in certain edge cases ( Reauth that turns into recovery with automatic online password update we can indeed go through this flow before cryptohome is mounted.)
Related details
- Denis Kuznetsov
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Denis Kuznetsov (Gerrit)
Denis Kuznetsov added 4 comments![]( "Open in Gerrit")
dynamically enable kManagedLocalPinAndPassword and kRecoveryFlowReorder flags based on test parameters.supernit: line length
bool show_recovery_password_selection_screen = false;Please add a comment on the intended use/effect.
It is unclear if it used to suppress screen or force it to be shown.
auto mount_state = context->GetMountState();This helps us in determining whether we are before the cryptohome mount or after. as I found out that in certain edge cases ( Reauth that turns into recovery with automatic online password update we can indeed go through this flow before cryptohome is mounted.)
Could you comment (in code) a bit more here what is the flow that leads us here without mounting?
This is kind of knowledge that gets lost very fast.
Related details
- Fahad Mansoor
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fahad Mansoor (Gerrit)
Message from Fahad Mansoor![]( "Open in Gerrit")
Done. Addressed all comments: reformatted commit message line lengths and added descriptive comments in wizard_context.h and wizard_controller.cc.
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fahad Mansoor (Gerrit)
Fahad Mansoor added 4 comments![]( "Open in Gerrit")
dynamically enable kManagedLocalPinAndPassword and kRecoveryFlowReorder flags based on test parameters.Fahad Mansoorsupernit: line length
Done
bool show_recovery_password_selection_screen = false;Please add a comment on the intended use/effect.
It is unclear if it used to suppress screen or force it to be shown.
Done
wizard_context_->show_recovery_password_selection_screen = true;I needed to introduce a flag here, as during testing I found out that more things go through ( gaia manual password change etc) recovery, and without this flag we will always go into the password selection screen during recovery which isn't the correct behavior.
Acknowledged
auto mount_state = context->GetMountState();Denis KuznetsovThis helps us in determining whether we are before the cryptohome mount or after. as I found out that in certain edge cases ( Reauth that turns into recovery with automatic online password update we can indeed go through this flow before cryptohome is mounted.)
Could you comment (in code) a bit more here what is the flow that leads us here without mounting?
This is kind of knowledge that gets lost very fast.
- Denis Kuznetsov
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |