Revert "[Glic] Make side panel and action react to eligibility changes." [chromium/src : main]

0 views
Skip to first unread message

Minoru Chikamune (Gerrit)

unread,
Sep 4, 2025, 8:55:12 PM (2 days ago) Sep 4
to Basia Zimirska, Eshwar Stalin, Ian Wells, Chromium LUCI CQ, Trevor Perrier, Chromium Metrics Reviews, chromium...@chromium.org, AyeAye, Minoru Chikamune

Minoru Chikamune has uploaded the change for review

Minoru Chikamune would like Basia Zimirska, Eshwar Stalin, Ian Wells, Chromium LUCI CQ and Trevor Perrier to review this change.

Commit message

Revert "[Glic] Make side panel and action react to eligibility changes."

This reverts commit e8600bb8b702df6a2538e410ff77d56d06e6a9d2.

Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64

Bug: 441349768
Original change's description:
> [Glic] Make side panel and action react to eligibility changes.
>
> Eligibility state can change after side panel entry and browser actions are added.
>
> When profile becomes eligible: side panel entry is registered and browser action becomes visible
> When profile becomes ineligible:  browser action is hidden, side panel is closed and un registered, observer removed
>
>
> Bug: 441349768
> Change-Id: I168f66bd5b8cd2bf398a6c7bd10e1753b67ceb6d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6898320
> Commit-Queue: Basia Zimirska <bas...@google.com>
> Reviewed-by: Ian Wells <iwe...@chromium.org>
> Reviewed-by: Trevor Perrier <per...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1510981}
Bug: 441349768
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I7ef6ad632e7b7af3578df823615226aa737d35c8

Change diff


Change information

Files:
  • M chrome/browser/BUILD.gn
  • M chrome/browser/ui/browser_actions.cc
  • M chrome/browser/ui/browser_window/internal/browser_window_features.cc
  • M chrome/browser/ui/views/side_panel/glic/glic_side_panel_coordinator.cc
  • M chrome/browser/ui/views/side_panel/glic/glic_side_panel_coordinator.h
  • D chrome/browser/ui/views/side_panel/glic/glic_side_panel_coordinator_browsertest.cc
  • M chrome/browser/ui/views/toolbar/toolbar_controller.cc
  • M chrome/test/BUILD.gn
  • M tools/metrics/actions/actions.xml
Change size: M
Delta: 9 files changed, 21 insertions(+), 211 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7ef6ad632e7b7af3578df823615226aa737d35c8
Gerrit-Change-Number: 6917228
Gerrit-PatchSet: 1
Gerrit-Owner: Minoru Chikamune <chik...@chromium.org>
Gerrit-Reviewer: Basia Zimirska <bas...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: Ian Wells <iwe...@chromium.org>
Gerrit-Reviewer: Trevor Perrier <per...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Minoru Chikamune (Gerrit)

unread,
Sep 4, 2025, 8:57:01 PM (2 days ago) Sep 4
to Minoru Chikamune, Rubber Stamper, Basia Zimirska, Eshwar Stalin, Ian Wells, Chromium LUCI CQ, Trevor Perrier, Chromium Metrics Reviews, chromium...@chromium.org, AyeAye, asvitkine...@chromium.org
Attention needed from Basia Zimirska, Eshwar Stalin, Ian Wells and Trevor Perrier

Message from Minoru Chikamune

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Basia Zimirska
  • Eshwar Stalin
  • Ian Wells
  • Trevor Perrier
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7ef6ad632e7b7af3578df823615226aa737d35c8
Gerrit-Change-Number: 6917228
Gerrit-PatchSet: 2
Gerrit-Owner: Minoru Chikamune <chik...@chromium.org>
Gerrit-Reviewer: Basia Zimirska <bas...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: Ian Wells <iwe...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Trevor Perrier <per...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Basia Zimirska <bas...@google.com>
Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
Gerrit-Attention: Ian Wells <iwe...@chromium.org>
Gerrit-Attention: Trevor Perrier <per...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Sep 2025 00:56:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Sep 4, 2025, 8:57:17 PM (2 days ago) Sep 4
to Minoru Chikamune, Basia Zimirska, Eshwar Stalin, Ian Wells, Chromium LUCI CQ, Trevor Perrier, Chromium Metrics Reviews, chromium...@chromium.org, AyeAye, asvitkine...@chromium.org
Attention needed from Basia Zimirska, Eshwar Stalin, Ian Wells and Trevor Perrier

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Basia Zimirska
  • Eshwar Stalin
  • Ian Wells
  • Trevor Perrier
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7ef6ad632e7b7af3578df823615226aa737d35c8
    Gerrit-Change-Number: 6917228
    Gerrit-PatchSet: 2
    Gerrit-Owner: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Reviewer: Basia Zimirska <bas...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
    Gerrit-Reviewer: Ian Wells <iwe...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Trevor Perrier <per...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Basia Zimirska <bas...@google.com>
    Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
    Gerrit-Attention: Ian Wells <iwe...@chromium.org>
    Gerrit-Attention: Trevor Perrier <per...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Sep 2025 00:57:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Minoru Chikamune (Gerrit)

    unread,
    Sep 4, 2025, 8:59:42 PM (2 days ago) Sep 4
    to Minoru Chikamune, Rubber Stamper, Basia Zimirska, Eshwar Stalin, Ian Wells, Chromium LUCI CQ, Trevor Perrier, Chromium Metrics Reviews, chromium...@chromium.org, AyeAye, asvitkine...@chromium.org
    Attention needed from Basia Zimirska, Eshwar Stalin, Ian Wells and Trevor Perrier

    Minoru Chikamune voted

    Auto-Submit+1
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Basia Zimirska
    • Eshwar Stalin
    • Ian Wells
    • Trevor Perrier
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7ef6ad632e7b7af3578df823615226aa737d35c8
    Gerrit-Change-Number: 6917228
    Gerrit-PatchSet: 2
    Gerrit-Owner: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Reviewer: Basia Zimirska <bas...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
    Gerrit-Reviewer: Ian Wells <iwe...@chromium.org>
    Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Trevor Perrier <per...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Basia Zimirska <bas...@google.com>
    Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
    Gerrit-Attention: Ian Wells <iwe...@chromium.org>
    Gerrit-Attention: Trevor Perrier <per...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Sep 2025 00:59:31 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Kentaro Hara (Gerrit)

    unread,
    Sep 4, 2025, 9:00:13 PM (2 days ago) Sep 4
    to Minoru Chikamune, Rubber Stamper, Basia Zimirska, Eshwar Stalin, Ian Wells, Chromium LUCI CQ, Trevor Perrier, Chromium Metrics Reviews, chromium...@chromium.org, AyeAye, asvitkine...@chromium.org
    Attention needed from Basia Zimirska, Eshwar Stalin, Ian Wells, Minoru Chikamune and Trevor Perrier

    Kentaro Hara voted and added 1 comment

    Votes added by Kentaro Hara

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Kentaro Hara . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Basia Zimirska
    • Eshwar Stalin
    • Ian Wells
    • Minoru Chikamune
    • Trevor Perrier
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7ef6ad632e7b7af3578df823615226aa737d35c8
    Gerrit-Change-Number: 6917228
    Gerrit-PatchSet: 2
    Gerrit-Owner: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Reviewer: Basia Zimirska <bas...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
    Gerrit-Reviewer: Ian Wells <iwe...@chromium.org>
    Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
    Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Trevor Perrier <per...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Basia Zimirska <bas...@google.com>
    Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
    Gerrit-Attention: Ian Wells <iwe...@chromium.org>
    Gerrit-Attention: Trevor Perrier <per...@chromium.org>
    Gerrit-Attention: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Sep 2025 00:59:44 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Minoru Chikamune (Gerrit)

    unread,
    Sep 4, 2025, 9:00:14 PM (2 days ago) Sep 4
    to Minoru Chikamune, Kentaro Hara, Rubber Stamper, Basia Zimirska, Eshwar Stalin, Ian Wells, Chromium LUCI CQ, Trevor Perrier, Chromium Metrics Reviews, chromium...@chromium.org, AyeAye, asvitkine...@chromium.org
    Attention needed from Basia Zimirska, Eshwar Stalin, Ian Wells and Trevor Perrier

    Minoru Chikamune voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Basia Zimirska
    • Eshwar Stalin
    • Ian Wells
    • Trevor Perrier
    Gerrit-Comment-Date: Fri, 05 Sep 2025 01:00:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 4, 2025, 9:00:38 PM (2 days ago) Sep 4
    to Minoru Chikamune, Kentaro Hara, Rubber Stamper, Basia Zimirska, Eshwar Stalin, Ian Wells, Trevor Perrier, Chromium Metrics Reviews, chromium...@chromium.org, AyeAye, asvitkine...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "[Glic] Make side panel and action react to eligibility changes."

    This reverts commit e8600bb8b702df6a2538e410ff77d56d06e6a9d2.

    Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64



    Bug: 441349768
    Original change's description:
    > [Glic] Make side panel and action react to eligibility changes.
    >
    > Eligibility state can change after side panel entry and browser actions are added.
    >
    > When profile becomes eligible: side panel entry is registered and browser action becomes visible
    > When profile becomes ineligible:  browser action is hidden, side panel is closed and un registered, observer removed
    >
    >
    > Bug: 441349768
    > Change-Id: I168f66bd5b8cd2bf398a6c7bd10e1753b67ceb6d
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6898320
    > Commit-Queue: Basia Zimirska <bas...@google.com>
    > Reviewed-by: Ian Wells <iwe...@chromium.org>
    > Reviewed-by: Trevor Perrier <per...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1510981}
    Bug: 441349768
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: I7ef6ad632e7b7af3578df823615226aa737d35c8
    Owners-Override: Minoru Chikamune <chik...@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Auto-Submit: Minoru Chikamune <chik...@chromium.org>
    Reviewed-by: Kentaro Hara <har...@chromium.org>
    Commit-Queue: Minoru Chikamune <chik...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1511245}
    Files:
    • M chrome/browser/BUILD.gn
    • M chrome/browser/ui/browser_actions.cc
    • M chrome/browser/ui/browser_window/internal/browser_window_features.cc
    • M chrome/browser/ui/views/side_panel/glic/glic_side_panel_coordinator.cc
    • M chrome/browser/ui/views/side_panel/glic/glic_side_panel_coordinator.h
    • D chrome/browser/ui/views/side_panel/glic/glic_side_panel_coordinator_browsertest.cc
    • M chrome/browser/ui/views/toolbar/toolbar_controller.cc
    • M chrome/test/BUILD.gn
    • M tools/metrics/actions/actions.xml
    Change size: M
    Delta: 9 files changed, 21 insertions(+), 211 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kentaro Hara, Bot-Commit+1 by Rubber Stamper
     Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: merged 
    

     Gerrit-Project: chromium/src 
    

     Gerrit-Branch: main 
    

     Gerrit-Change-Id: I7ef6ad632e7b7af3578df823615226aa737d35c8 
    

     Gerrit-Change-Number: 6917228 
    

     Gerrit-PatchSet: 3 
    open
    diffy
    satisfied_requirement
    Basia Zimirska (Gerrit)
    unread,
    Sep 4, 2025, 9:25:54 PM (2 days ago) Sep 4
    to Chromium LUCI CQ, Minoru Chikamune, Kentaro Hara, Rubber Stamper, Eshwar Stalin, Ian Wells, Trevor Perrier, Chromium Metrics Reviews, chromium...@chromium.org, AyeAye, asvitkine...@chromium.org
    Basia Zimirska has created a revert of this change
    Related details
    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: revert 
    satisfied_requirement
    open
    diffy
    Basia Zimirska (Gerrit)
    unread,
    Sep 5, 2025, 11:31:45 AM (2 days ago) Sep 5
    to Chromium LUCI CQ, Minoru Chikamune, Kentaro Hara, Rubber Stamper, Eshwar Stalin, Ian Wells, Trevor Perrier, Chromium Metrics Reviews, chromium...@chromium.org, AyeAye, asvitkine...@chromium.org
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages