ash: Cancel in-flight clipboard image requests on lockdown [chromium/src : main]

[Achuith Bhandarkar (Gerrit)]

Attention needed from Andrew Xu

Achuith Bhandarkar added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Achuith Bhandarkar . resolved

PTAL Andrew

Open in Gerrit

Related details

Attention is currently required from:

• Andrew Xu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6a982aa312feb7a57413c5668eaf2f1420e3885e

Gerrit-Change-Number: 7846962

Gerrit-PatchSet: 2

Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Andrew Xu <andr...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andrew Xu <andr...@google.com>

Gerrit-Comment-Date: Thu, 14 May 2026 00:32:50 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Alex Newcomer (Gerrit)]

Attention needed from Achuith Bhandarkar and Andrew Xu

Alex Newcomer added 1 comment

File chromeos/ash/experiences/clipboard/clipboard_image_model_factory_impl.cc

Line 49, Patchset 2 (Latest): pending_list_.clear();

Alex Newcomer . unresolved

we probably also want to set active_until_empty_ to false. Even better would be to reset this whole object, to completely wipe all state added in the future.

Open in Gerrit

Related details

Attention is currently required from:

• Achuith Bhandarkar
• Andrew Xu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6a982aa312feb7a57413c5668eaf2f1420e3885e

Gerrit-Change-Number: 7846962

Gerrit-PatchSet: 2

Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Andrew Xu <andr...@google.com>

Gerrit-CC: Alex Newcomer <newc...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Attention: Andrew Xu <andr...@google.com>

Gerrit-Comment-Date: Thu, 14 May 2026 00:42:10 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Achuith Bhandarkar (Gerrit)]

Attention needed from Alex Newcomer and Andrew Xu

Achuith Bhandarkar voted and added 2 comments

Votes added by Achuith Bhandarkar

Commit-Queue

+1

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Achuith Bhandarkar . resolved

PTAL Alex

File chromeos/ash/experiences/clipboard/clipboard_image_model_factory_impl.cc

Line 49, Patchset 2: pending_list_.clear();

Alex Newcomer . resolved

we probably also want to set active_until_empty_ to false. Even better would be to reset this whole object, to completely wipe all state added in the future.

Achuith Bhandarkar

Done

Open in Gerrit

Related details

Attention is currently required from:

• Alex Newcomer
• Andrew Xu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6a982aa312feb7a57413c5668eaf2f1420e3885e

Gerrit-Change-Number: 7846962

Gerrit-PatchSet: 4

Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Alex Newcomer <newc...@chromium.org>

Gerrit-Reviewer: Andrew Xu <andr...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andrew Xu <andr...@google.com>

Gerrit-Attention: Alex Newcomer <newc...@chromium.org>

Gerrit-Comment-Date: Thu, 14 May 2026 01:55:14 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Alex Newcomer <newc...@chromium.org>

[Alex Newcomer (Gerrit)]

Attention needed from Achuith Bhandarkar and Andrew Xu

Alex Newcomer voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Achuith Bhandarkar
• Andrew Xu

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6a982aa312feb7a57413c5668eaf2f1420e3885e

Gerrit-Change-Number: 7846962

Gerrit-PatchSet: 4

Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Alex Newcomer <newc...@chromium.org>

Gerrit-Reviewer: Andrew Xu <andr...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Attention: Andrew Xu <andr...@google.com>

Gerrit-Comment-Date: Thu, 14 May 2026 03:08:04 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Achuith Bhandarkar (Gerrit)]

Attention needed from Andrew Xu and Mitsuru Oshima

Achuith Bhandarkar added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Achuith Bhandarkar . resolved

Ty Alex! Oshima-san, need owner stamp.

Open in Gerrit

Related details

Attention is currently required from:

• Andrew Xu
• Mitsuru Oshima

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6a982aa312feb7a57413c5668eaf2f1420e3885e

Gerrit-Change-Number: 7846962

Gerrit-PatchSet: 4

Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Alex Newcomer <newc...@chromium.org>

Gerrit-Reviewer: Andrew Xu <andr...@google.com>

Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andrew Xu <andr...@google.com>

Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>

Gerrit-Comment-Date: Thu, 14 May 2026 04:51:01 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Mitsuru Oshima (Gerrit)]

Attention needed from Achuith Bhandarkar and Andrew Xu

Mitsuru Oshima added 2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Mitsuru Oshima . resolved

can you add a unit test?

File chrome/browser/ui/ash/shell_delegate/chrome_shell_delegate.cc

Line 358, Patchset 4 (Latest): if (auto* factory = ash::ClipboardImageModelFactory::Get()) {

Mitsuru Oshima . unresolved

when can this be null?

Open in Gerrit

Related details

Attention is currently required from:

• Achuith Bhandarkar
• Andrew Xu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6a982aa312feb7a57413c5668eaf2f1420e3885e

Gerrit-Change-Number: 7846962

Gerrit-PatchSet: 4

Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Alex Newcomer <newc...@chromium.org>

Gerrit-Reviewer: Andrew Xu <andr...@google.com>

Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Attention: Andrew Xu <andr...@google.com>

Gerrit-Comment-Date: Thu, 14 May 2026 05:25:04 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Achuith Bhandarkar (Gerrit)]

Attention needed from Andrew Xu and Mitsuru Oshima

Achuith Bhandarkar added 3 comments

Patchset-level comments

File-level comment, Patchset 4:

Mitsuru Oshima . resolved

can you add a unit test?

Achuith Bhandarkar

Unfortunately there are no existing unit tests in the ash clipboard directory
https://source.chromium.org/chromium/chromium/src/+/main:chromeos/ash/experiences/clipboard/

If we had an existing test that verifies that various services are turned off in locked mode, I could add this, but I don't really want to create a new test suite to fix this security issue.

I can add a trivial test to shell delegate using the mock to ensure CancellAllRequests is called, but it seems pointless.

File-level comment, Patchset 5 (Latest):

Achuith Bhandarkar . resolved

PTAL Oshima-san

File chrome/browser/ui/ash/shell_delegate/chrome_shell_delegate.cc

Line 358, Patchset 4: if (auto* factory = ash::ClipboardImageModelFactory::Get()) {

Mitsuru Oshima . resolved

when can this be null?

Achuith Bhandarkar

Done

Open in Gerrit

Related details

Attention is currently required from:

• Andrew Xu
• Mitsuru Oshima

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6a982aa312feb7a57413c5668eaf2f1420e3885e

Gerrit-Change-Number: 7846962

Gerrit-PatchSet: 5

Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Alex Newcomer <newc...@chromium.org>

Gerrit-Reviewer: Andrew Xu <andr...@google.com>

Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andrew Xu <andr...@google.com>

Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>

Gerrit-Comment-Date: Fri, 15 May 2026 18:58:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Mitsuru Oshima <osh...@chromium.org>

[Mitsuru Oshima (Gerrit)]

Attention needed from Achuith Bhandarkar and Andrew Xu

Mitsuru Oshima added 2 comments

Patchset-level comments

File-level comment, Patchset 4:

Mitsuru Oshima . resolved

can you add a unit test?

Achuith Bhandarkar

Unfortunately there are no existing unit tests in the ash clipboard directory
https://source.chromium.org/chromium/chromium/src/+/main:chromeos/ash/experiences/clipboard/

If we had an existing test that verifies that various services are turned off in locked mode, I could add this, but I don't really want to create a new test suite to fix this security issue.

I can add a trivial test to shell delegate using the mock to ensure CancellAllRequests is called, but it seems pointless.

Mitsuru Oshima

You can ask gemini/jetski to create a test. They're pretty good at it nowadays.
you can point ontask tests,but it can also ask it to find an example and use the same pattern to enter ontask.

File chrome/browser/ui/ash/shell_delegate/chrome_shell_delegate.cc

Line 356, Patchset 5 (Latest): const bool locked = window_state.IsPinned();

Mitsuru Oshima . unresolved

Can you add me to the bug? This may be what you need here:

https://chromium-review.git.corp.google.com/c/chromium/src/+/7846962/5/chrome/browser/ui/ash/shell_delegate/chrome_shell_delegate.cc#363

Open in Gerrit

Related details

Attention is currently required from:

• Achuith Bhandarkar
• Andrew Xu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6a982aa312feb7a57413c5668eaf2f1420e3885e

Gerrit-Change-Number: 7846962

Gerrit-PatchSet: 5

Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Alex Newcomer <newc...@chromium.org>

Gerrit-Reviewer: Andrew Xu <andr...@google.com>

Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Attention: Andrew Xu <andr...@google.com>

Gerrit-Comment-Date: Sat, 16 May 2026 10:08:12 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Achuith Bhandarkar <ach...@chromium.org>

Comment-In-Reply-To: Mitsuru Oshima <osh...@chromium.org>

[Achuith Bhandarkar (Gerrit)]

Attention needed from Alex Newcomer, Andrew Xu and Mitsuru Oshima

Achuith Bhandarkar added 3 comments

Patchset-level comments

File-level comment, Patchset 4:

Mitsuru Oshima . resolved

can you add a unit test?

Achuith Bhandarkar

Unfortunately there are no existing unit tests in the ash clipboard directory
https://source.chromium.org/chromium/chromium/src/+/main:chromeos/ash/experiences/clipboard/

If we had an existing test that verifies that various services are turned off in locked mode, I could add this, but I don't really want to create a new test suite to fix this security issue.

I can add a trivial test to shell delegate using the mock to ensure CancellAllRequests is called, but it seems pointless.

Mitsuru Oshima

You can ask gemini/jetski to create a test. They're pretty good at it nowadays.
you can point ontask tests,but it can also ask it to find an example and use the same pattern to enter ontask.

Achuith Bhandarkar

ok, I got jetski to create the test. PTAL

File-level comment, Patchset 6 (Latest):

Achuith Bhandarkar . resolved

I've verified that the test fails without the new CancellAllRequests command. PTAL

File chrome/browser/ui/ash/shell_delegate/chrome_shell_delegate.cc

Line 356, Patchset 5: const bool locked = window_state.IsPinned();

Mitsuru Oshima . resolved

Can you add me to the bug? This may be what you need here:

https://chromium-review.git.corp.google.com/c/chromium/src/+/7846962/5/chrome/browser/ui/ash/shell_delegate/chrome_shell_delegate.cc#363

Achuith Bhandarkar

Added

Open in Gerrit

Related details

Attention is currently required from:

• Alex Newcomer
• Andrew Xu
• Mitsuru Oshima

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6a982aa312feb7a57413c5668eaf2f1420e3885e

Gerrit-Change-Number: 7846962

Gerrit-PatchSet: 6

Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Alex Newcomer <newc...@chromium.org>

Gerrit-Reviewer: Andrew Xu <andr...@google.com>

Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andrew Xu <andr...@google.com>

Gerrit-Attention: Alex Newcomer <newc...@chromium.org>

Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>

Gerrit-Comment-Date: Wed, 27 May 2026 21:20:38 +0000

[Mitsuru Oshima (Gerrit)]

Attention needed from Achuith Bhandarkar, Alex Newcomer and Andrew Xu

Mitsuru Oshima voted and added 4 comments

Votes added by Mitsuru Oshima

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Mitsuru Oshima . resolved

Please look into if we can improve the test.

File chrome/browser/ui/ash/shell_delegate/chrome_shell_delegate_browsertest.cc

Line 28, Patchset 6 (Latest):class ChromeShellDelegateBrowserTest : public InProcessBrowserTest {

Mitsuru Oshima . unresolved

nit 😊
using ChromeShellDelegateBrowserTest = InProcessBrowserTest;

Line 76, Patchset 6 (Latest): *window_state);

Mitsuru Oshima . unresolved

Do you need this? I think this should be called here

https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/views/frame/browser_native_widget_ash.cc;drc=09a7b3714dcfba634c933e2f7811a4f202425cdf;l=64

Line 82, Patchset 6 (Latest): run_loop.Run();

Mitsuru Oshima . unresolved

Do you know what tasks are necessary? It'd be better too use base::test::RunUntil instead.

Open in Gerrit

Related details

Attention is currently required from:

• Achuith Bhandarkar
• Alex Newcomer
• Andrew Xu

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6a982aa312feb7a57413c5668eaf2f1420e3885e

Gerrit-Change-Number: 7846962

Gerrit-PatchSet: 6

Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Alex Newcomer <newc...@chromium.org>

Gerrit-Reviewer: Andrew Xu <andr...@google.com>

Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Attention: Andrew Xu <andr...@google.com>

Gerrit-Attention: Alex Newcomer <newc...@chromium.org>

Gerrit-Comment-Date: Thu, 28 May 2026 02:16:52 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Achuith Bhandarkar (Gerrit)]

Attention needed from Alex Newcomer, Andrew Xu and Hidehiko Abe

Achuith Bhandarkar added 4 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Achuith Bhandarkar . resolved

hidehiko-san - need owner approval for DEPS change

File chrome/browser/ui/ash/shell_delegate/chrome_shell_delegate_browsertest.cc

Line 28, Patchset 6:class ChromeShellDelegateBrowserTest : public InProcessBrowserTest {

Mitsuru Oshima . resolved

nit 😊
using ChromeShellDelegateBrowserTest = InProcessBrowserTest;

Achuith Bhandarkar

Nice trick! Done

Line 76, Patchset 6: *window_state);

Mitsuru Oshima . resolved

Do you need this? I think this should be called here

https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/views/frame/browser_native_widget_ash.cc;drc=09a7b3714dcfba634c933e2f7811a4f202425cdf;l=64

Achuith Bhandarkar

Removed

Line 82, Patchset 6: run_loop.Run();

Mitsuru Oshima . resolved

Do you know what tasks are necessary? It'd be better too use base::test::RunUntil instead.

Achuith Bhandarkar

It's actually a negative test because we've cancelled all tasks. We're just waiting for this timeout:
https://source.chromium.org/chromium/chromium/src/+/main:chromeos/ash/experiences/clipboard/clipboard_image_model_request.cc;l=325

Open in Gerrit

Related details

Attention is currently required from:

• Alex Newcomer
• Andrew Xu
• Hidehiko Abe

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6a982aa312feb7a57413c5668eaf2f1420e3885e

Gerrit-Change-Number: 7846962

Gerrit-PatchSet: 7

Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Alex Newcomer <newc...@chromium.org>

Gerrit-Reviewer: Andrew Xu <andr...@google.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andrew Xu <andr...@google.com>

Gerrit-Attention: Alex Newcomer <newc...@chromium.org>

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Sat, 30 May 2026 20:16:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Mitsuru Oshima <osh...@chromium.org>

[Hidehiko Abe (Gerrit)]

Attention needed from Achuith Bhandarkar, Alex Newcomer and Andrew Xu

Hidehiko Abe voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Achuith Bhandarkar
• Alex Newcomer
• Andrew Xu

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I6a982aa312feb7a57413c5668eaf2f1420e3885e

Gerrit-Change-Number: 7846962

Gerrit-PatchSet: 7

Gerrit-Owner: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Reviewer: Alex Newcomer <newc...@chromium.org>

Gerrit-Reviewer: Andrew Xu <andr...@google.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Achuith Bhandarkar <ach...@chromium.org>

Gerrit-Attention: Andrew Xu <andr...@google.com>

Gerrit-Attention: Alex Newcomer <newc...@chromium.org>

Gerrit-Comment-Date: Mon, 01 Jun 2026 02:35:54 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes