[iOS] Remove gCrWebLegacy.getUniqueID function [chromium/src : main]

0 views
Skip to first unread message

Alexandra Pereira (Gerrit)

unread,
Nov 4, 2025, 3:00:23 PM (3 days ago) Nov 4
to Daniel White, Sebastien S-G, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Daniel White and Sebastien S-G

Alexandra Pereira voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel White
  • Sebastien S-G
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c51efe2f606de3bf3929748dd7c10d77d440891
Gerrit-Change-Number: 7120159
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel White <daniel...@google.com>
Gerrit-Reviewer: Alexandra Pereira <alexa...@google.com>
Gerrit-Reviewer: Daniel White <daniel...@google.com>
Gerrit-Reviewer: Sebastien S-G <se...@chromium.org>
Gerrit-Attention: Daniel White <daniel...@google.com>
Gerrit-Attention: Sebastien S-G <se...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 20:00:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sebastien S-G (Gerrit)

unread,
Nov 5, 2025, 10:00:35 AM (2 days ago) Nov 5
to Daniel White, Alexandra Pereira, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Daniel White

Sebastien S-G voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel White
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c51efe2f606de3bf3929748dd7c10d77d440891
Gerrit-Change-Number: 7120159
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel White <daniel...@google.com>
Gerrit-Reviewer: Alexandra Pereira <alexa...@google.com>
Gerrit-Reviewer: Daniel White <daniel...@google.com>
Gerrit-Reviewer: Sebastien S-G <se...@chromium.org>
Gerrit-Attention: Daniel White <daniel...@google.com>
Gerrit-Comment-Date: Wed, 05 Nov 2025 15:00:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel White (Gerrit)

unread,
Nov 5, 2025, 11:28:55 AM (2 days ago) Nov 5
to Sebastien S-G, Alexandra Pereira, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org

Daniel White voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c51efe2f606de3bf3929748dd7c10d77d440891
Gerrit-Change-Number: 7120159
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel White <daniel...@google.com>
Gerrit-Reviewer: Alexandra Pereira <alexa...@google.com>
Gerrit-Reviewer: Daniel White <daniel...@google.com>
Gerrit-Reviewer: Sebastien S-G <se...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Nov 2025 16:28:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 5, 2025, 11:33:18 AM (2 days ago) Nov 5
to Daniel White, Sebastien S-G, Alexandra Pereira, chromium...@chromium.org, browser-comp...@chromium.org, ios-r...@chromium.org, tmartino+tran...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[iOS] Remove gCrWebLegacy.getUniqueID function

In this CL, the gCrWebLegacy.fill.getUniqueID was removed from the
codebase. This function can be removed now because its replacement was
introduced in a previous CL and there are no references to the legacy
function remaining.
Bug: 448990422
Change-Id: I1c51efe2f606de3bf3929748dd7c10d77d440891
Reviewed-by: Alexandra Pereira <alexa...@google.com>
Commit-Queue: Daniel White <daniel...@google.com>
Reviewed-by: Sebastien S-G <se...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540665}
Files:
  • M components/autofill/ios/form_util/resources/fill_util.ts
Change size: S
Delta: 1 file changed, 0 insertions(+), 36 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Sebastien S-G, +1 by Alexandra Pereira
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c51efe2f606de3bf3929748dd7c10d77d440891
Gerrit-Change-Number: 7120159
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel White <daniel...@google.com>
Gerrit-Reviewer: Alexandra Pereira <alexa...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel White <daniel...@google.com>
Gerrit-Reviewer: Sebastien S-G <se...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages