Fixes for TLS13EarlyDataEnabled policy [chromium/src : main]

[Adam Rice (Gerrit)]

Attention needed from Nidhi Jaju

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Nidhi Jaju

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Icb74a167d7348806530bf8241695818041fedd39

Gerrit-Change-Number: 7274977

Gerrit-PatchSet: 2

Gerrit-Owner: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Comment-Date: Thu, 18 Dec 2025 19:26:03 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Nidhi Jaju (Gerrit)]

Attention needed from Adam Rice

Nidhi Jaju voted and added 2 comments

Votes added by Nidhi Jaju

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Nidhi Jaju . resolved

Looks good, thank you Adam!

File chrome/browser/policy/policy_network_browsertest.cc

Line 1066, Patchset 2 (Latest): DisableWithRestart) {

Nidhi Jaju . unresolved

Should we also test the inverse, where we check if we set the policy to true, and restart the network service, that early data is accepted?

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Icb74a167d7348806530bf8241695818041fedd39

Gerrit-Change-Number: 7274977

Gerrit-PatchSet: 2

Gerrit-Owner: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Fri, 19 Dec 2025 05:08:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Adam Rice (Gerrit)]

Attention needed from Nidhi Jaju

Adam Rice added 1 comment

File chrome/browser/policy/policy_network_browsertest.cc

Line 1066, Patchset 2: DisableWithRestart) {

Nidhi Jaju . resolved

Should we also test the inverse, where we check if we set the policy to true, and restart the network service, that early data is accepted?

Adam Rice

Done

Open in Gerrit

Related details

Attention is currently required from:

• Nidhi Jaju

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Icb74a167d7348806530bf8241695818041fedd39

Gerrit-Change-Number: 7274977

Gerrit-PatchSet: 5

Gerrit-Owner: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Comment-Date: Mon, 05 Jan 2026 08:12:52 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Nidhi Jaju <nidh...@chromium.org>

[Nidhi Jaju (Gerrit)]

Attention needed from Adam Rice

Nidhi Jaju voted and added 1 comment

Votes added by Nidhi Jaju

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Nidhi Jaju . resolved

Thank you!

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Icb74a167d7348806530bf8241695818041fedd39

Gerrit-Change-Number: 7274977

Gerrit-PatchSet: 5

Gerrit-Owner: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 05 Jan 2026 08:22:20 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Adam Rice (Gerrit)]

Adam Rice added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Adam Rice . unresolved

I'm going to try to reproduce the test flakiness on Windows this evening. If you're in a hurry to land this, I could disable the tests on Windows instead.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Icb74a167d7348806530bf8241695818041fedd39

Gerrit-Change-Number: 7274977

Gerrit-PatchSet: 6

Gerrit-Owner: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Thu, 08 Jan 2026 02:04:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Nidhi Jaju (Gerrit)]

Attention needed from Adam Rice

Nidhi Jaju voted and added 1 comment

Votes added by Nidhi Jaju

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Adam Rice . unresolved

I'm going to try to reproduce the test flakiness on Windows this evening. If you're in a hurry to land this, I could disable the tests on Windows instead.

Nidhi Jaju

M145 branched on Monday already, but if we could land this and merge it back to M145, that would allow us to experiment sooner too.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Icb74a167d7348806530bf8241695818041fedd39

Gerrit-Change-Number: 7274977

Gerrit-PatchSet: 6

Gerrit-Owner: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Wed, 14 Jan 2026 01:42:17 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Adam Rice <ri...@chromium.org>