Implement print dialog via XDG portal [chromium/src : main]

0 views
Skip to first unread message

Thomas Anderson (Gerrit)

unread,
Dec 5, 2025, 1:53:14 PM (13 hours ago) Dec 5
to Lei Zhang, AyeAye, chromium...@chromium.org, hashimo...@chromium.org, cros-print...@google.com, print-rev...@chromium.org
Attention needed from Lei Zhang

Thomas Anderson voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic5d07f39d9ad5aa4e1acd3d7438e15078146b202
Gerrit-Change-Number: 7219322
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Dec 2025 18:53:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Dec 5, 2025, 4:46:07 PM (10 hours ago) Dec 5
to Thomas Anderson, Chromium LUCI CQ, Lei Zhang, AyeAye, chromium...@chromium.org, hashimo...@chromium.org, cros-print...@google.com, print-rev...@chromium.org
Attention needed from Thomas Anderson

Lei Zhang added 2 comments

Commit Message
Line 15, Patchset 7 (Latest):Bug: None
Lei Zhang . resolved

No bug for the feature?

File printing/DEPS
Line 3, Patchset 7 (Latest): "+components/dbus",
Lei Zhang . unresolved

Would it possible to move the implementation to //components/printing to avoid this, and then provide //printing with a factory function to call to create the dialog?

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Anderson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic5d07f39d9ad5aa4e1acd3d7438e15078146b202
    Gerrit-Change-Number: 7219322
    Gerrit-PatchSet: 7
    Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Dec 2025 21:45:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Lei Zhang (Gerrit)

    unread,
    Dec 5, 2025, 10:50:28 PM (4 hours ago) Dec 5
    to Thomas Anderson, Chromium LUCI CQ, Lei Zhang, AyeAye, chromium...@chromium.org, hashimo...@chromium.org, cros-print...@google.com, print-rev...@chromium.org
    Attention needed from Thomas Anderson

    Lei Zhang added 1 comment

    File printing/DEPS
    Line 3, Patchset 7 (Latest): "+components/dbus",
    Lei Zhang . unresolved

    Would it possible to move the implementation to //components/printing to avoid this, and then provide //printing with a factory function to call to create the dialog?

    Lei Zhang

    Trying to avoid having //printing depending upwards into //components.

    Gerrit-Comment-Date: Sat, 06 Dec 2025 03:50:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages