Use SHA256 hash to generate notification tags [chromium/src : main]
0 views
Skip to first unread message
Joe Mason (Gerrit)
12:10 AM (8 hours ago) 12:10 AM
to Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, dibyapal+wa...@chromium.org
Joe Mason voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
1:29 AM (7 hours ago) 1:29 AM
to Peter Beverloo, Chromium LUCI CQ, chromium...@chromium.org, dibyapal+wa...@chromium.org
Attention needed from Peter Beverloo
Joe Mason added 1 comment![]( "Open in Gerrit")
File chrome/browser/notifications/notification_platform_bridge_win.cc
Line 923, Patchset 1 (Latest):
return base::ASCIIToWide(base::HexEncode(crypto::hash::Sha256(payload)));Joe Mason . unresolved
Turns out this fails because it's 64 chars long. The toast API has a max lenght of 64 chars *including the null terminator*.
Related details
Attention is currently required from:
- Peter Beverloo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
1:48 AM (7 hours ago) 1:48 AM
to Peter Beverloo, Chromium LUCI CQ, chromium...@chromium.org, dibyapal+wa...@chromium.org
Attention needed from Peter Beverloo
Joe Mason voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Mason
| Auto-Submit | +1 |
1 comment
File chrome/browser/notifications/notification_platform_bridge_win.cc
Line 923, Patchset 1:
return base::ASCIIToWide(base::HexEncode(crypto::hash::Sha256(payload)));Joe Mason . resolved
Turns out this fails because it's 64 chars long. The toast API has a max lenght of 64 chars *including the null terminator*.
Joe Mason
Fixed.
Related details
Attention is currently required from:
- Peter Beverloo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Beverloo (Gerrit)
5:24 AM (3 hours ago) 5:24 AM
to Peter Beverloo, Chromium LUCI CQ, chromium...@chromium.org, dibyapal+wa...@chromium.org
Attention needed from Joe Mason
Peter Beverloo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Peter Beverloo
| Code-Review | +1 |
1 comment
File chrome/browser/notifications/notification_platform_bridge_win_unittest.cc
Line 267, Patchset 3 (Latest):
ASSERT_NE(tagA.Get(), tagB.Get());Peter Beverloo . unresolved
The origins are included in the `notification_id` parameter by the `NotificationIdGenerator`, which this test suite bypasses by using a fixed `kNotificationId`, causing this assertion to fail. I think that's ok - best to remove this test?
Related details
Attention is currently required from:
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages