Fix arrow keys in find-box in PWAs on macOS [chromium/src : main]
1 view
Skip to first unread message
Marijn Kruisselbrink (Gerrit)
Jul 19, 2024, 5:24:18 PM7/19/24
to ccameron chromium, Leon Han, q lamry, chromium...@chromium.org, Chromium LUCI CQ, blundell+...@chromium.org, mac-r...@chromium.org
Attention needed from Leon Han, ccameron chromium and q lamry
Marijn Kruisselbrink added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Marijn Kruisselbrink . resolved
An alternative possible approach to the CL in https://chromium-review.googlesource.com/c/chromium/src/+/5691280...
Related details
Attention is currently required from:
- Leon Han
- ccameron chromium
- q lamry
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
q lamry (Gerrit)
Jul 21, 2024, 1:22:50 AM7/21/24
to Marijn Kruisselbrink, ccameron chromium, Leon Han, chromium...@chromium.org, Chromium LUCI CQ, blundell+...@chromium.org, mac-r...@chromium.org
Attention needed from Leon Han, Marijn Kruisselbrink and ccameron chromium
q lamry added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Leon Han
- Marijn Kruisselbrink
- ccameron chromium
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ccameron chromium (Gerrit)
Jul 22, 2024, 11:40:08 AM7/22/24
to Marijn Kruisselbrink, ccameron chromium, Leon Han, q lamry, chromium...@chromium.org, Chromium LUCI CQ, blundell+...@chromium.org, mac-r...@chromium.org
Attention needed from Leon Han and Marijn Kruisselbrink
ccameron chromium voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Leon Han
- Marijn Kruisselbrink
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marijn Kruisselbrink (Gerrit)
Jul 22, 2024, 4:49:04 PM7/22/24
to Dave Tapuska, Elly FJ, ccameron chromium, Leon Han, q lamry, chromium...@chromium.org, Chromium LUCI CQ, blundell+...@chromium.org, mac-r...@chromium.org
Attention needed from Dave Tapuska, Elly FJ and Leon Han
Marijn Kruisselbrink added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Marijn Kruisselbrink . resolved
+ellyjones for browser_frame_mac OWNERS
+dtapuska for components/input OWNERS
Related details
Attention is currently required from:
- Dave Tapuska
- Elly FJ
- Leon Han
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Jul 22, 2024, 5:15:28 PM7/22/24
to Marijn Kruisselbrink, Elly FJ, ccameron chromium, Leon Han, q lamry, chromium...@chromium.org, Chromium LUCI CQ, blundell+...@chromium.org, mac-r...@chromium.org
Attention needed from Elly FJ, Leon Han and Marijn Kruisselbrink
Dave Tapuska voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Elly FJ
- Leon Han
- Marijn Kruisselbrink
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elly FJ (Gerrit)
Jul 23, 2024, 10:57:32 AM7/23/24
to Marijn Kruisselbrink, Elly FJ, Dave Tapuska, ccameron chromium, Leon Han, q lamry, chromium...@chromium.org, Chromium LUCI CQ, blundell+...@chromium.org, mac-r...@chromium.org
Attention needed from Leon Han and Marijn Kruisselbrink
Elly FJ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Elly FJ
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Leon Han
- Marijn Kruisselbrink
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marijn Kruisselbrink (Gerrit)
Jul 23, 2024, 1:09:11 PM7/23/24
to Elly FJ, Dave Tapuska, ccameron chromium, Leon Han, q lamry, chromium...@chromium.org, Chromium LUCI CQ, blundell+...@chromium.org, mac-r...@chromium.org
Attention needed from Leon Han
Marijn Kruisselbrink voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Leon Han
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 23, 2024, 1:44:30 PM7/23/24
to Marijn Kruisselbrink, Elly FJ, Dave Tapuska, ccameron chromium, Leon Han, q lamry, chromium...@chromium.org, blundell+...@chromium.org, mac-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix arrow keys in find-box in PWAs on macOS
Bug: 40817318
Change-Id: If7c6b4b3b182acd2d95449242356abf78ad9aa00
Commit-Queue: Marijn Kruisselbrink <m...@chromium.org>
Reviewed-by: ccameron chromium <ccam...@chromium.org>
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Reviewed-by: Elly FJ <elly...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1331846}
Files:
- M chrome/browser/ui/views/frame/browser_frame_mac.mm
- M components/input/native_web_keyboard_event_mac.mm
Change size: S
Delta: 2 files changed, 7 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Elly FJ, +1 by ccameron chromium, +1 by Dave Tapuska
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages