[Memory] Introduce feature engagement constants for At-Memory Promo [chromium/src : main]

0 views
Skip to first unread message

Maryia Mankevich (Gerrit)

unread,
Apr 9, 2026, 12:36:16 PM (4 days ago) Apr 9
to chromium...@chromium.org, dfried...@chromium.org, estali...@chromium.org

Maryia Mankevich added 1 comment

Patchset-level comments
File-level comment, Patchset 2:
Maryia Mankevich . resolved

The final logic for limiting how often the bubble is shown is still being discussed. For now, I've used very permissive rules (like ignoring session rates) to allow the bubble to show in most cases for easy testing.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icb6dcee4f690a916be21b2bbc59d502ae8b88ff1
Gerrit-Change-Number: 7743030
Gerrit-PatchSet: 2
Gerrit-Owner: Maryia Mankevich <mma...@google.com>
Gerrit-Comment-Date: Thu, 09 Apr 2026 16:36:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dana Fried (Gerrit)

unread,
Apr 10, 2026, 9:14:43 AM (3 days ago) Apr 10
to Maryia Mankevich, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, penghuan...@chromium.org, jz...@chromium.org, net-r...@chromium.org, fgal...@chromium.org, feature-me...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, dfried...@chromium.org, estali...@chromium.org
Attention needed from Maryia Mankevich

Dana Fried added 1 comment

Patchset-level comments
File-level comment, Patchset 16 (Latest):
Dana Fried . unresolved

You are missing actions and enums entries; look for other cases where UE features were added for examples.

Open in Gerrit

Related details

Attention is currently required from:
  • Maryia Mankevich
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icb6dcee4f690a916be21b2bbc59d502ae8b88ff1
    Gerrit-Change-Number: 7743030
    Gerrit-PatchSet: 16
    Gerrit-Owner: Maryia Mankevich <mma...@google.com>
    Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
    Gerrit-CC: Jerome Jiang <ji...@chromium.org>
    Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-Attention: Maryia Mankevich <mma...@google.com>
    Gerrit-Comment-Date: Fri, 10 Apr 2026 13:14:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dana Fried (Gerrit)

    unread,
    Apr 10, 2026, 9:16:29 AM (3 days ago) Apr 10
    to Maryia Mankevich, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, penghuan...@chromium.org, jz...@chromium.org, net-r...@chromium.org, fgal...@chromium.org, feature-me...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, dfried...@chromium.org, estali...@chromium.org
    Attention needed from Maryia Mankevich

    Dana Fried added 1 comment

    File components/feature_engagement/public/feature_configurations.cc
    Line 1966, Patchset 16 (Latest): if (kIPHAutofillAtMemoryFeature.name == feature->name) {
    Dana Fried . unresolved

    We do not write configurations for desktop features - desktop features are auto-configured by the IPH system. If this is a feature that is also shipping on Android, please put this configuration in a `#if BUILDFLAG(IS_ANDROID)` block.

    Gerrit-Comment-Date: Fri, 10 Apr 2026 13:16:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Maryia Mankevich (Gerrit)

    unread,
    Apr 10, 2026, 2:27:50 PM (3 days ago) Apr 10
    to Chromium Metrics Reviews, Dana Fried, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, asvitkine...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, penghuan...@chromium.org, jz...@chromium.org, net-r...@chromium.org, fgal...@chromium.org, feature-me...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, dfried...@chromium.org, estali...@chromium.org
    Attention needed from Dana Fried

    Maryia Mankevich added 3 comments

    Patchset-level comments
    Dana Fried . unresolved

    You are missing actions and enums entries; look for other cases where UE features were added for examples.

    Maryia Mankevich

    Added. PTAL.

    File-level comment, Patchset 19 (Latest):
    Maryia Mankevich . resolved

    Thanks! Updated. PTAL

    File components/feature_engagement/public/feature_configurations.cc
    Line 1966, Patchset 16: if (kIPHAutofillAtMemoryFeature.name == feature->name) {
    Dana Fried . resolved

    We do not write configurations for desktop features - desktop features are auto-configured by the IPH system. If this is a feature that is also shipping on Android, please put this configuration in a `#if BUILDFLAG(IS_ANDROID)` block.

    Maryia Mankevich

    Thanks for pointing it out! This promo is currently Desktop-only, so I've removed the configuration.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dana Fried
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icb6dcee4f690a916be21b2bbc59d502ae8b88ff1
    Gerrit-Change-Number: 7743030
    Gerrit-PatchSet: 19
    Gerrit-Owner: Maryia Mankevich <mma...@google.com>
    Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Dana Fried <dfr...@chromium.org>
    Gerrit-Comment-Date: Fri, 10 Apr 2026 18:27:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Dana Fried <dfr...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dana Fried (Gerrit)

    unread,
    Apr 10, 2026, 4:41:12 PM (3 days ago) Apr 10
    to Maryia Mankevich, Chromium Metrics Reviews, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, asvitkine...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, penghuan...@chromium.org, jz...@chromium.org, net-r...@chromium.org, fgal...@chromium.org, feature-me...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, dfried...@chromium.org, estali...@chromium.org
    Attention needed from Maryia Mankevich

    Dana Fried voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Maryia Mankevich
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icb6dcee4f690a916be21b2bbc59d502ae8b88ff1
    Gerrit-Change-Number: 7743030
    Gerrit-PatchSet: 20
    Gerrit-Owner: Maryia Mankevich <mma...@google.com>
    Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Jerome Jiang <ji...@chromium.org>
    Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-Attention: Maryia Mankevich <mma...@google.com>
    Gerrit-Comment-Date: Fri, 10 Apr 2026 20:41:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Maryia Mankevich (Gerrit)

    unread,
    5:30 AM (3 hours ago) 5:30 AM
    to Dana Fried, Chromium Metrics Reviews, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, asvitkine...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, penghuan...@chromium.org, jz...@chromium.org, net-r...@chromium.org, fgal...@chromium.org, feature-me...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, dfried...@chromium.org, estali...@chromium.org

    Maryia Mankevich added 1 comment

    Patchset-level comments

    You are missing actions and enums entries; look for other cases where UE features were added for examples.

    Maryia Mankevich

    Added. PTAL.

    Maryia Mankevich

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Icb6dcee4f690a916be21b2bbc59d502ae8b88ff1
      Gerrit-Change-Number: 7743030
      Gerrit-PatchSet: 20
      Gerrit-Owner: Maryia Mankevich <mma...@google.com>
      Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Jerome Jiang <ji...@chromium.org>
      Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-Comment-Date: Mon, 13 Apr 2026 09:29:53 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Maryia Mankevich <mma...@google.com>
      Comment-In-Reply-To: Dana Fried <dfr...@chromium.org>
      satisfied_requirement
      open
      diffy

      Maryia Mankevich (Gerrit)

      unread,
      5:30 AM (3 hours ago) 5:30 AM
      to Dana Fried, Chromium Metrics Reviews, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, asvitkine...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, penghuan...@chromium.org, jz...@chromium.org, net-r...@chromium.org, fgal...@chromium.org, feature-me...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, dfried...@chromium.org, estali...@chromium.org

      Maryia Mankevich voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Icb6dcee4f690a916be21b2bbc59d502ae8b88ff1
      Gerrit-Change-Number: 7743030
      Gerrit-PatchSet: 20
      Gerrit-Owner: Maryia Mankevich <mma...@google.com>
      Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
      Gerrit-Reviewer: Maryia Mankevich <mma...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Jerome Jiang <ji...@chromium.org>
      Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-Comment-Date: Mon, 13 Apr 2026 09:30:00 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      6:40 AM (2 hours ago) 6:40 AM
      to Maryia Mankevich, Dana Fried, Chromium Metrics Reviews, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, asvitkine...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, penghuan...@chromium.org, jz...@chromium.org, net-r...@chromium.org, fgal...@chromium.org, feature-me...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, dfried...@chromium.org, estali...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [Memory] Introduce feature engagement constants for At-Memory Promo

      This CL introduces the base feature flag and configuration for the
      At-Memory autofill promo in the feature engagement tracker.
      Bug: 494131189
      Change-Id: Icb6dcee4f690a916be21b2bbc59d502ae8b88ff1
      Reviewed-by: Dana Fried <dfr...@chromium.org>
      Commit-Queue: Maryia Mankevich <mma...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1613608}
      Files:
      • M components/feature_engagement/public/feature_constants.cc
      • M components/feature_engagement/public/feature_constants.h
      • M components/feature_engagement/public/feature_list.cc
      • M components/feature_engagement/public/feature_list.h
      • M tools/metrics/actions/actions.xml
      • M tools/metrics/histograms/metadata/feature_engagement/histograms.xml
      Change size: S
      Delta: 6 files changed, 13 insertions(+), 0 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Dana Fried
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Icb6dcee4f690a916be21b2bbc59d502ae8b88ff1
      Gerrit-Change-Number: 7743030
      Gerrit-PatchSet: 21
      Gerrit-Owner: Maryia Mankevich <mma...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages