Support viewport mapping in GeometryMapper fast path [chromium/src : main]
0 views
Skip to first unread message
Aaron Leventhal (Gerrit)
Dec 15, 2025, 2:03:03 PM (21 hours ago) Dec 15
to Khushal Sagar, Philip Rogers, Dirk Schulze, Stephen Chenney, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, aleventh...@chromium.org, fserb...@chromium.org, drott+bl...@chromium.org, blink-reviews-p...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, mfoltz+wa...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Philip Rogers
Aaron Leventhal added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 14:
Philip Rogers . resolved
Aaron LeventhalThis looks good overall!
Can you put this change behind an enabled-by-default flag (maybe `BlinkGeometryMapperViewportFastPath`) by adding a flag to `third_party/blink/renderer/platform/runtime_enabled_features.json5` and wrapping the behavior changes in `if (RuntimeEnabledFeatures:: BlinkGeometryMapperViewportFastPathEnabled) {`? This will make it easier to disable in production in the unlikely case that it ends up triggering a crash or an unexpected behavior change.
Done
Commit Message
Line 7, Patchset 14:
Support viewport mapping oin GeometryMapper fast pathPhilip Rogers . resolved
Aaron Leventhalnit oin -> on
Done
File third_party/blink/renderer/core/layout/layout_object.cc
Line 2380, Patchset 14:
PropertyTreeState unaliased_container(Philip Rogers . resolved
Aaron LeventhalCan this just do:
```
PropertyTreeState unaliased_container = container_properties.Unalias();
```
And remove UnaliasOrRoot?
Done
Related details
Attention is currently required from:
- Philip Rogers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aaron Leventhal (Gerrit)
Dec 15, 2025, 2:03:47 PM (21 hours ago) Dec 15
to Khushal Sagar, Philip Rogers, Dirk Schulze, Stephen Chenney, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, aleventh...@chromium.org, fserb...@chromium.org, drott+bl...@chromium.org, blink-reviews-p...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, mfoltz+wa...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Philip Rogers
Aaron Leventhal voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Philip Rogers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Rogers (Gerrit)
Dec 15, 2025, 2:23:20 PM (21 hours ago) Dec 15
to Aaron Leventhal, Khushal Sagar, Dirk Schulze, Stephen Chenney, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jmedle...@chromium.org, aleventh...@chromium.org, fserb...@chromium.org, drott+bl...@chromium.org, blink-reviews-p...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, mfoltz+wa...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Aaron Leventhal
Philip Rogers voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philip Rogers
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Aaron Leventhal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 15, 2025, 2:58:00 PM (20 hours ago) Dec 15
to Aaron Leventhal, Philip Rogers, Khushal Sagar, Dirk Schulze, Stephen Chenney, AyeAye, chromium...@chromium.org, jmedle...@chromium.org, aleventh...@chromium.org, fserb...@chromium.org, drott+bl...@chromium.org, blink-reviews-p...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, mfoltz+wa...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Support viewport mapping in GeometryMapper fast path
When mapping a rect to the viewport, a caller passes a null ancestor
to MapToVisualRectInAncestorSpace(), which has the unfortunate side
effect of avoiding the geometry mapper (the fast path), even when the
kUseGeometryMapper flag was passed.
However, the legacy slow path has slightly different math and
introduces discrepancies with things like nested filters, causing
DCHECK failures in APC because the visible bounding box does not fit
in the outer bounding box.
Use of the fast path is now enabled for
MapToVisualRectInAncestorSpace() with a null ancestor (iow for
viewport mapping). This improves all callers using a null
ancestor while addressing the failing geometry DCHECKs in APC.
Change-Id: I41ddf12b934607c120cc408230c2eac6eeb2e3ea
Reviewed-by: Philip Rogers <p...@chromium.org>
Commit-Queue: Philip Rogers <p...@chromium.org>
Commit-Queue: Aaron Leventhal <aleve...@google.com>
Auto-Submit: Aaron Leventhal <aleve...@google.com>
Cr-Commit-Position: refs/heads/main@{#1558905}
Files:
- M third_party/blink/renderer/core/layout/layout_object.cc
- M third_party/blink/renderer/core/layout/layout_object.h
- M third_party/blink/renderer/core/layout/visual_rect_mapping_test.cc
- M third_party/blink/renderer/platform/graphics/paint/geometry_mapper.cc
- M third_party/blink/renderer/platform/graphics/paint/geometry_mapper.h
- M third_party/blink/renderer/platform/graphics/paint/geometry_mapper_test.cc
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M third_party/blink/web_tests/FlagExpectations/content-extraction
- M third_party/blink/web_tests/TestExpectations
Change size: M
Delta: 9 files changed, 194 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Philip Rogers
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages