[Toolbar] Don't capture on AL [chromium/src : main]
Peilin Wang (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Patrick Noland
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Noland (Gerrit)
Patrick Noland added 1 comment![]( "Open in Gerrit")
Does this cause any issues when, e.g. the tabstrip is hidden/shown (due to window width changes) or when entering/leaving floating window mode?
Related details
- Peilin Wang
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peilin Wang (Gerrit)
Peilin Wang added 1 comment![]( "Open in Gerrit")
Does this cause any issues when, e.g. the tabstrip is hidden/shown (due to window width changes) or when entering/leaving floating window mode?
width change: At the moment, the tabstrip just fades in/out without the toolbar moving. As long as if the toolbar doesn't move, there won't be any issues.
floating window mode: ah I didn't know about this feature (good thing you're reviewing this CL!) how can I test this?
Related details
- Patrick Noland
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Noland (Gerrit)
Patrick Noland added 1 comment![]( "Open in Gerrit")
Peilin WangDoes this cause any issues when, e.g. the tabstrip is hidden/shown (due to window width changes) or when entering/leaving floating window mode?
width change: At the moment, the tabstrip just fades in/out without the toolbar moving. As long as if the toolbar doesn't move, there won't be any issues.
floating window mode: ah I didn't know about this feature (good thing you're reviewing this CL!) how can I test this?
On an AL device in floating window mode, click the app icon/caret in the top left to change window modes. In fullscreen mode, long press the notch at the top center of the screen to get the same menu.
Related details
- Peilin Wang
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peilin Wang (Gerrit)
Peilin Wang added 1 comment![]( "Open in Gerrit")
Peilin WangDoes this cause any issues when, e.g. the tabstrip is hidden/shown (due to window width changes) or when entering/leaving floating window mode?
Patrick Nolandwidth change: At the moment, the tabstrip just fades in/out without the toolbar moving. As long as if the toolbar doesn't move, there won't be any issues.
floating window mode: ah I didn't know about this feature (good thing you're reviewing this CL!) how can I test this?
On an AL device in floating window mode, click the app icon/caret in the top left to change window modes. In fullscreen mode, long press the notch at the top center of the screen to get the same menu.
- Patrick Noland
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Noland (Gerrit)
Patrick Noland added 1 comment![]( "Open in Gerrit")
Peilin WangDoes this cause any issues when, e.g. the tabstrip is hidden/shown (due to window width changes) or when entering/leaving floating window mode?
Patrick Nolandwidth change: At the moment, the tabstrip just fades in/out without the toolbar moving. As long as if the toolbar doesn't move, there won't be any issues.
floating window mode: ah I didn't know about this feature (good thing you're reviewing this CL!) how can I test this?
Peilin WangOn an AL device in floating window mode, click the app icon/caret in the top left to change window modes. In fullscreen mode, long press the notch at the top center of the screen to get the same menu.
Ok I just tried it, I don't see any issues.
Interesting; we force a capture for those scenarios so I thought we would need one, but perhaps that's not true on AL. Adding Wenyu for a second set of eyes.
Related details
- Peilin Wang
- Wenyu Fu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |