[PageInfo] Make the About this site icon a single shared function [chromium/src : main]
0 views
Skip to first unread message
Darryl James (Gerrit)
Oct 22, 2026, 1:44:54 PM (4 days ago) Oct 22
to Foromo Daniel Soromou, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews
Attention needed from Foromo Daniel Soromou
Darryl James voted and added 2 comments on change 8587778![]( "Open in Gerrit")
Votes added by Darryl James <dlj...@chromium.org>
| Code-Review | +1 |
2 comments
Patchset-level comments
File chrome/browser/ui/page_info/about_this_site_icon.h
Line 14, Patchset 2 (Latest):
const gfx::VectorIcon& GetAboutThisSiteIcon();Darryl James . unresolved
optional nit: put this in a namespace (e.g. page_info) so the owner is clear at call sites.
Related details
Attention is currently required from:
- Foromo Daniel Soromou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Foromo Daniel Soromou (Gerrit)
Oct 22, 2026, 2:33:39 PM (4 days ago) Oct 22
to Darryl James, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews
Foromo Daniel Soromou added 1 comment on change 8587778![]( "Open in Gerrit")
File chrome/browser/ui/page_info/about_this_site_icon.h
optional nit: put this in a namespace (e.g. page_info) so the owner is clear at call sites.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Foromo Daniel Soromou (Gerrit)
Oct 22, 2026, 2:33:41 PM (4 days ago) Oct 22
to Darryl James, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews
Foromo Daniel Soromou voted Commit-Queue+2 on change 8587778![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 22, 2026, 4:02:40 PM (4 days ago) Oct 22
to Foromo Daniel Soromou, Darryl James, Code Review Nudger, chromium...@chromium.org, Permissions Reviews
Chromium LUCI CQ submitted change 8587778 with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/browser/ui/webui/webui_toolbar/utils/toolbar_button_utils.cc
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/ui/page_info/about_this_site_icon.h
Insertions: 4, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/ui/browser_actions.cc
Insertions: 5, Deletions: 4.
The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/ui/page_info/about_this_site_icon.cc
Insertions: 4, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/ui/views/page_info/page_info_main_view.cc
Insertions: 2, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[PageInfo] Make the About this site icon a single shared function
The About this site icon was chosen in three places: PageInfoViewFactory
(Views) for the page info bubble. BrowserActions for the side panel
action, which is why the toolkit-agnostic registry included a Views page
info header, and a CHECK in the WebUI toolbar's
ActionItemToPinnedToolbarAction() that hard-coded the same choice.
Add GetAboutThisSiteIcon() in chrome/browser/ui/page_info, in its own
small target, and use it from all three. Its header is toolkit-agnostic;
the Chromium-branded art lives in the Views icon set, so the
implementation depends on //ui/views for that icon data only.
No behavior change.
Bug: 523297513
Change-Id: I19563f8c9b60dd0a33382344ce4dc4256ccf3a56
Reviewed-by: Darryl James <dlj...@chromium.org>
Commit-Queue: Foromo Daniel Soromou <koreta...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1725080}
Files:
- M chrome/browser/ui/BUILD.gn
- M chrome/browser/ui/browser_actions.cc
- M chrome/browser/ui/page_info/BUILD.gn
- A chrome/browser/ui/page_info/about_this_site_icon.cc
- A chrome/browser/ui/page_info/about_this_site_icon.h
- M chrome/browser/ui/views/page_info/BUILD.gn
- M chrome/browser/ui/views/page_info/page_info_main_view.cc
- M chrome/browser/ui/views/page_info/page_info_view_factory.cc
- M chrome/browser/ui/views/page_info/page_info_view_factory.h
- M chrome/browser/ui/webui/webui_toolbar/utils/BUILD.gn
- M chrome/browser/ui/webui/webui_toolbar/utils/toolbar_button_utils.cc
Change size: M
Delta: 11 files changed, 70 insertions(+), 28 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darryl James
Review-Enforcement: Code-Review+1 by Darryl James
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages