[PDF Ink Signatures] In AddFont() save the font name as a crash key [chromium/src : main]

0 views

Skip to first unread message

April Kallmeyer (Gerrit)

unread,

Jul 7, 2026, 6:39:30 PM (16 hours ago) Jul 7

to chromium...@chromium.org, pdf-r...@chromium.org

April Kallmeyer has uploaded the change for review

Commit message

[PDF Ink Signatures] In AddFont() save the font name as a crash key

Read the name over IPC so that the crash key is present if
deserialization fails.

Bug: 503013380

Change-Id: I9f1ffef3d0733fb500a5818333529c400dcdb80e

Change diff

Change information

Files:

M pdf/pdf_ink_module.cc
M pdf/pdf_ink_module_client.h
M pdf/pdf_ink_module_unittest.cc
M pdf/pdf_view_web_plugin.cc
M pdf/pdf_view_web_plugin_unittest.cc
M pdf/pdfium/pdfium_engine.cc
M pdf/pdfium/pdfium_engine.h
M pdf/pdfium/pdfium_engine_unittest.cc
M pdf/test/test_pdfium_engine.h

Change size: M

Delta: 9 files changed, 52 insertions(+), 36 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Aryan Krishnan (Gerrit)

unread,

9:41 AM (1 hour ago) 9:41 AM

to April Kallmeyer, Chromium LUCI CQ, chromium...@chromium.org, pdf-r...@chromium.org

Attention needed from April Kallmeyer

Aryan Krishnan added 4 comments

Commit Message

Line 7, Patchset 1 (Latest):[PDF Ink Signatures] In AddFont() save the font name as a crash key

Aryan Krishnan . unresolved

Move this to the end?

```suggestion
[PDF Ink Signatures] Save the font name as a crash key in AddFont()
```

File pdf/pdf_ink_module.cc

Line 1676, Patchset 1 (Latest): std::string font_name = *item_as_dict.FindString("name");

Aryan Krishnan . unresolved

Nit: Maybe we can move this up to match the order of arguments?

Line 1676, Patchset 1 (Latest): std::string font_name = *item_as_dict.FindString("name");

Aryan Krishnan . unresolved

As far as I see in this patch (again not very sure what happens in the rest of the codebase) but this font_name variable looks immutable to me. Even the functions expect a const std::string. While this does compile as is, wondering if this should be const.

File pdf/pdfium/pdfium_engine.cc

Line 5276, Patchset 1 (Latest): SCOPED_CRASH_KEY_STRING64("pdf", "font_name", font_name);

Aryan Krishnan . unresolved

Is there a restriction on the length of `font_name` of some kind, or anywhere this is truncated?
Perhaps we could increase it?

Open in Gerrit

Related details

Attention is currently required from:

April Kallmeyer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages