[ios] Convert SceneCoordinatorTest to use FakeSceneState [chromium/src : main]
0 views
Skip to first unread message
Sylvain Defresne (Gerrit)
Jul 8, 2026, 10:14:09 AM (2 days ago) Jul 8
to Federica Germinario, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Federica Germinario
Sylvain Defresne added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Federica Germinario
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Federica Germinario (Gerrit)
Jul 8, 2026, 11:18:33 AM (2 days ago) Jul 8
to Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Sylvain Defresne
Federica Germinario voted and added 1 comment![]( "Open in Gerrit")
Votes added by Federica Germinario
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
5:01 AM (2 hours ago) 5:01 AM
to Federica Germinario, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Sylvain Defresne voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:01 AM (1 hour ago) 6:01 AM
to Sylvain Defresne, Federica Germinario, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ios] Convert SceneCoordinatorTest to use FakeSceneState
With the new SceneState API, the class no longer requires a fake
UIScene and thus can use a SceneState directly. Additionally as
it wants to fake BrowserProviderInterface, convert it to instead
use FakeSceneState which already takes care of creating all the
objects.
Bug: 519105565
Change-Id: I83c890aa087aeadd593d02ebd410416135f86c39
Commit-Queue: Sylvain Defresne <sdef...@chromium.org>
Reviewed-by: Federica Germinario <fede...@google.com>
Cr-Commit-Position: refs/heads/main@{#1660150}
Files:
- M ios/chrome/browser/scene/coordinator/BUILD.gn
- M ios/chrome/browser/scene/coordinator/scene_coordinator_unittest.mm
Change size: M
Delta: 2 files changed, 30 insertions(+), 39 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Federica Germinario
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages