Fix Use-After-Free in TransientWindowManager hide cascade [chromium/src : main]
0 views
Skip to first unread message
Mitsuru Oshima (Gerrit)
Jul 24, 2026, 3:12:17 PM (yesterday) Jul 24
to Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Achuith Bhandarkar
Mitsuru Oshima voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Achuith Bhandarkar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Achuith Bhandarkar (Gerrit)
Jul 24, 2026, 3:48:34 PM (24 hours ago) Jul 24
to Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Mitsuru Oshima
Achuith Bhandarkar voted and added 2 comments![]( "Open in Gerrit")
Votes added by Achuith Bhandarkar
| Code-Review | +1 |
2 comments
File ui/wm/core/transient_window_manager.cc
Line 241, Patchset 6 (Latest):
// Hiding transient children may delete parent as well. Achuith Bhandarkar . unresolved
trailing whitespace.
File ui/wm/core/transient_window_manager_unittest.cc
Line 747, Patchset 6 (Latest):
class DeleteParentOnHideObserver : public aura::WindowObserver {Achuith Bhandarkar . unresolved
I don't think this is consistent with chromium style to declare a class in the middle of a function body. You should ask jetski to put it in the anon namespace.
Related details
Attention is currently required from:
- Mitsuru Oshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Jul 24, 2026, 4:47:57 PM (23 hours ago) Jul 24
to Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org
Mitsuru Oshima voted and added 2 comments![]( "Open in Gerrit")
Votes added by Mitsuru Oshima
| Commit-Queue | +1 |
2 comments
File ui/wm/core/transient_window_manager.cc
Line 241, Patchset 6:
// Hiding transient children may delete parent as well. Achuith Bhandarkar . resolved
Mitsuru Oshimatrailing whitespace.
Fix applied.
File ui/wm/core/transient_window_manager_unittest.cc
Line 747, Patchset 6:
class DeleteParentOnHideObserver : public aura::WindowObserver {Achuith Bhandarkar . resolved
I don't think this is consistent with chromium style to declare a class in the middle of a function body. You should ask jetski to put it in the anon namespace.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Jul 24, 2026, 5:53:01 PM (22 hours ago) Jul 24
to Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org
Mitsuru Oshima voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
0 new messages