updater: test more UpdateService methods to get the state and policies [chromium/src : main]

0 views

Skip to first unread message

S Ganesh (Gerrit)

unread,

Jan 13, 2026, 11:54:57 PM (3 hours ago) Jan 13

to Joshua Pawlicki, Sorin Jianu, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Joshua Pawlicki

S Ganesh voted Auto-Submit+1

Auto-Submit

Open in Gerrit

Related details

Attention is currently required from:

Joshua Pawlicki

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sorin Jianu (Gerrit)

unread,

12:21 AM (3 hours ago) 12:21 AM

to S Ganesh, Joshua Pawlicki, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Joshua Pawlicki and S Ganesh

Sorin Jianu added 3 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Sorin Jianu . resolved

ty Ganesh?

File chrome/updater/test/integration_tests.cc

Line 1588, Patchset 3 (Latest):#if !BUILDFLAG(IS_MAC)

Sorin Jianu . unresolved

Why is this !mac? Also, does this work on Linux?

Line 1609, Patchset 3 (Latest):

          std::vector<uint32_t> components =
              base::Version(kUpdaterVersion).components();
          const base::CheckedNumeric<uint32_t> new_version = components[0] + 1;
          ASSERT_TRUE(new_version.AssignIfValid(&components[0]));

Sorin Jianu . unresolved

What is tested here?