[iOS][mvt-customization] Adds feature and constants for in-product help [chromium/src : main]

0 views
Skip to first unread message

Ginny Huang (Gerrit)

unread,
Jan 12, 2026, 11:01:54 AM (19 hours ago) Jan 12
to Robbie Gibson, Benjamin Williams, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dfried...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Benjamin Williams and Robbie Gibson

Ginny Huang voted and added 1 comment

Votes added by Ginny Huang

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ginny Huang . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Williams
  • Robbie Gibson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I858a3b7ae5613a5ab085b3ff359cca0f64fb8e35
Gerrit-Change-Number: 7454540
Gerrit-PatchSet: 1
Gerrit-Owner: Ginny Huang <ginny...@chromium.org>
Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>
Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>
Gerrit-Reviewer: Robbie Gibson <rkgi...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Robbie Gibson <rkgi...@google.com>
Gerrit-Attention: Benjamin Williams <bwwil...@google.com>
Gerrit-Comment-Date: Mon, 12 Jan 2026 16:01:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ginny Huang (Gerrit)

unread,
Jan 12, 2026, 11:09:45 AM (19 hours ago) Jan 12
to Chromium LUCI CQ, Robbie Gibson, Benjamin Williams, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dfried...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Benjamin Williams and Robbie Gibson

Ginny Huang voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Williams
  • Robbie Gibson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I858a3b7ae5613a5ab085b3ff359cca0f64fb8e35
Gerrit-Change-Number: 7454540
Gerrit-PatchSet: 2
Gerrit-Owner: Ginny Huang <ginny...@chromium.org>
Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>
Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>
Gerrit-Reviewer: Robbie Gibson <rkgi...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Robbie Gibson <rkgi...@google.com>
Gerrit-Attention: Benjamin Williams <bwwil...@google.com>
Gerrit-Comment-Date: Mon, 12 Jan 2026 16:09:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Robbie Gibson (Gerrit)

unread,
Jan 12, 2026, 12:12:06 PM (18 hours ago) Jan 12
to Ginny Huang, Chromium LUCI CQ, Benjamin Williams, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dfried...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Benjamin Williams and Ginny Huang

Robbie Gibson voted and added 3 comments

Votes added by Robbie Gibson

Code-Review+1

3 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Robbie Gibson . resolved

lgtm with 2 questions

File components/feature_engagement/public/feature_constants.cc
Line 873, Patchset 2 (Latest): base::FEATURE_DISABLED_BY_DEFAULT);
Robbie Gibson . unresolved

Just making sure you're planning on ramping this flag manually?

File ios/chrome/browser/content_suggestions/most_visited_tiles/coordinator/most_visited_tiles_mediator.mm
Line 369, Patchset 2 (Latest): _engagementTracker->NotifyEvent(
Robbie Gibson . unresolved

Should these be `if (_engagementTracker)` guarded? Or it'll only be nil in unittests, which won't excercise these code paths?

Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Williams
  • Ginny Huang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I858a3b7ae5613a5ab085b3ff359cca0f64fb8e35
    Gerrit-Change-Number: 7454540
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ginny Huang <ginny...@chromium.org>
    Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>
    Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>
    Gerrit-Reviewer: Robbie Gibson <rkgi...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Benjamin Williams <bwwil...@google.com>
    Gerrit-Attention: Ginny Huang <ginny...@chromium.org>
    Gerrit-Comment-Date: Mon, 12 Jan 2026 17:11:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ginny Huang (Gerrit)

    unread,
    1:33 AM (4 hours ago) 1:33 AM
    to Robbie Gibson, Chromium LUCI CQ, Benjamin Williams, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dfried...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Benjamin Williams

    Ginny Huang voted and added 2 comments

    Votes added by Ginny Huang

    Auto-Submit+1
    Commit-Queue+1

    2 comments

    File components/feature_engagement/public/feature_constants.cc
    Line 873, Patchset 2: base::FEATURE_DISABLED_BY_DEFAULT);
    Robbie Gibson . resolved

    Just making sure you're planning on ramping this flag manually?

    Ginny Huang

    Good call

    File ios/chrome/browser/content_suggestions/most_visited_tiles/coordinator/most_visited_tiles_mediator.mm
    Line 369, Patchset 2: _engagementTracker->NotifyEvent(
    Robbie Gibson . resolved

    Should these be `if (_engagementTracker)` guarded? Or it'll only be nil in unittests, which won't excercise these code paths?

    Ginny Huang

    The latter :)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Benjamin Williams
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I858a3b7ae5613a5ab085b3ff359cca0f64fb8e35
      Gerrit-Change-Number: 7454540
      Gerrit-PatchSet: 3
      Gerrit-Owner: Ginny Huang <ginny...@chromium.org>
      Gerrit-Reviewer: Benjamin Williams <bwwil...@google.com>
      Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>
      Gerrit-Reviewer: Robbie Gibson <rkgi...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Benjamin Williams <bwwil...@google.com>
      Gerrit-Comment-Date: Tue, 13 Jan 2026 06:33:23 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Robbie Gibson <rkgi...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages