Fix Freedesktop session suspend type based on WakeLockType [chromium/src : main]
0 views
Skip to first unread message
Thomas Anderson (Gerrit)
Jan 9, 2026, 1:37:01 PM (4 days ago) Jan 9
to Colin Blundell, chromium...@chromium.org, Raphael Kubo da Costa, mattreyno...@chromium.org
Attention needed from Colin Blundell
Thomas Anderson voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reilly Grant (Gerrit)
Jan 9, 2026, 1:48:31 PM (4 days ago) Jan 9
to Thomas Anderson, Reilly Grant, Chromium LUCI CQ, Colin Blundell, chromium...@chromium.org, Raphael Kubo da Costa, mattreyno...@chromium.org
Attention needed from Colin Blundell and Thomas Anderson
Reilly Grant voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Colin Blundell
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 12, 2026, 10:04:01 AM (20 hours ago) Jan 12
to Thomas Anderson, Colin Blundell, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, mattreyno...@chromium.org
Attention needed from Thomas Anderson
Colin Blundell voted and added 2 comments![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
2 comments
Patchset-level comments
Colin Blundell . resolved
Thanks!
File services/device/wake_lock/power_save_blocker/power_save_blocker_linux.cc
Line 174, Patchset 4 (Latest):
DoInhibitCall(FallbackDBusApiForWakeLockType(type_));Colin Blundell . unresolved
AFAICT this CL is a no-op: Is that the intention?
Related details
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Jan 12, 2026, 10:09:44 AM (20 hours ago) Jan 12
to Colin Blundell, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, mattreyno...@chromium.org
Thomas Anderson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Anderson
| Commit-Queue | +1 |
1 comment
File services/device/wake_lock/power_save_blocker/power_save_blocker_linux.cc
Line 174, Patchset 4 (Latest):
DoInhibitCall(FallbackDBusApiForWakeLockType(type_));Colin Blundell . resolved
AFAICT this CL is a no-op: Is that the intention?
Thomas Anderson
Before this change, kPreventAppSuspension would lock with both kFreedesktopScreensaver and kFreedesktopPower. Now it's just kFreedesktopScreensaver.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 12, 2026, 10:12:00 AM (20 hours ago) Jan 12
to Thomas Anderson, Colin Blundell, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, mattreyno...@chromium.org
Attention needed from Thomas Anderson
Colin Blundell added 1 comment![]( "Open in Gerrit")
File services/device/wake_lock/power_save_blocker/power_save_blocker_linux.cc
Line 174, Patchset 4 (Latest):
DoInhibitCall(FallbackDBusApiForWakeLockType(type_));Colin Blundell . resolved
Thomas AndersonAFAICT this CL is a no-op: Is that the intention?
Before this change, kPreventAppSuspension would lock with both kFreedesktopScreensaver and kFreedesktopPower. Now it's just kFreedesktopScreensaver.
Colin Blundell
Ah yes, I was missing that there isn't a return after line 175. Thanks!
Related details
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Jan 12, 2026, 10:55:09 AM (19 hours ago) Jan 12
to Colin Blundell, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, mattreyno...@chromium.org
Thomas Anderson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 12, 2026, 10:58:07 AM (19 hours ago) Jan 12
to Thomas Anderson, Colin Blundell, Reilly Grant, chromium...@chromium.org, Raphael Kubo da Costa, mattreyno...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix Freedesktop session suspend type based on WakeLockType
This is a followup to [1] which made this change for the GNOME API but
did not for the Freedesktop APIs.
[1] https://crrev.com/5d50deb
Bug: 454025651
Change-Id: Id393dd137f52965ea229d7b4330c0c237f331f91
Reviewed-by: Reilly Grant <rei...@chromium.org>
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567783}
Files:
- M services/device/wake_lock/power_save_blocker/power_save_blocker_linux.cc
Change size: S
Delta: 1 file changed, 4 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Reilly Grant, +1 by Colin Blundell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages