Remove stale TODO [chromium/src : main]

0 views
Skip to first unread message

Chris Fredrickson (Gerrit)

unread,
11:42 AM (12 hours ago) 11:42 AM
to Martin Šrámek, Chromium LUCI CQ, chromium...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org
Attention needed from Martin Šrámek

Chris Fredrickson voted

Auto-Submit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Martin Šrámek
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie0002aff25b199a145b3b241e0f28a68904551ba
Gerrit-Change-Number: 6983957
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Martin Šrámek <msr...@chromium.org>
Gerrit-Attention: Martin Šrámek <msr...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 15:42:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Martin Šrámek (Gerrit)

unread,
12:06 PM (12 hours ago) 12:06 PM
to Chris Fredrickson, Chromium LUCI CQ, chromium...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org
Attention needed from Chris Fredrickson

Martin Šrámek voted and added 1 comment

Votes added by Martin Šrámek

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Martin Šrámek . resolved

LGTM, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Fredrickson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie0002aff25b199a145b3b241e0f28a68904551ba
Gerrit-Change-Number: 6983957
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Martin Šrámek <msr...@chromium.org>
Gerrit-Attention: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 16:05:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
12:36 PM (11 hours ago) 12:36 PM
to Chris Fredrickson, Martin Šrámek, chromium...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove stale TODO

This TODO was resolved by https://crrev.com/c/4614444.
Bug: 40270137
Change-Id: Ie0002aff25b199a145b3b241e0f28a68904551ba
Auto-Submit: Chris Fredrickson <cfre...@chromium.org>
Commit-Queue: Martin Šrámek <msr...@chromium.org>
Reviewed-by: Martin Šrámek <msr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1520680}
Files:
  • M components/content_settings/core/common/content_settings_constraints.h
Change size: XS
Delta: 1 file changed, 0 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Martin Šrámek
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie0002aff25b199a145b3b241e0f28a68904551ba
Gerrit-Change-Number: 6983957
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Chris Fredrickson <cfre...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Martin Šrámek <msr...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages