Fix perfetto roll errors [chromium/src : main]
0 views
Skip to first unread message
Oksana Zhuravlova (Gerrit)
Jan 12, 2026, 4:54:31 PM (2 days ago) Jan 12
to Kenichi Ishibashi, Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Gabriel Charette and Kenichi Ishibashi
Oksana Zhuravlova voted and added 1 comment![]( "Open in Gerrit")
Votes added by Oksana Zhuravlova
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Oksana Zhuravlova . resolved
Hello Gabriel and Kenichi,
Could you please take a look at base/test/test_trace_processor_impl.cc and net/log/trace_net_log_observer.cc respectively?
Thanks!
Related details
Attention is currently required from:
- Gabriel Charette
- Kenichi Ishibashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gabriel Charette (Gerrit)
Jan 12, 2026, 6:13:59 PM (2 days ago) Jan 12
to Oksana Zhuravlova, Etienne Pierre-Doray, Gabriel Charette, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Etienne Pierre-Doray, Kenichi Ishibashi and Oksana Zhuravlova
Gabriel Charette voted and added 2 comments![]( "Open in Gerrit")
Votes added by Gabriel Charette
| Code-Review | +1 |
2 comments
Patchset-level comments
Gabriel Charette . resolved
+etienneP to double-check Perfetto but eager-LGTM as it seems trivial
File base/test/test_trace_processor_impl.cc
Line 95, Patchset 3 (Latest):
absl::Status TestTraceProcessorImpl::OverrideSqlModule(Gabriel Charette . unresolved
Should this also become "Package"?
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Kenichi Ishibashi
- Oksana Zhuravlova
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
Jan 12, 2026, 7:14:06 PM (2 days ago) Jan 12
to Oksana Zhuravlova, Etienne Pierre-Doray, Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Etienne Pierre-Doray and Oksana Zhuravlova
Kenichi Ishibashi voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
- Oksana Zhuravlova
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Oksana Zhuravlova (Gerrit)
Jan 13, 2026, 1:05:54 PM (16 hours ago) Jan 13
to Kenichi Ishibashi, Etienne Pierre-Doray, Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Etienne Pierre-Doray, Gabriel Charette and Kenichi Ishibashi
Oksana Zhuravlova voted and added 1 comment![]( "Open in Gerrit")
Votes added by Oksana Zhuravlova
| Commit-Queue | +1 |
1 comment
File base/test/test_trace_processor_impl.cc
Line 95, Patchset 3:
absl::Status TestTraceProcessorImpl::OverrideSqlModule(Gabriel Charette . resolved
Should this also become "Package"?
Oksana Zhuravlova
Updated the name here and in other places for consistency.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Gabriel Charette
- Kenichi Ishibashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jan 13, 2026, 1:31:29 PM (15 hours ago) Jan 13
to Oksana Zhuravlova, Kenichi Ishibashi, Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Gabriel Charette, Kenichi Ishibashi and Oksana Zhuravlova
Etienne Pierre-Doray voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Gabriel Charette
- Kenichi Ishibashi
- Oksana Zhuravlova
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Oksana Zhuravlova (Gerrit)
Jan 13, 2026, 1:52:08 PM (15 hours ago) Jan 13
to Etienne Pierre-Doray, Kenichi Ishibashi, Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Gabriel Charette and Kenichi Ishibashi
Oksana Zhuravlova added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Oksana Zhuravlova . resolved
Thank you Etienne! I still need gab@'s owner +1.
Related details
Attention is currently required from:
- Gabriel Charette
- Kenichi Ishibashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lalit Maganti (Gerrit)
Jan 13, 2026, 2:03:39 PM (15 hours ago) Jan 13
to Oksana Zhuravlova, Etienne Pierre-Doray, Kenichi Ishibashi, Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Gabriel Charette, Kenichi Ishibashi and Oksana Zhuravlova
Lalit Maganti added 1 comment![]( "Open in Gerrit")
File net/log/trace_net_log_observer.cc
Line 206, Patchset 6 (Latest):
const perfetto::DynamicString thread_event_name(thread_event_name_str);Lalit Maganti . unresolved
This needs to be inlined below.
Related details
Attention is currently required from:
- Gabriel Charette
- Kenichi Ishibashi
- Oksana Zhuravlova
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Oksana Zhuravlova (Gerrit)
Jan 13, 2026, 3:35:34 PM (13 hours ago) Jan 13
to Lalit Maganti, Etienne Pierre-Doray, Kenichi Ishibashi, Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Gabriel Charette, Kenichi Ishibashi and Lalit Maganti
Oksana Zhuravlova voted and added 1 comment![]( "Open in Gerrit")
Votes added by Oksana Zhuravlova
| Commit-Queue | +1 |
1 comment
File net/log/trace_net_log_observer.cc
Line 206, Patchset 6:
const perfetto::DynamicString thread_event_name(thread_event_name_str);Lalit Maganti . resolved
This needs to be inlined below.
Oksana Zhuravlova
Replaced the variable with inlining the call to `DynamicString()` in two places below.
Related details
Attention is currently required from:
- Gabriel Charette
- Kenichi Ishibashi
- Lalit Maganti
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gabriel Charette (Gerrit)
Jan 13, 2026, 3:46:58 PM (13 hours ago) Jan 13
to Oksana Zhuravlova, Gabriel Charette, Lalit Maganti, Etienne Pierre-Doray, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Kenichi Ishibashi, Lalit Maganti and Oksana Zhuravlova
Gabriel Charette voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kenichi Ishibashi
- Lalit Maganti
- Oksana Zhuravlova
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
12:33 AM (4 hours ago) 12:33 AM
to Oksana Zhuravlova, Gabriel Charette, Lalit Maganti, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Lalit Maganti and Oksana Zhuravlova
Kenichi Ishibashi voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lalit Maganti
- Oksana Zhuravlova
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages