Do not hide on PContext notice acknowledgement [chromium/src : main]
Jan Keitel (Gerrit)
Jan Keitel voted and added 4 comments![]( "Open in Gerrit")
Votes added by Jan Keitel
| Commit-Queue | +2 |
4 comments
Do not hide on PContext notice acceptanceJan KeitelNity nit with my privacy hat on: notices are acknowledged while consent requests are accepted.
```suggestion
Do not hide on PContext notice acknowledgement
```
Fix applied.
void AutofillPopupControllerImpl::UpdateDataListValues(Jan KeitelFor my own education:
do I understand correctly, that while `RemoveSuggestion()`'s name is semantically a subset of actions that update the suggestions list, we have it and `UpdateDataListValues()` separately because the latter is about responding to the backend changes and the former is about processing user initiated actions?
Well, they're also truly different things. `UpdateDataListValues` updates [datalist attributes](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/datalist) of a form element.
return std::ranges::none_of(GetSuggestions(), &IsStandaloneSuggestionType,Jan KeitelFor my own education:
do I understand correctly, that we cannot simply make search bar return true on `IsStandaloneSuggestionType()` cause while it is another row/element in the pop-up, it is not a `Suggestion`?
That's correct - it's set passed purely as an argument in the `PopupViewViews` constructor.
RemoveLastSuggestion_DoesNotHidePopupForAtMemory) {Jan KeitelFYI While this perfectly covers the underlying AtMemory logic fix, to fully close the notice bug, I'll be adding broader UI test coverage for the Personal Context notice in a separate follow-up. That will help us ensure the notice's robustness and catch any future regressions (like this one) across surfaces.
Tracked in http://b/527824462#comment4.
SG, thank you!
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Do not hide on PContext notice acknowledgement
Removing a popup suggestion triggers evaluating whether the popup
still "has suggestions". In particular, the search bar does not count
as a suggestion.
This CL modifies this condition to return that the popup still
has non-trivial suggestion content as long as the trigger source is
AtMemory because AtMemory always has a search box (which is enough
for us to not hide).
- M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
- M chrome/browser/ui/autofill/autofill_popup_controller_impl.h
- M chrome/browser/ui/autofill/autofill_popup_controller_impl_test_api.h
- M chrome/browser/ui/autofill/autofill_popup_controller_impl_unittest.cc
Code-Review: +1 by Ireneusz Szulc, +1 by Aisulu Rakhmetullina
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |