[text-decorations] Fix excessive ink overflow for multiple lines [chromium/src : main]

1 view
Skip to first unread message

Koji Ishii (Gerrit)

unread,
Jun 30, 2022, 3:46:16 PMJun 30
to atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Kent Tamura, Pinpoint perf, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Kent Tamura, Yoshifumi Inoue.

View Change

1 comment:

To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
Gerrit-Change-Number: 3737326
Gerrit-PatchSet: 7
Gerrit-Owner: Koji Ishii <ko...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
Gerrit-Attention: Yoshifumi Inoue <yo...@chromium.org>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Jun 2022 19:46:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Pinpoint perf (Gerrit)

unread,
Jul 1, 2022, 1:31:34 AMJul 1
to Koji Ishii, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Kent Tamura, Yoshifumi Inoue.

📍 Job complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/13e811ef2a0000

View Change

    To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
    Gerrit-Change-Number: 3737326
    Gerrit-PatchSet: 7
    Gerrit-Owner: Koji Ishii <ko...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
    Gerrit-Attention: Yoshifumi Inoue <yo...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Fri, 01 Jul 2022 05:31:27 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Pinpoint perf (Gerrit)

    unread,
    Jul 1, 2022, 2:38:38 AMJul 1
    to Koji Ishii, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Kent Tamura, Yoshifumi Inoue.

    📍 Job complete.

    See results at: https://pinpoint-dot-chromeperf.appspot.com/job/137efc54aa0000

    View Change

      To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
      Gerrit-Change-Number: 3737326
      Gerrit-PatchSet: 7
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Attention: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Attention: Kent Tamura <tk...@chromium.org>
      Gerrit-Comment-Date: Fri, 01 Jul 2022 06:38:30 +0000

      Koji Ishii (Gerrit)

      unread,
      Jul 1, 2022, 3:45:43 AMJul 1
      to atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Morten Stenshorne, Kent Tamura, Pinpoint perf, Chromium LUCI CQ, chromium...@chromium.org

      Attention is currently required from: Kent Tamura, Morten Stenshorne, Yoshifumi Inoue.

      Patch set 7:Auto-Submit +1

      View Change

      1 comment:

      To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
      Gerrit-Change-Number: 3737326
      Gerrit-PatchSet: 7
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Attention: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Attention: Kent Tamura <tk...@chromium.org>
      Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Comment-Date: Fri, 01 Jul 2022 07:45:34 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Morten Stenshorne (Gerrit)

      unread,
      Jul 1, 2022, 4:28:09 AMJul 1
      to Koji Ishii, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Kent Tamura, Pinpoint perf, Chromium LUCI CQ, chromium...@chromium.org

      Attention is currently required from: Kent Tamura, Koji Ishii, Yoshifumi Inoue.

      Patch set 7:Code-Review +1

      View Change

      2 comments:

      • File third_party/blink/renderer/core/layout/ng/ng_ink_overflow.cc:

        • Patch Set #7, Line 384: {{}, item_size}

          Nit: I generally find it more readable if we call out the types.

          I.e., instead of;
          {{}, item_size}
          Do:
          PhysicalRect(PhysicalPoint(), item_size)

          But up to you.

        • Patch Set #7, Line 555: static_cast<gfx::Vector2dF>(offset_in_container);

          gfx::Vector2dF(offset_in_container) is enough. And looks safer? (although the result is the same in this case)

      To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
      Gerrit-Change-Number: 3737326
      Gerrit-PatchSet: 7
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Attention: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Attention: Koji Ishii <ko...@chromium.org>
      Gerrit-Attention: Kent Tamura <tk...@chromium.org>
      Gerrit-Comment-Date: Fri, 01 Jul 2022 08:27:56 +0000

      Koji Ishii (Gerrit)

      unread,
      Jul 1, 2022, 4:39:35 AMJul 1
      to atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Morten Stenshorne, Kent Tamura, Pinpoint perf, Chromium LUCI CQ, chromium...@chromium.org

      Attention is currently required from: Kent Tamura, Yoshifumi Inoue.

      Patch set 8:Auto-Submit +1Commit-Queue +2

      View Change

      3 comments:

      • Patchset:

      • File third_party/blink/renderer/core/layout/ng/ng_ink_overflow.cc:

        • Nit: I generally find it more readable if we call out the types. […]

          Done

        • gfx::Vector2dF(offset_in_container) is enough. […]

          Done, thanks, I didn't know it was possible to convert that way, such constructor does not seem to exist in `ui/gfx/geometry/vector2d_f.h` nor in `physical_offset.h` but somehow the compiler knows it.

      To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
      Gerrit-Change-Number: 3737326
      Gerrit-PatchSet: 8
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Attention: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Attention: Kent Tamura <tk...@chromium.org>
      Gerrit-Comment-Date: Fri, 01 Jul 2022 08:39:24 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Morten Stenshorne <mste...@chromium.org>
      Gerrit-MessageType: comment

      Chromium LUCI CQ (Gerrit)

      unread,
      Jul 1, 2022, 5:48:58 AMJul 1
      to Koji Ishii, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Morten Stenshorne, Kent Tamura, Pinpoint perf, chromium...@chromium.org

      Chromium LUCI CQ submitted this change.

      View Change



      7 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: third_party/blink/renderer/core/layout/ng/ng_ink_overflow.cc
      Insertions: 4, Deletions: 4.

      @@ -380,9 +380,9 @@
      : PhysicalSize(LayoutUnit(rect.width()),
      LayoutUnit(rect.height() / length_adjust_scale));
      // No |inline_context| because the decoration box is not supported for SVG.
      - absl::optional<PhysicalRect> ink_overflow =
      - ComputeTextInkOverflow(text_info, style, scaled_font, {{}, item_size},
      - /* inline_context */ nullptr);
      + absl::optional<PhysicalRect> ink_overflow = ComputeTextInkOverflow(
      + text_info, style, scaled_font, PhysicalRect(PhysicalOffset(), item_size),
      + /* inline_context */ nullptr);
      const bool needs_transform =
      scaling_factor != 1.0f || !transform.IsIdentity();
      PhysicalSize unscaled_size = PhysicalSize::FromSizeFRound(rect.size());
      @@ -552,7 +552,7 @@
      }
      }
      // Adjust the container coordinate system to the local coordinate system.
      - accumulated_bound -= static_cast<gfx::Vector2dF>(offset_in_container);
      + accumulated_bound -= gfx::Vector2dF(offset_in_container);
      return EnclosingLayoutRect(accumulated_bound);
      }

      ```

      Approvals: Morten Stenshorne: Looks good to me Koji Ishii: Send CL to CQ automatically after approval; Commit
      [text-decorations] Fix excessive ink overflow for multiple lines

      This patch fixes ink overflow of text decorations.

      Before this patch, ink overflow was computed in fragment's
      local coordinate system. When the decorating box is supported,
      the decorating box offset is computed at the container
      coordinate system. This mismatch caused ink overflows to be
      excessive when they are on the second or later lines.

      This patch changes |ComputeTextDecorationOverflow| to use the
      container coordinate system while computing, then to convert
      the result to the local coordinate system.

      Bug: 1339836, 1008951
      Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3737326
      Reviewed-by: Morten Stenshorne <mste...@chromium.org>
      Commit-Queue: Koji Ishii <ko...@chromium.org>
      Auto-Submit: Koji Ishii <ko...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1020019}
      ---
      M third_party/blink/renderer/core/layout/ng/inline/layout_ng_text_combine.cc
      M third_party/blink/renderer/core/layout/ng/inline/ng_fragment_item.cc
      M third_party/blink/renderer/core/layout/ng/ng_ink_overflow.cc
      M third_party/blink/renderer/core/layout/ng/ng_ink_overflow.h
      M third_party/blink/renderer/core/paint/ng/ng_inline_paint_context_test.cc
      M third_party/blink/web_tests/platform/linux/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.txt
      M third_party/blink/web_tests/platform/linux/virtual/backface-visibility-interop/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.txt
      M third_party/blink/web_tests/platform/win/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.txt
      8 files changed, 143 insertions(+), 35 deletions(-)


      To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
      Gerrit-Change-Number: 3737326
      Gerrit-PatchSet: 9
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-MessageType: merged

      Koji Ishii (Gerrit)

      unread,
      Jul 1, 2022, 8:00:31 AMJul 1
      to Chromium LUCI CQ, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Morten Stenshorne, Kent Tamura, Pinpoint perf, chromium...@chromium.org

      View Change

      1 comment:

      • File third_party/blink/renderer/core/layout/ng/ng_ink_overflow.cc:

        • Patch Set #7, Line 555: static_cast<gfx::Vector2dF>(offset_in_container);

          Done, thanks, I didn't know it was possible to convert that way, such constructor does not seem to e […]

          Got this. I think it's not a constructor, but we converted a `static_cast` to a C-style cast. Minor, I don't really mind whichever, but just to check for future, I wonder, this isn't recommended, is this?
          https://google.github.io/styleguide/cppguide.html#Casting

      To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
      Gerrit-Change-Number: 3737326
      Gerrit-PatchSet: 9
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Comment-Date: Fri, 01 Jul 2022 12:00:20 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Koji Ishii <ko...@chromium.org>

      Koji Ishii (Gerrit)

      unread,
      Jul 1, 2022, 8:02:44 AMJul 1
      to Chromium LUCI CQ, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Morten Stenshorne, Kent Tamura, Pinpoint perf, chromium...@chromium.org

      View Change

      1 comment:

      • File third_party/blink/renderer/core/layout/ng/ng_ink_overflow.cc:

        • Got this. I think it's not a constructor, but we converted a `static_cast` to a C-style cast. […]

          nvm, sorry, C style cast is `(gfx::Vector2dF)`, so it's different. There might be somewhere someone defined such a constructor, I just can't find it.

      To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
      Gerrit-Change-Number: 3737326
      Gerrit-PatchSet: 9
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Comment-Date: Fri, 01 Jul 2022 12:02:27 +0000

      Morten Stenshorne (Gerrit)

      unread,
      Jul 1, 2022, 8:10:51 AMJul 1
      to Koji Ishii, Chromium LUCI CQ, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Kent Tamura, Pinpoint perf, chromium...@chromium.org

      View Change

      1 comment:

      • File third_party/blink/renderer/core/layout/ng/ng_ink_overflow.cc:

        • nvm, sorry, C style cast is `(gfx::Vector2dF)`, so it's different. […]

          PhysicalOffset has operator gfx::Vector2dF()

      To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
      Gerrit-Change-Number: 3737326
      Gerrit-PatchSet: 9
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Comment-Date: Fri, 01 Jul 2022 12:10:41 +0000

      Koji Ishii (Gerrit)

      unread,
      Jul 1, 2022, 8:22:58 AMJul 1
      to Chromium LUCI CQ, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Morten Stenshorne, Kent Tamura, Pinpoint perf, chromium...@chromium.org

      View Change

      1 comment:

      • File third_party/blink/renderer/core/layout/ng/ng_ink_overflow.cc:

        • PhysicalOffset has operator gfx::Vector2dF()

          That's a cast operator, so `static_cast` kicks it.
          https://en.cppreference.com/w/cpp/language/cast_operator

          ...or since you referred it, does the constructor-like syntax `gfx:Vector2dF(...)` also kick it? And it's preferred? I didn't know that. One thing learned, thanks.

      To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
      Gerrit-Change-Number: 3737326
      Gerrit-PatchSet: 9
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Comment-Date: Fri, 01 Jul 2022 12:22:48 +0000

      Koji Ishii (Gerrit)

      unread,
      Jul 1, 2022, 8:29:45 AMJul 1
      to Chromium LUCI CQ, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Morten Stenshorne, Kent Tamura, Pinpoint perf, chromium...@chromium.org

      View Change

      1 comment:

      • File third_party/blink/renderer/core/layout/ng/ng_ink_overflow.cc:

      To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
      Gerrit-Change-Number: 3737326
      Gerrit-PatchSet: 9
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Comment-Date: Fri, 01 Jul 2022 12:29:36 +0000

      Koji Ishii (Gerrit)

      unread,
      Jul 1, 2022, 8:37:48 AMJul 1
      to Chromium LUCI CQ, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Morten Stenshorne, Kent Tamura, Pinpoint perf, chromium...@chromium.org

      View Change

      1 comment:

      • File third_party/blink/renderer/core/layout/ng/ng_ink_overflow.cc:

        • Found it, the cast operator […]

          Back to Google C++ styleguide:
          https://google.github.io/styleguide/cppguide.html#Casting
          > Use C++-style casts like static_cast<float>(double_value), or brace initialization for conversion of arithmetic types like int64_t y = int64_t{1} << 42. Do not use cast formats like (int)x unless the cast is to void. You may use cast formats like `T(x)` only when `T` is a class type.

          So the functional cast is in the last sentence.
          > You may use cast formats like `T(x)` only when `T` is a class type.

          For class type, I can't read which of `static_cast`, brace initialization, or functional cast is preferred, but is at least "may use".

      To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
      Gerrit-Change-Number: 3737326
      Gerrit-PatchSet: 9
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
      Gerrit-Comment-Date: Fri, 01 Jul 2022 12:37:35 +0000

      Pinpoint perf (Gerrit)

      unread,
      Jul 1, 2022, 10:58:48 PMJul 1
      to Koji Ishii, Chromium LUCI CQ, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Morten Stenshorne, Kent Tamura, chromium...@chromium.org

      📍 Job complete.

      See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1271de172a0000

      View Change

        To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
        Gerrit-Change-Number: 3737326
        Gerrit-PatchSet: 9
        Gerrit-Owner: Koji Ishii <ko...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
        Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
        Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
        Gerrit-Comment-Date: Sat, 02 Jul 2022 02:58:37 +0000

        Pinpoint perf (Gerrit)

        unread,
        Jul 3, 2022, 9:05:12 PMJul 3
        to Koji Ishii, Chromium LUCI CQ, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Morten Stenshorne, Kent Tamura, chromium...@chromium.org

        😿 Job failed.

        See results at: https://chromeperf.appspot.com/job/140373952a0000

        View Change

          To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
          Gerrit-Change-Number: 3737326
          Gerrit-PatchSet: 9
          Gerrit-Owner: Koji Ishii <ko...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
          Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
          Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
          Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
          Gerrit-Comment-Date: Mon, 04 Jul 2022 01:05:05 +0000

          Pinpoint perf (Gerrit)

          unread,
          Jul 3, 2022, 9:05:13 PMJul 3
          to Koji Ishii, Chromium LUCI CQ, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Morten Stenshorne, Kent Tamura, chromium...@chromium.org

          😿 Job failed.

          See results at: https://chromeperf.appspot.com/job/14bd977f2a0000

          Pinpoint perf (Gerrit)

          unread,
          Aug 4, 2022, 5:05:21 PM (5 days ago) Aug 4
          to Koji Ishii, Chromium LUCI CQ, atotic+...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, glebl+...@chromium.org, lchoi+...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Morten Stenshorne, Kent Tamura, chromium...@chromium.org

          😿 Job failed.

          See results at: https://pinpoint-dot-chromeperf.appspot.com/job/136bbe852a0000

          View Change

            To view, visit change 3737326. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Id144adacc0947c5eaa9c15a1cfbb8a6fb006984e
            Gerrit-Change-Number: 3737326
            Gerrit-PatchSet: 9
            Gerrit-Owner: Koji Ishii <ko...@chromium.org>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
            Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
            Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Yoshifumi Inoue <yo...@chromium.org>
            Gerrit-Comment-Date: Thu, 04 Aug 2022 21:05:04 +0000
            Reply all
            Reply to author
            Forward
            0 new messages