Restore comment explaining difference in color logic [chromium/src : main]

0 views
Skip to first unread message

Dana Fried (Gerrit)

unread,
Jan 9, 2026, 9:11:31 PM (19 hours ago) Jan 9
to Dmytro Yeroshkin, chromium...@chromium.org
Attention needed from Dmytro Yeroshkin

Dana Fried added 1 comment

File chrome/browser/ui/color/win/native_chrome_color_mixer_win.cc
Line 135, Patchset 1 (Latest): // color_utils::GetColorWithMaxContrast()/IsDark() aren't used here because
Dana Fried . unresolved

Note that "get color with max contrast" doesn't depend on light/dark, but on the target background color. It would probably have similar behavior to the logic below.

(But it wouldn't match windows exactly, I guess?)

Open in Gerrit

Related details

Attention is currently required from:
  • Dmytro Yeroshkin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6fd6f8ba19c547dbc777d20b0d5783e70c12dc73
Gerrit-Change-Number: 7426646
Gerrit-PatchSet: 1
Gerrit-Owner: Dmytro Yeroshkin <yero...@chromium.org>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Attention: Dmytro Yeroshkin <yero...@chromium.org>
Gerrit-Comment-Date: Sat, 10 Jan 2026 02:11:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages