Revert "[HybridInAutofill] Allow footer entry point for all dropdowns" [chromium/src : main]

0 views
Skip to first unread message

Chrome Crash (Prod) (Gerrit)

unread,
5:33 AM (7 hours ago) 5:33 AM
to Chromium LUCI CQ, Friedrich Hauser, chromium...@chromium.org
Attention needed from Christoph Schwering and Friedrich Hauser

Chrome Crash (Prod) has uploaded the change for review

Chrome Crash (Prod) would like Chromium LUCI CQ, Friedrich Hauser and Christoph Schwering to review this change.

Commit message

Revert "[HybridInAutofill] Allow footer entry point for all dropdowns"

This reverts commit 6355a62e698071f62be6686120a05203476c764b.

Reason for revert: 
The Suspect CL https://chromium-review.googlesource.com/q/I35d35646860f7857b2c3e2c7edeee63087da4c34 is highly likely the cause of the crash. Please see the crash report http://crash/4034e08b61c9cab8.
Rebase the Revert CL on top of main branch with conflicts allowed option to prevent false positive merge conflicts.

If you agree with the revert CL, please approve it and mark as Commit-Queue +2 to submit it.

More details can be found in the go/crash-revert-cls-creation.

Original change's description:
> [HybridInAutofill] Allow footer entry point for all dropdowns
> 
> Before this change, the new entry point would suppress suggestions that
> require no other suggestions to be present, most notably: Autocomplete.
> 
> This change ensures the footer is always added in a last step which
> allows to show Autocomplete suggestions again even if the hybrid entry
> point must be shown.
> 
> Tested with and without  kAutofillNewSuggestionGeneration enabled.
> 
> Screenshot: http://screen/B6vaDk8cKN9KdPB.png
> Feature: AutofillReintroduceHybridPasskeyDropdownItem
> Bug: 399131928, 399124614
> Change-Id: I35d35646860f7857b2c3e2c7edeee63087da4c34
> Fixed: 476010275
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7486908
> Reviewed-by: Christoph Schwering <schw...@google.com>
> Commit-Queue: Friedrich Hauser <fried...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1570276}
>
Bug: 399131928, 399124614
Change-Id: If787e4393db12fb7af848a2b82573e822b2c5beb

Change diff


Change information

Files:
  • M components/autofill/core/browser/foundations/browser_autofill_manager.cc
  • M components/autofill/core/browser/foundations/browser_autofill_manager.h
  • M components/autofill/core/browser/foundations/browser_autofill_manager_unittest.cc
Change size: M
Delta: 3 files changed, 24 insertions(+), 93 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Christoph Schwering
  • Friedrich Hauser
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If787e4393db12fb7af848a2b82573e822b2c5beb
Gerrit-Change-Number: 7490351
Gerrit-PatchSet: 1
Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Friedrich Hauser <fried...@chromium.org>
Gerrit-Attention: Friedrich Hauser <fried...@chromium.org>
Gerrit-Attention: Christoph Schwering <schw...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Chrome Crash (Prod) (Gerrit)

unread,
5:34 AM (7 hours ago) 5:34 AM
to Rubber Stamper, AyeAye, Chromium LUCI CQ, Friedrich Hauser, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Christoph Schwering and Friedrich Hauser

Chrome Crash (Prod) voted Commit-Queue+1

Trigger the CQ Dryrun through the Set Review API to save waiting time.

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Christoph Schwering
  • Friedrich Hauser
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If787e4393db12fb7af848a2b82573e822b2c5beb
Gerrit-Change-Number: 7490351
Gerrit-PatchSet: 2
Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Friedrich Hauser <fried...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Attention: Friedrich Hauser <fried...@chromium.org>
Gerrit-Attention: Christoph Schwering <schw...@google.com>
Gerrit-Comment-Date: Sat, 17 Jan 2026 10:34:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
5:34 AM (7 hours ago) 5:34 AM
to Chrome Crash (Prod), AyeAye, Chromium LUCI CQ, Friedrich Hauser, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Christoph Schwering and Friedrich Hauser

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Gerrit-Comment-Date: Sat, 17 Jan 2026 10:34:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
5:35 AM (7 hours ago) 5:35 AM
to Chrome Crash (Prod), AyeAye, Chromium LUCI CQ, Friedrich Hauser, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Christoph Schwering and Friedrich Hauser

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Christoph Schwering
  • Friedrich Hauser
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If787e4393db12fb7af848a2b82573e822b2c5beb
    Gerrit-Change-Number: 7490351
    Gerrit-PatchSet: 3
    Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Friedrich Hauser <fried...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Attention: Friedrich Hauser <fried...@chromium.org>
    Gerrit-Attention: Christoph Schwering <schw...@google.com>
    Gerrit-Comment-Date: Sat, 17 Jan 2026 10:35:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages