Fuhsin Liao (Gerrit)

unread,

Jan 8, 2026, 3:22:19 AM (6 days ago) Jan 8

to Grace Cham, Ryo Hashimoto, chromium...@chromium.org

Attention needed from Grace Cham and Ryo Hashimoto

Fuhsin Liao voted and added 1 comment

Votes added by Fuhsin Liao

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Fuhsin Liao . resolved

Here's the fix for CloseButtonMenu~ The fix is exactly the same as nav menu

Open in Gerrit

Related details

Attention is currently required from:

Grace Cham
Ryo Hashimoto

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ryo Hashimoto (Gerrit)

unread,

Jan 8, 2026, 11:43:00 PM (5 days ago) Jan 8

to Fuhsin Liao, Chromium LUCI CQ, Grace Cham, chromium...@chromium.org

Attention needed from Fuhsin Liao and Grace Cham

Ryo Hashimoto voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Fuhsin Liao
Grace Cham

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fuhsin Liao (Gerrit)

unread,

Jan 9, 2026, 1:23:41 AM (5 days ago) Jan 9

to Theresa Sullivan, Ryo Hashimoto, Chromium LUCI CQ, Grace Cham, chromium...@chromium.org

Attention needed from Grace Cham and Theresa Sullivan

Fuhsin Liao voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Grace Cham
Theresa Sullivan

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Neil Coronado (Gerrit)

unread,

Jan 9, 2026, 1:35:32 PM (5 days ago) Jan 9

to Fuhsin Liao, Ryo Hashimoto, Chromium LUCI CQ, Grace Cham, chromium...@chromium.org

Attention needed from Fuhsin Liao and Grace Cham

Neil Coronado voted and added 1 comment

Votes added by Neil Coronado

Code-Review

+1

1 comment

File chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java

Line 5271, Patchset 3 (Latest):

        // Set clipToOutline to true to contain the mouse hover effect inside the
        // popup's outline. Also set the background of the list view to
        // tablet_tab_strip_close_all_tabs_context_menu to make its shape the same as the popup.

Neil Coronado . unresolved

nit: reflow comment

Open in Gerrit

Related details

Attention is currently required from:

Fuhsin Liao
Grace Cham

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fuhsin Liao (Gerrit)

unread,

Jan 12, 2026, 1:49:26 AM (2 days ago) Jan 12

to Neil Coronado, Ryo Hashimoto, Chromium LUCI CQ, Grace Cham, chromium...@chromium.org

Attention needed from Grace Cham and Neil Coronado

Fuhsin Liao added 1 comment

File chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java

Line 5271, Patchset 3 (Latest):

        // Set clipToOutline to true to contain the mouse hover effect inside the
        // popup's outline. Also set the background of the list view to
        // tablet_tab_strip_close_all_tabs_context_menu to make its shape the same as the popup.

Neil Coronado . unresolved

nit: reflow comment

Fuhsin Liao

Sorry can you be more specific?

Open in Gerrit

Related details

Attention is currently required from:

Grace Cham
Neil Coronado

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Neil Coronado (Gerrit)

unread,

Jan 12, 2026, 12:35:04 PM (2 days ago) Jan 12

to Fuhsin Liao, Ryo Hashimoto, Chromium LUCI CQ, Grace Cham, chromium...@chromium.org

Attention needed from Fuhsin Liao and Grace Cham

Neil Coronado added 1 comment

File chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java

Line 5271, Patchset 3 (Latest):

        // Set clipToOutline to true to contain the mouse hover effect inside the
        // popup's outline. Also set the background of the list view to
        // tablet_tab_strip_close_all_tabs_context_menu to make its shape the same as the popup.

Neil Coronado . unresolved

nit: reflow comment

Fuhsin Liao

Sorry can you be more specific?

Neil Coronado

Oops, sorry, I meant that more of the comment's text can likely fit on earlier lines. e.g. something like
```suggestion
        // Set clipToOutline to true to contain the mouse hover effect inside the popup's outline.
        // Also set the background of the list view to tablet_tab_strip_close_all_tabs_context_menu
        // to make its shape the same as the popup.
```

Open in Gerrit

Related details

Attention is currently required from:

Fuhsin Liao
Grace Cham

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fuhsin Liao (Gerrit)

unread,

Jan 13, 2026, 12:59:48 AM (yesterday) Jan 13

to Neil Coronado, Ryo Hashimoto, Chromium LUCI CQ, Grace Cham, chromium...@chromium.org

Attention needed from Grace Cham, Neil Coronado and Ryo Hashimoto

Fuhsin Liao voted and added 1 comment

Votes added by Fuhsin Liao

Auto-Submit

+1

1 comment

File chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java

Line 5271, Patchset 3: // Set clipToOutline to true to contain the mouse hover effect inside the


        // popup's outline. Also set the background of the list view to
        // tablet_tab_strip_close_all_tabs_context_menu to make its shape the same as the popup.

Neil Coronado . resolved

nit: reflow comment

Fuhsin Liao

Sorry can you be more specific?

Neil Coronado

Oops, sorry, I meant that more of the comment's text can likely fit on earlier lines. e.g. something like
```suggestion
        // Set clipToOutline to true to contain the mouse hover effect inside the popup's outline.
        // Also set the background of the list view to tablet_tab_strip_close_all_tabs_context_menu
        // to make its shape the same as the popup.
```

Fuhsin Liao

I see thanks!

Open in Gerrit

Related details

Attention is currently required from:

Grace Cham
Neil Coronado
Ryo Hashimoto

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Neil Coronado (Gerrit)

unread,

Jan 13, 2026, 12:27:29 PM (15 hours ago) Jan 13

to Fuhsin Liao, Ryo Hashimoto, Chromium LUCI CQ, Grace Cham, chromium...@chromium.org

Attention needed from Fuhsin Liao, Grace Cham and Ryo Hashimoto

Neil Coronado voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Fuhsin Liao
Grace Cham
Ryo Hashimoto

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ryo Hashimoto (Gerrit)

unread,

12:02 AM (3 hours ago) 12:02 AM

to Fuhsin Liao, Neil Coronado, Chromium LUCI CQ, Grace Cham, chromium...@chromium.org

Attention needed from Fuhsin Liao, Grace Cham and Neil Coronado

Ryo Hashimoto voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Fuhsin Liao
Grace Cham
Neil Coronado

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

12:46 AM (3 hours ago) 12:46 AM

to Fuhsin Liao, Ryo Hashimoto, Neil Coronado, Grace Cham, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Fix CloseButtonMenu's hover effect out of bound issue

Currently CloseButtonMenu's shadow is a rectangle, yet the menu itself
is a rectangle with rounded corners. This cl match the shadow to its
outline

Before: https://screenshot.googleplex.com/6UqZofRsp96pp24
After: https://screenshot.googleplex.com/56VgLqZ9yPkwARa

Bug: 474237858

Change-Id: Id134ecb649fd6a88709a22ac3cab17a04a68c168

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7414445

Auto-Submit: Fuhsin Liao <fuhsi...@google.com>

Reviewed-by: Neil Coronado <ne...@google.com>

Reviewed-by: Ryo Hashimoto <hash...@chromium.org>

Commit-Queue: Ryo Hashimoto <hash...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1568909}

Files:

M chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java

Change size: XS

Delta: 1 file changed, 9 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Neil Coronado, +1 by Ryo Hashimoto

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Fix CloseButtonMenu's hover effect out of bound issue [chromium/src : main]

Fuhsin Liao (Gerrit)

Fuhsin Liao voted and added 1 comment

Votes added by Fuhsin Liao

1 comment

Related details

Ryo Hashimoto (Gerrit)

Ryo Hashimoto voted Code-Review+1

Related details

Fuhsin Liao (Gerrit)

Fuhsin Liao voted Auto-Submit+1

Related details

Neil Coronado (Gerrit)

Neil Coronado voted and added 1 comment

Votes added by Neil Coronado

1 comment

Related details

Fuhsin Liao (Gerrit)

Fuhsin Liao added 1 comment

Related details

Neil Coronado (Gerrit)

Neil Coronado added 1 comment

Related details

Fuhsin Liao (Gerrit)

Fuhsin Liao voted and added 1 comment

Votes added by Fuhsin Liao

1 comment

Related details

Neil Coronado (Gerrit)

Neil Coronado voted

Related details

Ryo Hashimoto (Gerrit)

Ryo Hashimoto voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information