Ash: Move print media localization to //components/printing [chromium/src : main]

0 views
Skip to first unread message

Rebekah Potter (Gerrit)

unread,
1:43 AM (17 hours ago) 1:43 AM
to Di Wu, Lei Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, cros-print...@google.com, feature-me...@chromium.org, ipc-securi...@chromium.org, jshin...@chromium.org, print-rev...@chromium.org
Attention needed from Di Wu and Lei Zhang

Rebekah Potter added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Rebekah Potter . resolved

Redirecting to thestig@

Open in Gerrit

Related details

Attention is currently required from:
  • Di Wu
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic1496e1a7a12396a1dde677976587720dc132625
Gerrit-Change-Number: 8113948
Gerrit-PatchSet: 1
Gerrit-Owner: Di Wu <di...@google.com>
Gerrit-Reviewer: Di Wu <di...@google.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Di Wu <di...@google.com>
Gerrit-Comment-Date: Tue, 21 Jul 2026 05:43:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
1:14 PM (6 hours ago) 1:14 PM
to Di Wu, Lei Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, cros-print...@google.com, feature-me...@chromium.org, ipc-securi...@chromium.org, jshin...@chromium.org, print-rev...@chromium.org
Attention needed from Di Wu

Lei Zhang added 3 comments

File chrome/common/printing/BUILD.gn
Line 94, Patchset 1 (Latest): sources += [ "print_media_l10n_unittest.cc" ]
Lei Zhang . unresolved

If this CL is moving print_media_l10n.cc, then shouldn't it move print_media_l10n_unittest.cc as well?

File components/printing/common/BUILD.gn
Line 18, Patchset 1 (Latest): configs += [ "//build/config/compiler:wexit_time_destructors" ]
Lei Zhang . unresolved

Is this needed? I thought it was the default already.

File printing/buildflags/buildflags.gni
Line 73, Patchset 1 (Latest): enable_print_media_l10n = is_chromeos || is_mac
Lei Zhang . unresolved

Can just go in the first declare_args() block in the file, since the condition here doesn't depend on any other args.

Open in Gerrit

Related details

Attention is currently required from:
  • Di Wu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic1496e1a7a12396a1dde677976587720dc132625
    Gerrit-Change-Number: 8113948
    Gerrit-PatchSet: 1
    Gerrit-Owner: Di Wu <di...@google.com>
    Gerrit-Reviewer: Di Wu <di...@google.com>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Di Wu <di...@google.com>
    Gerrit-Comment-Date: Tue, 21 Jul 2026 17:14:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages