Convert profile() to GetProfile() (Part 20) [chromium/src : main]
0 views
Skip to first unread message
Thomas Lukaszewicz (Gerrit)
2:52 PM (3 hours ago) 2:52 PM
to Lily Chen, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, crost...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, xinghui...@chromium.org
Attention needed from Lily Chen
Thomas Lukaszewicz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Thomas Lukaszewicz . resolved
Lily ptal (sorry for the large diff, purely mechanical)
Related details
Attention is currently required from:
- Lily Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lily Chen (Gerrit)
3:47 PM (2 hours ago) 3:47 PM
to Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, crost...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, xinghui...@chromium.org
Attention needed from Thomas Lukaszewicz
Lily Chen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Lukaszewicz (Gerrit)
3:59 PM (2 hours ago) 3:59 PM
to Lily Chen, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, crost...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, xinghui...@chromium.org
Thomas Lukaszewicz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
4:04 PM (2 hours ago) 4:04 PM
to Thomas Lukaszewicz, Lily Chen, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, crost...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, xinghui...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Convert profile() to GetProfile() (Part 20)
Change-Id: I84c103d680cb8d77bb1528a91b5e39617a7efe40
Reviewed-by: Lily Chen <chl...@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tl...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659013}
Files:
- M chrome/browser/ui/views/compose/compose_interactive_uitest.cc
- M chrome/browser/ui/views/constrained_window_views_interactive_uitest.cc
- M chrome/browser/ui/views/contextual_tasks/contextual_tasks_button_interactive_ui_test.cc
- M chrome/browser/ui/views/create_application_shortcut_view_browsertest.cc
- M chrome/browser/ui/views/crostini/crostini_recovery_view_browsertest.cc
- M chrome/browser/ui/views/crostini/crostini_uninstaller_view_browsertest.cc
- M chrome/browser/ui/views/crostini/crostini_update_filesystem_view_browsertest.cc
- M chrome/browser/ui/views/data_sharing/collaboration_controller_delegate_desktop_interactive_uitest.cc
- M chrome/browser/ui/views/data_sharing/data_sharing_chrome_native_interactive_uitest.cc
- M chrome/browser/ui/views/data_sharing/data_sharing_live_browsertest.cc
- M chrome/browser/ui/views/device_signals_consent/consent_dialog_browsertest.cc
- M chrome/browser/ui/views/download/bubble/download_bubble_interactive_uitest.cc
- M chrome/browser/ui/views/download/bubble/download_bubble_partial_view.cc
- M chrome/browser/ui/views/download/bubble/download_bubble_primary_view.cc
- M chrome/browser/ui/views/download/bubble/download_bubble_row_view_unittest.cc
- M chrome/browser/ui/views/download/bubble/download_bubble_security_view_unittest.cc
- M chrome/browser/ui/views/download/bubble/download_toolbar_ui_controller.cc
- M chrome/browser/ui/views/download/bubble/download_toolbar_ui_controller_browsertest.cc
- M chrome/browser/ui/views/extensions/dialogs/confirm_protocol_handler_dialog_interactive_uitest.cc
- M chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
- M chrome/browser/ui/views/extensions/extension_popup_interactive_uitest.cc
- M chrome/browser/ui/views/extensions/extension_post_install_dialog_view_utils_signin_browsertest.cc
- M chrome/browser/ui/views/extensions/extensions_dialogs_browsertest.cc
- M chrome/browser/ui/views/extensions/extensions_menu_main_page_view_interactive_uitest.cc
- M chrome/browser/ui/views/extensions/extensions_menu_main_page_view_unittest.cc
- M chrome/browser/ui/views/extensions/extensions_menu_site_permissions_page_view_interactive_uitest.cc
- M chrome/browser/ui/views/extensions/extensions_menu_site_permissions_page_view_unittest.cc
- M chrome/browser/ui/views/extensions/extensions_menu_view_interactive_uitest.cc
- M chrome/browser/ui/views/extensions/extensions_menu_view_unittest.cc
- M chrome/browser/ui/views/extensions/extensions_toolbar_desktop.cc
- M chrome/browser/ui/views/extensions/extensions_toolbar_desktop_interactive_uitest.cc
- M chrome/browser/ui/views/extensions/extensions_toolbar_desktop_unittest.cc
- M chrome/browser/ui/views/extensions/extensions_toolbar_interactive_uitest.cc
- M chrome/browser/ui/views/extensions/extensions_toolbar_unittest.cc
- M chrome/browser/ui/views/extensions/security_dialog_tracker_browsertest.cc
- M chrome/browser/ui/views/extensions/web_file_handlers/web_file_handlers_file_launch_browsertest.cc
- M chrome/browser/ui/views/find_bar_views_interactive_uitest.cc
- M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc
- M chrome/browser/ui/views/frame/browser_frame_ash_browsertest.cc
- M chrome/browser/ui/views/frame/browser_frame_view_browsertest.cc
- M chrome/browser/ui/views/frame/browser_frame_view_browsertest_win.cc
- M chrome/browser/ui/views/frame/browser_frame_view_chromeos.cc
Change size: L
Delta: 42 files changed, 155 insertions(+), 150 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lily Chen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages