[Sheriff] Disable BenchmarkSmokeTests on Mac [chromium/src : main]

Andreea Costinas (Gerrit)

unread,

Oct 4, 2022, 5:02:01 AM10/4/22

to telemetr...@chromium.org, Yuheng Huang, chromium...@chromium.org

View Change

1 comment:

Patchset:
- Patch Set #1:
  Hi Yuheng,
  FYI as an OWNER of the benchmark Desktop UI.

To view, visit change 3931556. To unsubscribe, or for help writing mail filters, visit settings.

Fabian Sommer (Gerrit)

unread,

Oct 4, 2022, 5:12:23 AM10/4/22

to Andreea Costinas, telemetr...@chromium.org, Yuheng Huang, chromium...@chromium.org

Attention is currently required from: Andreea Costinas.

Patch set 1:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #1:
  LGTM

To view, visit change 3931556. To unsubscribe, or for help writing mail filters, visit settings.

Andreea Costinas (Gerrit)

unread,

Oct 4, 2022, 5:38:33 AM10/4/22

to telemetr...@chromium.org, Fabian Sommer, Yuheng Huang, chromium...@chromium.org

Patch set 1:Commit-Queue +2

View Change

To view, visit change 3931556. To unsubscribe, or for help writing mail filters, visit settings.

Andreea Costinas (Gerrit)

unread,

Oct 4, 2022, 5:38:42 AM10/4/22

to telemetr...@chromium.org, Fabian Sommer, Yuheng Huang, chromium...@chromium.org

Patch set 1:Owners-Override +1

View Change

To view, visit change 3931556. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Oct 4, 2022, 7:09:15 AM10/4/22

to Andreea Costinas, telemetr...@chromium.org, Fabian Sommer, Yuheng Huang, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Fabian Sommer: Looks good to me
  Andreea Costinas: Commit; Looks good to me

[Sheriff] Disable BenchmarkSmokeTests on Mac

Tests “desktop_ui” and “power.desktop” keep failing on Mac.

Bug: 1370958
Change-Id: Ic58507f0e1bb684023f26510a7dc3055607d99c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3931556
Commit-Queue: Andreea Costinas <acos...@google.com>
Reviewed-by: Fabian Sommer <fabian...@chromium.org>
Owners-Override: Andreea Costinas <acos...@google.com>
Cr-Commit-Position: refs/heads/main@{#1054634}
---
M tools/perf/benchmarks/benchmark_smoke_unittest.py
1 file changed, 19 insertions(+), 0 deletions(-)

diff --git a/tools/perf/benchmarks/benchmark_smoke_unittest.py b/tools/perf/benchmarks/benchmark_smoke_unittest.py
index 7628455..b7f75a89 100644
--- a/tools/perf/benchmarks/benchmark_smoke_unittest.py
+++ b/tools/perf/benchmarks/benchmark_smoke_unittest.py
@@ -119,6 +119,8 @@
     'v8.runtime_stats.top_25',  # Fails in Windows, crbug.com/1043048
     'wasmpspdfkit',  # Fails in Chrome OS, crbug.com/1191938
     'memory.desktop' if sys.platform == 'darwin' else None,  # crbug.com/1277277
+    'desktop_ui' if sys.platform == 'darwin' else None,  # crbug.com/1370958
+    'power.desktop' if sys.platform == 'darwin' else None,  # crbug.com/1370958
 ]

To view, visit change 3931556. To unsubscribe, or for help writing mail filters, visit settings.

Tito Reyes (Gerrit)

unread,

Oct 16, 2022, 6:21:46 PM10/16/22

to Andreea Costinas, Chromium LUCI CQ, telemetr...@chromium.org, Fabian Sommer, Yuheng Huang, chromium...@chromium.org, Tito Reyes

Tito Reyes has created a revert of this change.

View Change

To view, visit change 3931556. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward