cros/cmd/paris: Add timeout for TLW access initialization in local recovery [infra/infra : main]
0 views
Skip to first unread message
Jason Stanko (Gerrit)
3:04 PM (6 hours ago) 3:04 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Jason Stanko has uploaded the change for review![]( "Open in Gerrit")
Commit message
cros/cmd/paris: Add timeout for TLW access initialization in local recovery
Initialize local TLW access with a 10-second timeout to prevent CLI executions from hanging indefinitely if the lab gRPC service or proxy is unreachable.
BUG=b:536041360
Change-Id: Ibf0d5d383aa870c5216b3a4054b95963a0167ad5
Change diff
diff --git a/go/src/infra/cros/cmd/paris/internal/tasks/local_recovery.go b/go/src/infra/cros/cmd/paris/internal/tasks/local_recovery.go
index 2ddcf18..25ec7fc 100644
--- a/go/src/infra/cros/cmd/paris/internal/tasks/local_recovery.go
+++ b/go/src/infra/cros/cmd/paris/internal/tasks/local_recovery.go
@@ -12,6 +12,7 @@
"path/filepath"
"strings"
"sync/atomic"
+ "time"
"github.com/maruel/subcommands"
@@ -285,7 +286,7 @@
}
}
ctx = scopes.WithParams(ctx, params)
- access, err := recovery.NewLocalTLWAccess(ctx, ic)
+ access, err := newLocalTLWAccessWithTimeout(ctx, ic)
if err != nil {
return errors.Fmt("local recovery: create tlw access: %w", err)
}
@@ -318,6 +319,14 @@
return nil
}
+// newLocalTLWAccessWithTimeout initializes local TLW access with a 10-second timeout
+// to prevent CLI executions from hanging indefinitely if the lab gRPC service or proxy is unreachable.
+func newLocalTLWAccessWithTimeout(ctx context.Context, ic *recovery.LocalTLWConfig) (tlw.Access, error) {
+ initCtx, cancel := context.WithTimeout(ctx, 10*time.Second)
+ defer cancel()
+ return recovery.NewLocalTLWAccess(initCtx, ic)
+}
+
func (c *localRecoveryRun) getLogRoot() (string, error) {
// TODO(gregorynisbet): Clean up the logs, include the current timestamp, or generally
// do something smarter than just setting the logs to "./logs".
Change information
Files:
- M go/src/infra/cros/cmd/paris/internal/tasks/local_recovery.go
Change size: S
Delta: 1 file changed, 10 insertions(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
4:49 PM (4 hours ago) 4:49 PM
to Jason Stanko, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Jason Stanko
Otabek Kasimov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jason Stanko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jason Stanko (Gerrit)
6:56 PM (2 hours ago) 6:56 PM
to Otabek Kasimov, chromium...@chromium.org, infra-rev...@chromium.org
Jason Stanko voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
LUCI CQ (Gerrit)
7:16 PM (2 hours ago) 7:16 PM
to Jason Stanko, Otabek Kasimov, chromium...@chromium.org, infra-rev...@chromium.org
LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cros/cmd/paris: Add timeout for TLW access initialization in local recovery
Initialize local TLW access with a 10-second timeout to prevent CLI executions from hanging indefinitely if the lab gRPC service or proxy is unreachable.
BUG=b:536041360
Change-Id: Ibf0d5d383aa870c5216b3a4054b95963a0167ad5
Commit-Queue: Jason Stanko <jst...@google.com>
Reviewed-by: Otabek Kasimov <ota...@google.com>
Cr-Commit-Position: refs/heads/main@{#82045}
Files:
- M go/src/infra/cros/cmd/paris/internal/tasks/local_recovery.go
Change size: S
Delta: 1 file changed, 11 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Otabek Kasimov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages