[Extensions] Move chrome_settings_overrides handler into //extensions/ [chromium/src : main]

0 views

Skip to first unread message

Anton Bershanskyi (Gerrit)

unread,

Jan 10, 2026, 1:35:26 PM (7 days ago) Jan 10

to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, devtools...@chromium.org

Attention needed from Devlin Cronin

Anton Bershanskyi added 9 comments

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Anton Bershanskyi . resolved

Hi Devlin,
this is a minor refactor with no functional changes, it just moves some extension manifest code from //chrome into //extensions. I left explanations in inline resolved comments explaining most changes.
Would you be interested in reviewing this change? I'll add the second reviewer after your review. Thanks!

File chrome/common/extensions/api/_manifest_features.json

Line 22, Patchset 14 (Latest): },

Anton Bershanskyi . resolved

Moved verbatim to `extensions/common/api/_manifest_features.json`.

File chrome/common/extensions/api/manifest_types.json

Line 15, Patchset 14 (Latest): {

Anton Bershanskyi . resolved

Moved verbatim to `extensions/common/api/extensions_manifest_types.json`.

File chrome/common/extensions/permissions/chrome_api_permissions.cc

Line 220, Patchset 14 (Latest): APIPermissionInfo::kFlagDoesNotRequireManagedSessionFullLoginWarning},

Anton Bershanskyi . resolved

Moved verbatim to `extensions/common/permissions/extensions_api_permissions.cc`.

File extensions/common/api/_manifest_features.json

Line 117, Patchset 14 (Latest): }],

Anton Bershanskyi . resolved

Moved verbatim from `chrome/common/extensions/api/_manifest_features.json`.

File extensions/common/api/extensions_manifest_types.json

Line 30, Patchset 14 (Latest): {

Anton Bershanskyi . resolved

Moved verbatim from `chrome/common/extensions/api/manifest_types.json`.

File extensions/common/manifest_handlers/settings_overrides_handler.h

Line 25, Patchset 14 (Latest): ~SettingsOverrides() override;

Anton Bershanskyi . resolved

I updated signature of `SettingsOverrides::Get()` to accept a const-reference `const&` instead of const-pointer `const*` because the code never calls it with null pointers and function assumes parameter to be non-null and dereferences it without checking.

File extensions/common/manifest_handlers/settings_overrides_unittest.cc

Anton Bershanskyi . resolved

I just moved/renamed this file, formatted it, and updated `manifest_version` from `2` to `3`.

File extensions/common/permissions/extensions_api_permissions.cc

Line 179, Patchset 14 (Latest): {APIPermissionID::kWmDesksPrivate, "wmDesksPrivate"},

Anton Bershanskyi . resolved

Moved verbatim from `chrome/common/extensions/permissions/chrome_api_permissions.cc`.

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Anton Bershanskyi (Gerrit)

unread,

3:15 AM (10 hours ago) 3:15 AM

to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, devtools...@chromium.org

Attention needed from Devlin Cronin

Anton Bershanskyi added 1 comment

Patchset-level comments

File-level comment, Patchset 16 (Latest):

Anton Bershanskyi . resolved

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages