unittest workaround for change in NSS trust flags in 3.114 [chromium/src : main]
0 views
Skip to first unread message
Matt Mueller (Gerrit)
Sep 25, 2025, 12:34:37 PM (yesterday) Sep 25
to Matt Mueller, David Benjamin, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org
Attention needed from David Benjamin
Matt Mueller added 1 comment![]( "Open in Gerrit")
File net/cert/internal/trust_store_nss_unittest.cc
Line 88, Patchset 3 (Latest):
// return `CERTDB_VALID_CA | CERTDB_TRUSTED_CA | CERTDB_NS_TRUSTED_CA`.Matt Mueller . unresolved
In classic NSS fashion, there is no documentation about what CERTDB_NS_TRUSTED_CA actually means. From reviewing the diff it appears that redundantly both CERTDB_TRUSTED_CA and CERTDB_NS_TRUSTED_CA will be set on trusted certs. ¯\\\_(ツ)\_/¯
Related details
Attention is currently required from:
- David Benjamin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Benjamin (Gerrit)
Sep 25, 2025, 3:39:21 PM (23 hours ago) Sep 25
to Matt Mueller, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Matt Mueller
David Benjamin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Matt Mueller
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Mueller (Gerrit)
Sep 25, 2025, 3:44:31 PM (23 hours ago) Sep 25
to Matt Mueller, David Benjamin, Chromium LUCI CQ, chromium...@chromium.org, net-r...@chromium.org
Matt Mueller voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matt Mueller
| Commit-Queue | +2 |
1 comment
File net/cert/internal/trust_store_nss_unittest.cc
Line 88, Patchset 3 (Latest):
// return `CERTDB_VALID_CA | CERTDB_TRUSTED_CA | CERTDB_NS_TRUSTED_CA`.Matt Mueller . resolved
In classic NSS fashion, there is no documentation about what CERTDB_NS_TRUSTED_CA actually means. From reviewing the diff it appears that redundantly both CERTDB_TRUSTED_CA and CERTDB_NS_TRUSTED_CA will be set on trusted certs. ¯\\\_(ツ)\_/¯
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 25, 2025, 3:48:13 PM (23 hours ago) Sep 25
to Matt Mueller, David Benjamin, chromium...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
unittest workaround for change in NSS trust flags in 3.114
The NSS change only affected the unittest, as the test does equality
comparison of the trust value, while the production code checks for the presence or absence of certain flag combinations and thus isn't affected by the addition of this redundant flag.
Bug: 447174557
Change-Id: Iff23c4ead3b5dcc557a75374776176660a70ba8b
Commit-Queue: Matt Mueller <ma...@chromium.org>
Reviewed-by: David Benjamin <davi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1520818}
Files:
- M net/cert/internal/trust_store_nss_unittest.cc
Change size: S
Delta: 1 file changed, 13 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by David Benjamin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages