Propagate attr() taint through interpolable custom property transitions [chromium/src : main]
0 views
Skip to first unread message
Kevin Babbitt (Gerrit)
Jul 16, 2026, 1:29:10 PM (5 days ago) Jul 16
to Robert Flack, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Robert Flack
Kevin Babbitt added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Robert Flack
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Flack (Gerrit)
Jul 16, 2026, 4:58:24 PM (5 days ago) Jul 16
to Kevin Babbitt, Kevin Ellis, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Babbitt and Kevin Ellis
Robert Flack added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Kevin Babbitt
- Kevin Ellis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Babbitt (Gerrit)
Jul 20, 2026, 12:38:59 PM (21 hours ago) Jul 20
to Kevin Ellis, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Ellis
Kevin Babbitt added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Kevin Ellis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Ellis (Gerrit)
Jul 20, 2026, 12:54:41 PM (21 hours ago) Jul 20
to Kevin Babbitt, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Babbitt
Kevin Ellis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kevin Ellis
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Kevin Babbitt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jul 20, 2026, 1:06:46 PM (20 hours ago) Jul 20
to Kevin Babbitt, Kevin Ellis, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Babbitt
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/61421.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Kevin Babbitt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Babbitt (Gerrit)
Jul 20, 2026, 1:17:34 PM (20 hours ago) Jul 20
to Blink W3C Test Autoroller, Kevin Ellis, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Kevin Babbitt voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kevin Babbitt
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 20, 2026, 2:57:05 PM (19 hours ago) Jul 20
to Kevin Babbitt, Blink W3C Test Autoroller, Kevin Ellis, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Propagate attr() taint through interpolable custom property transitions
For custom property transitions, we were calculating is_attr_tainted
only in discrete transition cases. This allowed the flag to be laundered
away in interpolable transitions.
This CL factors is_attr_tainted computation onto the common path and
propagates it through the pipeline for interpolable transitions.
Fixed: 517746687
Change-Id: I07a965b29838567d746fa48cb270c74c2bbdd6aa
Reviewed-by: Kevin Ellis <kev...@chromium.org>
Commit-Queue: Kevin Babbitt <kbab...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1664831}
Files:
- M third_party/blink/renderer/core/animation/css/css_animations.cc
- M third_party/blink/renderer/core/animation/css_default_interpolation_type.h
- M third_party/blink/renderer/core/animation/css_interpolation_environment.h
- M third_party/blink/renderer/core/animation/css_interpolation_type.cc
- M third_party/blink/renderer/core/animation/css_interpolation_type.h
- M third_party/blink/renderer/core/animation/transition_interpolation.cc
- M third_party/blink/renderer/core/animation/transition_interpolation.h
- M third_party/blink/renderer/core/animation/transition_keyframe.cc
- M third_party/blink/renderer/core/animation/transition_keyframe.h
- A third_party/blink/web_tests/external/wpt/css/css-values/attr-security-transition-interpolated.html
Change size: M
Delta: 10 files changed, 129 insertions(+), 32 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kevin Ellis
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jul 20, 2026, 4:01:51 PM (18 hours ago) Jul 20
to Chromium LUCI CQ, Kevin Babbitt, Kevin Ellis, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/61421
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages