Replace IsValidLocaleSyntax in favor of LanguageTag usage [chromium/src : main]

[Danilo Tedeschi (Gerrit)]

Attention needed from Colin Blundell

Danilo Tedeschi voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I30cdaca200ba338814f3fd9718855383260248cd

Gerrit-Change-Number: 8100782

Gerrit-PatchSet: 3

Gerrit-Owner: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Danilo Tedeschi <da...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Comment-Date: Wed, 15 Jul 2026 17:36:13 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Vignesh Shenvi (Gerrit)]

Attention needed from Colin Blundell, Danilo Tedeschi and Reilly Grant

Vignesh Shenvi voted and added 1 comment

Votes added by Vignesh Shenvi

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Vignesh Shenvi . resolved

//chromeos/ash/components/boca/babelorca changes LGTM!

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Danilo Tedeschi
• Reilly Grant

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I30cdaca200ba338814f3fd9718855383260248cd

Gerrit-Change-Number: 8100782

Gerrit-PatchSet: 5

Gerrit-Owner: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vignesh Shenvi <vsh...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Danilo Tedeschi <da...@google.com>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Comment-Date: Wed, 15 Jul 2026 20:55:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Vignesh Shenvi (Gerrit)]

Attention needed from Colin Blundell, Danilo Tedeschi and Reilly Grant

Vignesh Shenvi added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Vignesh Shenvi . resolved

Also cc April and Ahmed as FYI.

Gerrit-CC: Ahmed Nasr <an...@chromium.org>

Gerrit-CC: April Zhou <apri...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Danilo Tedeschi <da...@google.com>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Comment-Date: Wed, 15 Jul 2026 20:56:21 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Reilly Grant (Gerrit)]

Attention needed from Colin Blundell and Danilo Tedeschi

Reilly Grant voted and added 2 comments

Votes added by Reilly Grant

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Reilly Grant . resolved

LGTM with a nit

File chrome/browser/chromeos/extensions/info_private/info_private_api.cc

Line 354, Patchset 5 (Latest): return std::make_unique<base::Value>(std::string(
ash::StartupUtils::GetInitialLocale(local_state).tag_string()));

Reilly Grant . unresolved

`base::Value` has a constructor that takes a `std::string_view`.

```suggestion
    return std::make_unique<base::Value>(
        ash::StartupUtils::GetInitialLocale(local_state).tag_string());
```

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Danilo Tedeschi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I30cdaca200ba338814f3fd9718855383260248cd

Gerrit-Change-Number: 8100782

Gerrit-PatchSet: 5

Gerrit-Owner: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vignesh Shenvi <vsh...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Ahmed Nasr <an...@chromium.org>

Gerrit-CC: April Zhou <apri...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Danilo Tedeschi <da...@google.com>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Comment-Date: Wed, 15 Jul 2026 22:13:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Danilo Tedeschi (Gerrit)]

Attention needed from Colin Blundell, Reilly Grant and Vignesh Shenvi

Danilo Tedeschi added 1 comment

File chrome/browser/chromeos/extensions/info_private/info_private_api.cc

Line 354, Patchset 5: return std::make_unique<base::Value>(std::string(
ash::StartupUtils::GetInitialLocale(local_state).tag_string()));

Reilly Grant . resolved

`base::Value` has a constructor that takes a `std::string_view`.

```suggestion
    return std::make_unique<base::Value>(
        ash::StartupUtils::GetInitialLocale(local_state).tag_string());
```

Danilo Tedeschi

Done

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Reilly Grant
• Vignesh Shenvi

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I30cdaca200ba338814f3fd9718855383260248cd

Gerrit-Change-Number: 8100782

Gerrit-PatchSet: 7

Gerrit-Owner: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vignesh Shenvi <vsh...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Ahmed Nasr <an...@chromium.org>

Gerrit-CC: April Zhou <apri...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Vignesh Shenvi <vsh...@google.com>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Comment-Date: Wed, 15 Jul 2026 23:03:01 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>

[Reilly Grant (Gerrit)]

Attention needed from Colin Blundell, Danilo Tedeschi and Vignesh Shenvi

Reilly Grant voted and added 2 comments

Votes added by Reilly Grant

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Reilly Grant . resolved

//extensions LGTM

File chrome/browser/resources/ash/settings/os_a11y_page/chromevox_subpage.ts

File-level comment, Patchset 7 (Latest):

Reilly Grant . unresolved

Looks like an unrelated change may have snuck into this patch.

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Danilo Tedeschi
• Vignesh Shenvi

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I30cdaca200ba338814f3fd9718855383260248cd

Gerrit-Change-Number: 8100782

Gerrit-PatchSet: 7

Gerrit-Owner: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vignesh Shenvi <vsh...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Ahmed Nasr <an...@chromium.org>

Gerrit-CC: April Zhou <apri...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Vignesh Shenvi <vsh...@google.com>

Gerrit-Attention: Danilo Tedeschi <da...@google.com>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Comment-Date: Wed, 15 Jul 2026 23:06:19 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Danilo Tedeschi (Gerrit)]

Attention needed from Colin Blundell, Reilly Grant and Vignesh Shenvi

Danilo Tedeschi added 1 comment

File chrome/browser/resources/ash/settings/os_a11y_page/chromevox_subpage.ts

File-level comment, Patchset 7:

Reilly Grant . unresolved

Looks like an unrelated change may have snuck into this patch.

Danilo Tedeschi

no, actually, had to change that, the locales 'sk-g1' are not considered valid by LanguageTag (because they are not 'g1' is not a valid region subtag). This is one solution I had for making the tests pass. WDYT?

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Reilly Grant
• Vignesh Shenvi

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I30cdaca200ba338814f3fd9718855383260248cd

Gerrit-Change-Number: 8100782

Gerrit-PatchSet: 8

Gerrit-Owner: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vignesh Shenvi <vsh...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Ahmed Nasr <an...@chromium.org>

Gerrit-CC: April Zhou <apri...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Vignesh Shenvi <vsh...@google.com>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Comment-Date: Wed, 15 Jul 2026 23:15:31 +0000

[Reilly Grant (Gerrit)]

Attention needed from Colin Blundell, Danilo Tedeschi and Vignesh Shenvi

Reilly Grant added 1 comment

File chrome/browser/resources/ash/settings/os_a11y_page/chromevox_subpage.ts

File-level comment, Patchset 7:

Reilly Grant . unresolved

Looks like an unrelated change may have snuck into this patch.

Danilo Tedeschi

no, actually, had to change that, the locales 'sk-g1' are not considered valid by LanguageTag (because they are not 'g1' is not a valid region subtag). This is one solution I had for making the tests pass. WDYT?

Reilly Grant

I'll defer to an owner here but is it okay that other locales like "en-us" are shortened to "en"?

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Danilo Tedeschi
• Vignesh Shenvi

Gerrit-Attention: Danilo Tedeschi <da...@google.com>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Comment-Date: Wed, 15 Jul 2026 23:24:35 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Danilo Tedeschi <da...@google.com>

Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>

[Danilo Tedeschi (Gerrit)]

Attention needed from Colin Blundell, Reilly Grant and Vignesh Shenvi

Danilo Tedeschi added 1 comment

File chrome/browser/resources/ash/settings/os_a11y_page/chromevox_subpage.ts

File-level comment, Patchset 7:

Reilly Grant . resolved

Looks like an unrelated change may have snuck into this patch.

Danilo Tedeschi

no, actually, had to change that, the locales 'sk-g1' are not considered valid by LanguageTag (because they are not 'g1' is not a valid region subtag). This is one solution I had for making the tests pass. WDYT?

Reilly Grant

I'll defer to an owner here but is it okay that other locales like "en-us" are shortened to "en"?

Danilo Tedeschi

reverted that, now I decided to correct the locale name in third_party/liblouis/tables.json

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Reilly Grant
• Vignesh Shenvi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I30cdaca200ba338814f3fd9718855383260248cd

Gerrit-Change-Number: 8100782

Gerrit-PatchSet: 8

Gerrit-Owner: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vignesh Shenvi <vsh...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Ahmed Nasr <an...@chromium.org>

Gerrit-CC: April Zhou <apri...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Vignesh Shenvi <vsh...@google.com>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Comment-Date: Thu, 16 Jul 2026 00:33:44 +0000

[Reilly Grant (Gerrit)]

Attention needed from Colin Blundell, Danilo Tedeschi, Ramin Halavati and Vignesh Shenvi

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 9:

Reilly Grant . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Danilo Tedeschi
• Ramin Halavati
• Vignesh Shenvi

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I30cdaca200ba338814f3fd9718855383260248cd

Gerrit-Change-Number: 8100782

Gerrit-PatchSet: 10

Gerrit-Owner: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vignesh Shenvi <vsh...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Ahmed Nasr <an...@chromium.org>

Gerrit-CC: April Zhou <apri...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Vignesh Shenvi <vsh...@google.com>

Gerrit-Attention: Danilo Tedeschi <da...@google.com>

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Attention: Ramin Halavati <rhal...@chromium.org>

Gerrit-Comment-Date: Thu, 16 Jul 2026 00:38:13 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Ramin Halavati (Gerrit)]

Attention needed from Colin Blundell, Danilo Tedeschi and Vignesh Shenvi

Ramin Halavati voted and added 1 comment

Votes added by Ramin Halavati

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Ramin Halavati . resolved

chrome/renderer/accessibility/read_anything/read_anything_app_controller.cc LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Danilo Tedeschi
• Vignesh Shenvi

Gerrit-Comment-Date: Thu, 16 Jul 2026 04:25:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Colin Blundell (Gerrit)]

Attention needed from Danilo Tedeschi and Vignesh Shenvi

Colin Blundell added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Colin Blundell . resolved

Thanks! Are there any behavioral changes as part of this CL? It's not obvious.

Open in Gerrit

Related details

Attention is currently required from:

• Danilo Tedeschi
• Vignesh Shenvi

Gerrit-Comment-Date: Thu, 16 Jul 2026 10:17:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Danilo Tedeschi (Gerrit)]

Attention needed from Colin Blundell and Vignesh Shenvi

Danilo Tedeschi added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Colin Blundell . resolved

Thanks! Are there any behavioral changes as part of this CL? It's not obvious.

Danilo Tedeschi

Nope, it is no-op.

There was only a single place where the tests had to be adapted due to folks using fake region codes that are not valid, such as g1, g2.

Open in Gerrit

Related details

Attention is currently required from:

• Colin Blundell
• Vignesh Shenvi

Gerrit-Attention: Colin Blundell <blun...@chromium.org>

Gerrit-Comment-Date: Thu, 16 Jul 2026 16:12:16 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Colin Blundell <blun...@chromium.org>

[Colin Blundell (Gerrit)]

Attention needed from Danilo Tedeschi and Vignesh Shenvi

Colin Blundell voted and added 2 comments

Votes added by Colin Blundell

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Colin Blundell . resolved

Thanks! LGTM with question.

File chrome/browser/ash/guest_os/guest_os_registry_service.cc

Line 169, Patchset 11 (Latest): std::replace(locale_with_dashes.begin(), locale_with_dashes.end(), '_',

Colin Blundell . unresolved

Above you eliminated this code, whereas here you didn't. Is there a reason for the difference?

Open in Gerrit

Related details

Attention is currently required from:

• Danilo Tedeschi
• Vignesh Shenvi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I30cdaca200ba338814f3fd9718855383260248cd

Gerrit-Change-Number: 8100782

Gerrit-PatchSet: 11

Gerrit-Owner: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vignesh Shenvi <vsh...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Ahmed Nasr <an...@chromium.org>

Gerrit-CC: April Zhou <apri...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Vignesh Shenvi <vsh...@google.com>

Gerrit-Attention: Danilo Tedeschi <da...@google.com>

Gerrit-Comment-Date: Fri, 17 Jul 2026 11:09:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Danilo Tedeschi (Gerrit)]

Attention needed from Vignesh Shenvi

Danilo Tedeschi added 1 comment

File chrome/browser/ash/guest_os/guest_os_registry_service.cc

Line 169, Patchset 11: std::replace(locale_with_dashes.begin(), locale_with_dashes.end(), '_',

Colin Blundell . resolved

Above you eliminated this code, whereas here you didn't. Is there a reason for the difference?

Danilo Tedeschi

Done.

Open in Gerrit

Related details

Attention is currently required from:

• Vignesh Shenvi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I30cdaca200ba338814f3fd9718855383260248cd

Gerrit-Change-Number: 8100782

Gerrit-PatchSet: 12

Gerrit-Owner: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vignesh Shenvi <vsh...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Ahmed Nasr <an...@chromium.org>

Gerrit-CC: April Zhou <apri...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Vignesh Shenvi <vsh...@google.com>

Gerrit-Comment-Date: Fri, 17 Jul 2026 15:03:13 +0000

[Danilo Tedeschi (Gerrit)]

Attention needed from Vignesh Shenvi

Danilo Tedeschi voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Fri, 17 Jul 2026 15:03:21 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

11 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/ash/guest_os/guest_os_registry_service.cc
Insertions: 1, Deletions: 5.

@@ -164,12 +164,8 @@
   base::DictValue result;
   for (const auto& strings_with_locale : repeated_locale_string.values()) {
     const std::string& locale = strings_with_locale.locale();
-
-    std::string locale_with_dashes(locale);
-    std::replace(locale_with_dashes.begin(), locale_with_dashes.end(), '_',
-                 '-');
     if (!locale.empty() && !base::i18n::LanguageTagConverter::GetInstance()
-                                .FromString(locale_with_dashes)
+                                .FromString(locale)
                                 .has_value()) {
       continue;
     }
```

Change information

Commit message:

Replace IsValidLocaleSyntax in favor of LanguageTag usage

I'm making small changes to third_party/liblouis/tables.json following
the pattern in that file to have ids like "sk-g1" and locale: "sk". I
had to change that because "sk-g1" is not a valid bcp47 language tag as
"g1" is not a valid region subtag:

https://www.rfc-editor.org/info/rfc5646/#section-2.1

```
 region        = 2ALPHA              ; ISO 3166-1 code
               / 3DIGIT              ; UN M.49 code
```

Bug: 526738932

Change-Id: I30cdaca200ba338814f3fd9718855383260248cd

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8100782

Reviewed-by: Ramin Halavati <rhal...@chromium.org>

Reviewed-by: Reilly Grant <rei...@chromium.org>

Commit-Queue: Danilo Tedeschi <da...@google.com>

Reviewed-by: Colin Blundell <blun...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1663929}

Files:

• M chrome/browser/ash/guest_os/guest_os_registry_service.cc
• M chrome/browser/ash/login/startup_utils.cc
• M chrome/browser/ash/login/startup_utils.h
• M chrome/browser/chromeos/extensions/info_private/info_private_api.cc
• M chrome/browser/extensions/external_provider_impl.cc
• M chrome/browser/speech/extension_api/tts_engine_extension_api.cc
• M chrome/browser/speech/extension_api/tts_extension_api.cc
• M chrome/renderer/accessibility/read_anything/read_anything_app_controller.cc
• M chrome/renderer/extensions/api/accessibility_private_hooks_delegate.cc
• M chromeos/ash/components/boca/babelorca/babel_orca_caption_translator.cc
• M chromeos/ash/components/boca/babelorca/babel_orca_caption_translator.h
• M extensions/common/api/speech/tts_engine_manifest_handler.cc
• M extensions/common/manifest_handlers/default_locale_handler.cc
• M third_party/liblouis/tables.json
• M ui/base/l10n/l10n_util.cc
• M ui/base/l10n/l10n_util.h
• M ui/base/l10n/l10n_util_unittest.cc

Change size: L

Delta: 17 files changed, 110 insertions(+), 202 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Reilly Grant, +1 by Colin Blundell, +1 by Ramin Halavati

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I30cdaca200ba338814f3fd9718855383260248cd

Gerrit-Change-Number: 8100782

Gerrit-PatchSet: 13

Gerrit-Owner: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vignesh Shenvi <vsh...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Ahmed Nasr <an...@chromium.org>

Gerrit-CC: April Zhou <apri...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

[Colin Blundell (Gerrit)]

Attention needed from Danilo Tedeschi

Colin Blundell added 1 comment

File chrome/browser/ash/guest_os/guest_os_registry_service.cc

Line 169, Patchset 11: std::replace(locale_with_dashes.begin(), locale_with_dashes.end(), '_',

Colin Blundell . unresolved

Above you eliminated this code, whereas here you didn't. Is there a reason for the difference?

Danilo Tedeschi

Done.

Colin Blundell

For clarity, can you explain why it's a no-op to eliminate this code?

Open in Gerrit

Related details

Attention is currently required from:

• Danilo Tedeschi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I30cdaca200ba338814f3fd9718855383260248cd

Gerrit-Change-Number: 8100782

Gerrit-PatchSet: 13

Gerrit-Owner: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>

Gerrit-Reviewer: Danilo Tedeschi <da...@google.com>

Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vignesh Shenvi <vsh...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Ahmed Nasr <an...@chromium.org>

Gerrit-CC: April Zhou <apri...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Danilo Tedeschi <da...@google.com>

Gerrit-Comment-Date: Mon, 20 Jul 2026 09:45:35 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Danilo Tedeschi <da...@google.com>

Comment-In-Reply-To: Colin Blundell <blun...@chromium.org>

[Danilo Tedeschi (Gerrit)]

Danilo Tedeschi added 1 comment

File chrome/browser/ash/guest_os/guest_os_registry_service.cc

Line 169, Patchset 11: std::replace(locale_with_dashes.begin(), locale_with_dashes.end(), '_',

Colin Blundell . unresolved

Above you eliminated this code, whereas here you didn't. Is there a reason for the difference?

Danilo Tedeschi

Done.

Colin Blundell

For clarity, can you explain why it's a no-op to eliminate this code?

Danilo Tedeschi

Yep, the LanguageTagConverter::FromString code has a step to convert legacy ICU4C locale format to BCP47 format. You can see it here: https://source.chromium.org/chromium/chromium/src/+/main:base/i18n/tag_converters.cc;l=135;drc=0ce06599d4f0c331bfc4018b20e0b196f375cdc2

This is a centralized way of doing that convertion that has more steps than just replacing underscores with dashes. It also goes into possible extensions (what goes after '@' symbol).

Open in Gerrit

Related details

Attention set is empty

Gerrit-Comment-Date: Mon, 20 Jul 2026 17:06:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Colin Blundell <blun...@chromium.org>

Comment-In-Reply-To: Danilo Tedeschi <da...@google.com>

[Colin Blundell (Gerrit)]

Colin Blundell added 1 comment

File chrome/browser/ash/guest_os/guest_os_registry_service.cc

Line 169, Patchset 11: std::replace(locale_with_dashes.begin(), locale_with_dashes.end(), '_',

Colin Blundell . resolved

Above you eliminated this code, whereas here you didn't. Is there a reason for the difference?

Danilo Tedeschi

Done.

Colin Blundell

For clarity, can you explain why it's a no-op to eliminate this code?

Danilo Tedeschi

Yep, the LanguageTagConverter::FromString code has a step to convert legacy ICU4C locale format to BCP47 format. You can see it here: https://source.chromium.org/chromium/chromium/src/+/main:base/i18n/tag_converters.cc;l=135;drc=0ce06599d4f0c331bfc4018b20e0b196f375cdc2

This is a centralized way of doing that convertion that has more steps than just replacing underscores with dashes. It also goes into possible extensions (what goes after '@' symbol).

Colin Blundell

Thanks! I figured it was something like that. In the future, that's the kind of info that is great to put in the CL description to benefit reviewers (and future readers).

Gerrit-Comment-Date: Tue, 21 Jul 2026 06:51:58 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No