Add permissions_policy.h as an allowed user of url::Origin. [chromium/src : main]

1 view
Skip to first unread message

Fergal Daly (Gerrit)

unread,
Jun 21, 2024, 3:04:36 AM6/21/24
to Fergal Daly, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Kentaro Hara

Fergal Daly voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kentaro Hara
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2af437049b669a666949e77dac19eb20acb9080d
Gerrit-Change-Number: 5644807
Gerrit-PatchSet: 1
Gerrit-Owner: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Fri, 21 Jun 2024 07:04:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kentaro Hara (Gerrit)

unread,
Jun 21, 2024, 3:33:42 AM6/21/24
to Fergal Daly, Ian Clelland, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Fergal Daly

Kentaro Hara voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fergal Daly
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2af437049b669a666949e77dac19eb20acb9080d
Gerrit-Change-Number: 5644807
Gerrit-PatchSet: 1
Gerrit-Owner: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Ian Clelland <icle...@chromium.org>
Gerrit-Attention: Fergal Daly <fer...@chromium.org>
Gerrit-Comment-Date: Fri, 21 Jun 2024 07:33:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Fergal Daly (Gerrit)

unread,
Jun 21, 2024, 3:34:18 AM6/21/24
to Fergal Daly, Kentaro Hara, Ian Clelland, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org

Fergal Daly voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2af437049b669a666949e77dac19eb20acb9080d
Gerrit-Change-Number: 5644807
Gerrit-PatchSet: 1
Gerrit-Owner: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Ian Clelland <icle...@chromium.org>
Gerrit-Comment-Date: Fri, 21 Jun 2024 07:34:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 21, 2024, 3:39:27 AM6/21/24
to Fergal Daly, Kentaro Hara, Ian Clelland, chromium...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Add permissions_policy.h as an allowed user of url::Origin.

The file already uses it. The presubmit is being triggered by
https://crrev.com/c/5311943 which touches a line containing
url::Origin.
Bug: 40285153
Change-Id: I2af437049b669a666949e77dac19eb20acb9080d
Auto-Submit: Fergal Daly <fer...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Commit-Queue: Fergal Daly <fer...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1317813}
Files:
  • M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
Change size: XS
Delta: 1 file changed, 8 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kentaro Hara
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2af437049b669a666949e77dac19eb20acb9080d
Gerrit-Change-Number: 5644807
Gerrit-PatchSet: 2
Gerrit-Owner: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
open
diffy
satisfied_requirement

โฮเซ่ มาร์ติเนซ (Gerrit)

unread,
7:25 PM (4 hours ago) 7:25 PM
to Chromium LUCI CQ, Fergal Daly, Kentaro Hara, Ian Clelland, chromium...@chromium.org, blink-...@chromium.org

โฮเซ่ มาร์ติเนซ added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
โฮเซ่ มาร์ติเนซ . resolved
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2af437049b669a666949e77dac19eb20acb9080d
Gerrit-Change-Number: 5644807
Gerrit-PatchSet: 2
Gerrit-Owner: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Ian Clelland <icle...@chromium.org>
Gerrit-CC: โฮเซ่ มาร์ติเนซ <sslhub...@gmail.com>
Gerrit-Comment-Date: Sun, 08 Feb 2026 00:25:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages